Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221205175140.1543229-1-nphamcs@gmail.com> <20221205175140.1543229-3-nphamcs@gmail.com>
 <Y49eT0JmOt97Caca@casper.infradead.org>
In-Reply-To: <Y49eT0JmOt97Caca@casper.infradead.org>
From:   Nhat Pham <nphamcs@gmail.com>
Date:   Wed, 7 Dec 2022 09:28:29 -0800
Message-ID: <CAKEwX=MmiswiBwEjS_7S9++JjRb0pbD0kcvY_UhrU4zN0tTiVQ@mail.gmail.com>
Subject: Re: [PATCH v2 2/4] workingset: refactor LRU refault to expose refault
 recency check
To:     Matthew Wilcox <willy@infradead.org>
Cc:     akpm@linux-foundation.org, hannes@cmpxchg.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, bfoster@redhat.com,
        kernel-team@meta.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Dec 6, 2022 at 7:22 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Mon, Dec 05, 2022 at 09:51:38AM -0800, Nhat Pham wrote:
> > +static bool lru_gen_test_recent(void *shadow, bool file, int *memcgid,
> > +     struct pglist_data **pgdat, unsigned long *token, bool *workingset)
>
> This line needs more than one tab indent.  I tend to use two tabs,
> others try to line up the parameters with the opening '('.  But
> one tab is too visually similar to the body of the function.
>
> >       rcu_read_lock();
> >
> >       memcg = folio_memcg_rcu(folio);
> > +
> > +     if (!lru_gen_test_recent(shadow, type, &memcg_id, &pgdat, &token,
> > +             &workingset))
>
> Similarly here.  &workingset looks like it's part of the body of the if,
> not part of the function call.
>
> > +             goto unlock;
> > +
> >       if (memcg_id != mem_cgroup_id(memcg))
> >               goto unlock;
> >

That's fair - I'll add another tab to each of these lines! Let me
know if you have any other concerns.