Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1216334rwb; Wed, 7 Dec 2022 09:59:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf6W7Y8Wwr9CAZFp12TBmFb6/+jKOBpctqoX5S4bNMellimkNST5hGnKrmktWzzPZEi9iZC6 X-Received: by 2002:a17:902:82c4:b0:189:e81b:c52c with SMTP id u4-20020a17090282c400b00189e81bc52cmr10084505plz.92.1670435976124; Wed, 07 Dec 2022 09:59:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670435976; cv=none; d=google.com; s=arc-20160816; b=KXxf42ZlDbCjHavoLL2V0fHfgvNwGHBmxcjRghU4A3ex+1Pn5vnGCgiGGmQWX/rnXy fc3g40rDZWVnVT762o1xro8r0/4GrzPt8De68QaRRVJEQOTajKeCoVs0rk+vHm39IY05 oB9e/1GDs752YBjfK3y7sE3tUdAoktucdSEWsu51Es+Yzk8WOmtenVN6B7ovZok9AuiH tkPqR3tU/CMYT4jhjIG2DB1l9TDfDzEaXB6WoK5XFWi4FDUT25vSwMY5uZQzoOd8Vcxg Z8juz8tDKmXR1jvDOhdj67GSmx+buBt7q5NAOjvcjaSLVJaWlojURlP1fPcSiHBwh8zn z3ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=fmTU/mImpT1iElM9ydVbPQ5+jzfhrjd8hKLmNuCnrtA=; b=PPYeXFbBiWC0xJDpksG7CKYO3YB+FzsYRA0huTiFOrwYh46oMI9QWsLKDTOEpjQAA9 3S4oX67qITk4k0wsodP5pI6ouEfwlfMSI5Q7SFjH4u88SvhUotmT/QtCDeKH70R6ywVF DYypCoyNWIzy6jaYHnLi2VlA4xM84PxAWlbgjaOSZrGrx7M5m/w5GaWiB9NOmbKR8Hpn Z4heXL8+IjjEVmgVn7NbORqsQlQQxAbYI0yodxBDvzHpSfUuLlcEegwXd0ODTLzrOjdh h9AGVXFsmZVQrA4guMLvC5ZavARSbRPlTavYShVZ30C3NZiN44vQ+gBV0r2wFYEum2W9 +THQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=FoCp6OwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ob1-20020a17090b390100b0021308f24606si2221121pjb.123.2022.12.07.09.59.26; Wed, 07 Dec 2022 09:59:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=FoCp6OwO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230109AbiLGRtq (ORCPT + 74 others); Wed, 7 Dec 2022 12:49:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230092AbiLGRtn (ORCPT ); Wed, 7 Dec 2022 12:49:43 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A85DC686BD for ; Wed, 7 Dec 2022 09:49:42 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id o1-20020a17090a678100b00219cf69e5f0so2156234pjj.2 for ; Wed, 07 Dec 2022 09:49:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=fmTU/mImpT1iElM9ydVbPQ5+jzfhrjd8hKLmNuCnrtA=; b=FoCp6OwOkMomeJki5qTJ5ZIwdluYVoJuDIuM7dVE4M7I570uNFFkDoKGWWMI3bIaJ7 nR40KGXb/l6O469TFTUxwqgs5P11smJAk4DYuGLERKacF+9pfcoYyUnO3vTab+VTvgoB KRscF1wS12ZEhcYoR1/UzR+qQt7FMef4IqZrw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fmTU/mImpT1iElM9ydVbPQ5+jzfhrjd8hKLmNuCnrtA=; b=PGH82+ZifPfyvIFk5zYd4OpuIu0iTea5XzubB4feGarFTQJLnjfdpvOTrDMJZlWeow HAyXnkSOp4+xUudAuDbUjKTr6dpyK3XjLgH++E9esd5vB1tIu4n5wbW/q+geiAGqmoId 1k7AHfqsFL84Fymk0KT2UA68E+y545mzUdCgJc4vyarj+aEV8dLQg0EtE1XWTq2hAvhd atuMaXj3xR1WU6WOa37gC7ut+ElFW6cPSTeD4zVTg0X4xvDNPro+dl59Gcjab45zJ4RJ k0uMxzjmbeeIoWEBvAqaVZqaVodYvpwPS9lSWZ72HnncScywwFKuSLzuWqHxMFnOv72n tgyQ== X-Gm-Message-State: ANoB5pnIPxQ1ePZU7yXx7mIspqtRHNnF7Ml1M78sd3bUsBWMb7BHqMCL 8ezMVotlYqZUGTCDjdXFKU3EgbP1HU/uHJeC80c6iw== X-Received: by 2002:a17:90a:4745:b0:213:1442:24be with SMTP id y5-20020a17090a474500b00213144224bemr103534897pjg.15.1670435382094; Wed, 07 Dec 2022 09:49:42 -0800 (PST) MIME-Version: 1.0 References: <20221109184244.7032-1-ajit.khaparde@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Wed, 7 Dec 2022 09:49:24 -0800 Message-ID: Subject: Re: [PATCH v4 0/6] Add Auxiliary driver support To: Leon Romanovsky Cc: andrew.gospodarek@broadcom.com, davem@davemloft.net, edumazet@google.com, jgg@ziepe.ca, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, michael.chan@broadcom.com, netdev@vger.kernel.org, pabeni@redhat.com, selvin.xavier@broadcom.com Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000972f8105ef408b37" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --000000000000972f8105ef408b37 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 29, 2022 at 1:13 AM Leon Romanovsky wrote: > > On Mon, Nov 28, 2022 at 06:01:13PM -0800, Ajit Khaparde wrote: > > On Tue, Nov 22, 2022 at 10:59 PM Leon Romanovsky wrote: > > > ::: snip ::: > > > > > > > > > So we are trying to call the > > > > bnxt_re_sriov_config in the context of handling the PF's > > > > sriov_configure implementation. Having the ulp_ops is allowing us to > > > > avoid resource wastage and assumptions in the bnxt_re driver. > > > > > > To which resource wastage are you referring? > > Essentially the PF driver reserves a set of above resources for the PF, > > and divides the remaining resources among the VFs. > > If the calculation is based on sriov_totalvfs instead of sriov_numvfs, > > there can be a difference in the resources provisioned for a VF. > > And that is because a user may create a subset of VFs instead of the > > total VFs allowed in the PCI SR-IOV capability register. > > I was referring to the resource wastage in that deployment scenario. > > It is ok, set all needed limits in bnxt_en. You don't need to call to > bnxt_re for that. Thanks. We have removed the sriov_config callback. I will send the fresh patchset in a few minutes. > > > > > Thanks > > Ajit > > > > > > > > There are no differences if same limits will be in bnxt_en driver when > > > RDMA bnxt device is created or in bnxt_re which will be called once RDMA > > > device is created. > > > > > > Thanks > > > > > > > > > > > ::snip:: > > > > > > > > --000000000000972f8105ef408b37 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIDZ4q+kOZPmwKfPY4f+4 ittD9mKQf6bbiYBDgrmOJpj9MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIyMTIwNzE3NDk0MlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQBHd54PVU5nhfPQkvd6QUcpJ53ROXdNlCVBOaDM hQK6cRwxWnUs4h7ZrTD+kQv7N0rnARbJeGlFGYW7jJWOiYmgl962Mi/kSXYg25feo0tWws1WP6fl jHPqUXq7I4cp8AWSoAN2K1Xqr5+iEIutzWY1ZkyPKxm/MVyjNTNoIR1g3d8OAUbPRVPPoeb/kyi5 xaPkJUfahfTK1nf14KEX580QLhMP9YBdKRcR16ErqBZFGgpp33YDfHdRRAM1N8EkfeeWqZ/kh3Xl kGp0EyEXUhwn0qQwloRILBgY8ExTJkPvuVO5w3efmHXhABpUhv6XGzxCynw6XKYUbTf61SQqEHMh --000000000000972f8105ef408b37--