Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932529AbXHMXGq (ORCPT ); Mon, 13 Aug 2007 19:06:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754607AbXHMXGe (ORCPT ); Mon, 13 Aug 2007 19:06:34 -0400 Received: from cantor.suse.de ([195.135.220.2]:48717 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752424AbXHMXGc (ORCPT ); Mon, 13 Aug 2007 19:06:32 -0400 Date: Tue, 14 Aug 2007 02:00:41 +0200 From: Andi Kleen To: Christoph Lameter Cc: Andi Kleen , Mel Gorman , Lee.Schermerhorn@hp.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/4] Embed zone_id information within the zonelist->zones pointer Message-ID: <20070814000041.GL3406@bingen.suse.de> References: <200708110304.55433.ak@suse.de> <20070813225020.GE3406@bingen.suse.de> <20070813225841.GG3406@bingen.suse.de> <20070813230801.GH3406@bingen.suse.de> <20070813234322.GJ3406@bingen.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1519 Lines: 37 On Mon, Aug 13, 2007 at 03:54:34PM -0700, Christoph Lameter wrote: > On Tue, 14 Aug 2007, Andi Kleen wrote: > > > On Mon, Aug 13, 2007 at 03:38:10PM -0700, Christoph Lameter wrote: > > > I just did a grep for GFP_DMA and I still see a large list of GFP_DMA > > > kmallocs??? > > > > I converted all of those that applied to x86. > > Converted to what? Hmm, do you actually read my emails? I spelled that out at least two times now. It's converted to a new dma page allocator that specifies an address mask. > > drivers/net/tokenring/3c359.c: xl_priv->xl_tx_ring = kmalloc((sizeof(struct xl_tx_desc) * XL_TX_RING_SIZE) + 7, GFP_DMA | GFP_KERNEL) ; > drivers/net/tokenring/3c359.c: xl_priv->xl_rx_ring = kmalloc((sizeof(struct xl_rx_desc) * XL_RX_RING_SIZE) +7, GFP_DMA | GFP_KERNEL) ; > > Tokenring not supported on x86? It can be easily converted to a page allocation. The only tricky part were skbs in a few drivers, but luckily they are only needed for bouncing which can be done without a skb too. For RX it adds one copy, but we can live with that because they're only slow devices. Right now it is a little inefficient because it's one page per packet even though two would fit, but these devices have all tiny RX rings so it's not that big a waste. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/