Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 11:04:55 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Sidhartha Kumar <sidhartha.kumar@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        akpm@linux-foundation.org, songmuchun@bytedance.com,
        willy@infradead.org, almasrymina@google.com, linmiaohe@huawei.com,
        hughd@google.com, tsahu@linux.ibm.com, jhubbard@nvidia.com,
        david@redhat.com
Subject: Re: [PATCH mm-unstable v5 08/10] mm/hugetlb: convert
 free_gigantic_page() to folios
Message-ID: <Y5Dj1yT1xmEJHXF3@monkey>
References: <20221129225039.82257-1-sidhartha.kumar@oracle.com>
 <20221129225039.82257-9-sidhartha.kumar@oracle.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221129225039.82257-9-sidhartha.kumar@oracle.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x1p5UaiBDZvsipuPnmgyCDgCTPbpbOqmDJaT9nkSRS4t7Td1lsP26NYsleAW?=
 =?us-ascii?Q?WAI1Q0XFWiPHUvefSlVCKHyso4+Z8H81fzHjTB/PJJFgpcXFIb4GwWZHzwJa?=
 =?us-ascii?Q?Pmibad7dBcRGwpxUckfTe6xBLKsyfYCXqzJ7KWnMT1xHIeWe5IzcYfh/M63V?=
 =?us-ascii?Q?cBbvCyfc7OViCEZRNZ5PzSyMxeZENwoFPOkINP5U9HVbvD+jvlWN1NonBo3C?=
 =?us-ascii?Q?gvj33uBLQps7hoPdICfG9o06HKpfKpcKTUVj7RC0iMbOocnc0q+oj31nrpj0?=
 =?us-ascii?Q?xXx95SxnNkynO9hz5iQtm/cXEOGqUSP/HlV+d0xyn3X9RLh0r90Na2RdahgS?=
 =?us-ascii?Q?/wXNi5b+lp3kQkrxz/eT3V+wJO+OcKhiGma/NOBx+sq0MqpFNYqfhP5KOb5g?=
 =?us-ascii?Q?itcIiCstLGScmlNtffbnbXGrHjoYYXwskgUlgdfhAn9fTriqGBZVllEtZKor?=
 =?us-ascii?Q?HdZKZ2G4LLc7BJ86AjPfrGDYmGKoUm1J7ryQ1HXgPpRBSRCCykLmAWORykXw?=
 =?us-ascii?Q?BXr2+oES7tMlPa3kTxrDiBI+FDKAoNuSYnigJng+zPfD1oRC9iYU/xREUZUv?=
 =?us-ascii?Q?NaKQp6BeGODrAxHVkRiJPGzXO/9y3dZwvDfIV45qd08xxxxlZebqHbJC7Kvv?=
 =?us-ascii?Q?YyuFl8KlM1yAYJDdUKll9ggPiDN9CO71Liq72S6k56DIc1f39KdCR0vW9txD?=
 =?us-ascii?Q?x2GqTA/TcP+eGqq6VBc/JlJP2ZmufoBeB16Lzafe1aiJjdPOeDH+UjnNO3rL?=
 =?us-ascii?Q?AkEAfY+hmvTm5KhnM3S8KUAqOer+p8WP6NTEdybzvw/Nj/rpP5MMbDT/13EZ?=
 =?us-ascii?Q?ViWKPhCr2C9k5VShJjdtIerdnljV0N4JESIQJZooEV/8cuV8j6pZY8709T6S?=
 =?us-ascii?Q?yWWmzK35bvZOLFmS8pON6ih6MU8OiYOE/cez+d3Yv7V/XIAgcWB1bqoUnF2C?=
 =?us-ascii?Q?V1V+YYIOZKdUu0WdBPjzrtGJoI0dKOGJb2eoToVsAZeMvnkBbXaEuSOALyBC?=
 =?us-ascii?Q?tL6HcCAxifd0LsRG6EDgv3IzTM9s/KgTx53d5GT2l5jNFvq1Xi28lccnHu3C?=
 =?us-ascii?Q?zwP3wFGI5gOGFP5azV/fGwJarBRLP3erCxNICv6M72mmus5PPdnelgR0Ehej?=
 =?us-ascii?Q?8ve7vqt9m7wBmnNV4EmD01thzzAHvMt/J56iKRSs4OmAIKH7y8yJ1TTcqa1y?=
 =?us-ascii?Q?Y6I8GL6oQ7QBWicvsy4PIGtIV5CGRsT8PebSNjaSGeUoQ9eopSGm66SkMXZy?=
 =?us-ascii?Q?enalWUQFfXkL73np5N5AQgaLzcRLFTUpH0tMzTPx7G8BIsjGPS9vgHLM20d9?=
 =?us-ascii?Q?EqnJfkONkqEqv5HnezodNwMmlr3Gb4riLOdkD/BcLi8ehNmhP2xhB5owtZsK?=
 =?us-ascii?Q?grTrbwBwWiifn4+txvz6QLjLpRtRycjgHVpc0opAuCaoediNr5PRifYQ6eKs?=
 =?us-ascii?Q?454ENFKP0T3S4vDQOf08cz83xlDRZFNxfd6O4/oyBvSvaH+LNHkkrmyDDW8N?=
 =?us-ascii?Q?5mRncGdHhUOVGlT+Lb6HIP82LweFK2fPF3qP68HAz5c3ZqBTqJmDxwC2GRwy?=
 =?us-ascii?Q?BFzba6gadapsdfNyXSr1Coes2DEt4oIC+WU1pkK/0WS33/bQA0ZbAfmBaGtz?=
 =?us-ascii?Q?mA=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c28be67-4ebb-4169-1d66-08dad885ef12
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 19:04:59.6298
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j4G+Y9XT49noAuvBZQemmPYdlABA9kmCn+76O4CJJ28hYaJ2VuS2tpa+xUJCDwat4U8vXzkqgZ8FLAR6vWKXMQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR10MB6560
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-07_09,2022-12-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0
 malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2212070162
X-Proofpoint-ORIG-GUID: _4u9aLFoyQ51etY7BeNqYKCUW2bEAMc0
X-Proofpoint-GUID: _4u9aLFoyQ51etY7BeNqYKCUW2bEAMc0
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/29/22 14:50, Sidhartha Kumar wrote:
> Convert callers of free_gigantic_page() to use folios, function is then
> renamed to free_gigantic_folio().

More changes to __update_and_free_page than expected based on this
description.  However, they are all folio conversion related so ...

> 
> Signed-off-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
> ---
>  mm/hugetlb.c | 29 +++++++++++++++++------------
>  1 file changed, 17 insertions(+), 12 deletions(-)

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

-- 
Mike Kravetz