Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1394746rwb; Wed, 7 Dec 2022 12:29:44 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ClFyBPowwXGZ7lxuu5aXJWtZA4b8aFe7uwMrXEg/MDZTVZQ/aLoextXQFt7tlXK1E7JjT X-Received: by 2002:a05:6402:1156:b0:467:374e:5f9b with SMTP id g22-20020a056402115600b00467374e5f9bmr65347738edw.283.1670444984267; Wed, 07 Dec 2022 12:29:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670444984; cv=none; d=google.com; s=arc-20160816; b=r4FeeY61xX8qx3mFWLnYHj0oUllDB97vBwcKEBcTXgv2+1LcVe601YUWnwRSsGL5lH OahwP7aeKz+7G6b4e+z3lRPgo6NUhXURvPdSXa8Ntl1+nDeP4ceP22CRRvdQwKLD3eCI 1zMiR4uMsSInw6B/XFVK8sjHIKFB78Qkjl+KFxxbqulRNsB2u4JYRa5iVYLlm/mBo7Je 0lv38X7l1L541igPdRX+jfEG97NFNmp8tpA8l58xaIu/72/2rWFkvyFCj+xl2zNrdJph 7jJP9lqROj9JtzUJx5+WgHfKd42hifo4TYCljiSne++5xpnzsDIwtWIpbyRjDdPPl3Ed WRZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Eh9NhAnoQecLCp7nuLOnthOFNLGPDmhbnX28mSicZBc=; b=YvP8wf0eekH69RusiD32LBuSFekj4iEj6c/WpgXefCfzOIJO7hKHA7yIBkwlONgmFq xzrebGbR2WktxOj/1lsUYp3xyTE9cnbmnxQFcgi5gj6p3BYAnUNeLZgLK7gbOzuhC9N3 V/Ekj2QacMCagxn5/G8EgR9UnETsSMdVh/zLAyA6GonO54kdZKE9CSJdTKBzpuvwZPxr FOnmb8CIdcOrv2pWVhQnmM8mDqonv4GD1KH4aqf5/jdOc3DVW07nNP3yJPO6RFr+yxWG Dzn5eM3ux3lF1PM39r6CFksRizgCQFk5tIuXPB6ssCdtf82zPjhp5iIH4gVU3Kk/Cq4A t4Zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ucw.cz header.s=gen1 header.b=QycL77za; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ucw.cz Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d2-20020aa7d682000000b0044615ee1b6fsi4852133edr.218.2022.12.07.12.29.25; Wed, 07 Dec 2022 12:29:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@ucw.cz header.s=gen1 header.b=QycL77za; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ucw.cz Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229811AbiLGUUN (ORCPT + 76 others); Wed, 7 Dec 2022 15:20:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiLGUUJ (ORCPT ); Wed, 7 Dec 2022 15:20:09 -0500 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F26B87B4CF; Wed, 7 Dec 2022 12:20:08 -0800 (PST) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id C5F6A1C09FA; Wed, 7 Dec 2022 21:20:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1670444407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Eh9NhAnoQecLCp7nuLOnthOFNLGPDmhbnX28mSicZBc=; b=QycL77zaG/WL3VgRHdJ0wqN9TQbgn2McpFJ5gCNR5Qvy0DIgf6E+MYTylfi1V4eg/9mIjk AEydDvDvdHhbB+fz2GoaBVuVgP6bltij+/l3lv9Omz+EJbOLspBuwEVhSpV6itahRS2I6x ZL02SAuIuqm19mu8W+HzPmBS9HA5ZDY= Date: Wed, 7 Dec 2022 21:20:07 +0100 From: Pavel Machek To: Wang Yufen Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 00/13] leds: Fix devm vs. non-devm ordering Message-ID: References: <1667983694-15040-1-git-send-email-wangyufen@huawei.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Dtx9TZ7I9qpyVSaS" Content-Disposition: inline In-Reply-To: <1667983694-15040-1-git-send-email-wangyufen@huawei.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Dtx9TZ7I9qpyVSaS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Fault-inject tests reports this issue: >=20 > DEBUG_LOCKS_WARN_ON(lock->magic !=3D lock) > WARNING: CPU: 2 PID: 52 at kernel/locking/mutex.c:582 __mutex_lock+0x1366= /0x15b0 > Call Trace: Ok, so: a) this does not happen in wild b) you have not actually tested any of this ? It looks reasonable, but the "Fixes:" tags mean -stable will pick this up almost immediately. Is anyone else willing to say this looks ok to him? Any testers? Best regards, Pavel --=20 People of Russia, stop Putin before his war on Ukraine escalates. --Dtx9TZ7I9qpyVSaS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCY5D1dwAKCRAw5/Bqldv6 8uu1AJ4gVur77IXI3520H+FU3r8u1VsyvACfSGnZBEhHWc7ZFUK6Gn6UMbXrYOg= =IH31 -----END PGP SIGNATURE----- --Dtx9TZ7I9qpyVSaS--