Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 13:39:58 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Alison Schofield <alison.schofield@intel.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     Ira Weiny <ira.weiny@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/6] cxl/mbox: Add GET_POISON_LIST mailbox command
Message-ID: <6391082ed3374_3cbe02947d@dwillia2-xfh.jf.intel.com.notmuch>
References: <cover.1668115235.git.alison.schofield@intel.com>
 <46c7c7339224744fce424b196da3e5566effec17.1668115235.git.alison.schofield@intel.com>
 <638ffd5eaa3a7_c95729426@dwillia2-mobl3.amr.corp.intel.com.notmuch>
 <Y5C7EYz1VrG2H7jh@aschofie-mobl2>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y5C7EYz1VrG2H7jh@aschofie-mobl2>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z3fCUCtf0qaOYkOPxK+LsI5/mXr3ll6AIoYkT+0+MUuvjrMtbob5N5hs1L6M?=
 =?us-ascii?Q?Z5RU+9uyNH6U37HkV5DivTRIbUZGglS3jzUbNcJtKlF/TH1jk5TqgOrFpiXb?=
 =?us-ascii?Q?0L0OUxtzNSOtHKu+ggI+HA6j33fjHNRAMiB7EXRWPnUzq/M5huv/muYnSRhe?=
 =?us-ascii?Q?EGX6O9KgZg4ynAtVdpj17zBXfThWSljnMi73gZ4NtrcVEOMppJ6CFERfeYrK?=
 =?us-ascii?Q?MLCtQU4uaOoEaFPy8Ov+d1taGIoQKbwAHpgTFEi/QZm3FMi2D8cDRU7vEEtK?=
 =?us-ascii?Q?dBfpGl2gk1sk3WFOAxtn1dIrfyTCKG7qYOXp0fJav99vBka3FkE2s65oiLXe?=
 =?us-ascii?Q?j4b694QmSs3xNcONea2himLlgzfOB2J13V/x+BLQ9x/BRmiNaSHyEmXsR+bA?=
 =?us-ascii?Q?7cXvg4hCcqQtUsYazGUKul136AQml/ZEFhFXHgOAPY6drbSQ7O1xFEWtonj4?=
 =?us-ascii?Q?oCdalhX8gMUvrKSvpU1SklReAuM0yzZjG5vLoNkFDkKKFRKlfzhCnNzh5tz6?=
 =?us-ascii?Q?aF94cn0+Gtws0P/6fRNBtn7aD0tH0rw1D41oLzQQQcdkBW+iOH4B6uwUH5xA?=
 =?us-ascii?Q?sL9zcHDLbVUMaxfMEqq3VQkJO4GjEaSLYzJj5WIqd5EFwjz/47wc/ZpOne6T?=
 =?us-ascii?Q?tXA166PJrNg/H4sfw09IHK6SgDzgrKMrt0EaA+/Dp0vUalcW9GYawQVYvh1B?=
 =?us-ascii?Q?KT16AXPZgaplkGpLVRJR4DMHyEhMA3kskIzaaMGLJ3vuq0jkW2Pz0wVm765c?=
 =?us-ascii?Q?6nibmI23IixSQ4xJOXuUJDmxL+BtuNrGgWmU5N3SDaOE4xd+EXew0EvvIHfR?=
 =?us-ascii?Q?97itNoW0IsxDWXYN1Bqj19ZI6c+NEEnQetKXpBs3pMORtDUHVsor/Xxx85KE?=
 =?us-ascii?Q?b52iVz5BDawUxfXmjBDgi9LSo299Z6odl5RWwLfVXxq0z/rbCvZtlEsfdI+D?=
 =?us-ascii?Q?9Noxd7Wdrj8taHa9yR4BRGNE0qi+gnF82HjpyqYlpMT3KCrRsh6u7nm00Avf?=
 =?us-ascii?Q?kftQ125RWOoB4yzgL4hjLIcWSIHEwisgNCysLFEOmaO8bHfPPl18ndJ/Fnbb?=
 =?us-ascii?Q?nvFnU0wNOO4JcJyHqcEVcybkOTmTcTPMt1Hq1+i4dWpVge10Di1Fclm1w6FZ?=
 =?us-ascii?Q?BFckDbl+usLfjhlPmo0BRUKwDFujafqMVKELeZqLpHUZQxPK0YpHeh972rT/?=
 =?us-ascii?Q?LrwSKLDopU127p9in80HLREry8dxZyl52K4v5qreMiYBcWAYQkdBNCF0jjub?=
 =?us-ascii?Q?uQSjL0bVR1XsUiywfOVZkpjSC1wzCXZaHvpWNrKng+BjSAr2QL5Yh/noP1Qn?=
 =?us-ascii?Q?p9uEYjtvVvHMHE09bydH2I0P6dnB6c6/u65MGfll7cu3h8YKIUryx/mmULXb?=
 =?us-ascii?Q?5U1I13h2NT34shkI0tQcBZGpMGevIARChBIf/hRRAzCp+8z/XkHvP+ahzVRs?=
 =?us-ascii?Q?SbDvsJumaEDfIEWXzDNxpGWy0eMIDu3wdN2WkzlmodUkAoSSACT3OsDkPItB?=
 =?us-ascii?Q?pmfucmGl5XzlgfbyyJCmOzyXBy48nY1z8dTpb8fslKzO+1ywdCfKxOGTx3HE?=
 =?us-ascii?Q?JIAFzgPiLfKjZXAMC+pWVT9uT5G1hzzZgNB3lhjfXWnaKqBfNLMo4mjOo1q2?=
 =?us-ascii?Q?7w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 693418ed-147a-4f63-9c1f-08dad89b9835
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 21:40:01.3714
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2PdsjjIc+OLlJXjoP3gfarEEfLT+anPiFbRNNyzLDU1tlrjKFnmrFdMvXd41vCbDJAGPsjcRWCCiX4mVk62AhPz/wyodQ4xXpYEtPA9dWcU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6499
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alison Schofield wrote:
> On Tue, Dec 06, 2022 at 06:41:34PM -0800, Dan Williams wrote:
> > alison.schofield@ wrote:
[..]
> > > +int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len,
> > > +		       struct cxl_region *cxlr)
> > > +{
> > > +	struct cxl_dev_state *cxlds = cxlmd->cxlds;
> > > +	const char *memdev_name = dev_name(&cxlmd->dev);
> > > +	const char *pcidev_name = dev_name(cxlds->dev);
> > > +	struct cxl_mbox_poison_payload_out *po;
> > > +	struct cxl_mbox_poison_payload_in pi;
> > > +	int nr_records = 0;
> > > +	int rc;
> > > +
> > > +	po = kvmalloc(cxlds->payload_size, GFP_KERNEL);
> > > +	if (!po)
> > > +		return -ENOMEM;
> > > +
> > > +	pi.offset = cpu_to_le64(offset);
> > > +	pi.length = cpu_to_le64(len);
> > > +
> > > +	rc = mutex_lock_interruptible(&cxlds->poison_list_mutex);
> > 
> > So I do not know what this mutex is protecting if there is an allocation
> > per cxl_mem_get_poison() invocation. Although I suspect that's somewhat
> > wasteful. Just allocate one buffer at the beginning of time and then use
> > the lock to protect that buffer.
> 
> Intent was a single lock on the device to protect the state of the
> poison list retrieval - do not allow > 1 reader. With > 1 reader
> software may not know if it retrieved the complete list.
> 
> I'm not understanding about protecting a buffer, instead of protecting
> the state. Here I try to protect the state.

Ah, sorry I read cxlds->poison_list_mutex and assumed it was serializing
access to the buffer, not a state machine. I do think it would be
worthwhile to make this a self contained structure with its own kdoc to
explain what is going on, something like:

diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
index ab138004f644..02697d1d951c 100644
--- a/drivers/cxl/cxlmem.h
+++ b/drivers/cxl/cxlmem.h
@@ -193,6 +193,19 @@ struct cxl_endpoint_dvsec_info {
        struct range dvsec_range[2];
 };
 
+/**
+ * struct cxl_poison_state - summary
+ * @payload: ...
+ * @lock: ...
+ *
+ * A bit more description of why state needs to be held over successive
+ * mbox commands...
+ */
+struct cxl_poison_state {
+       void *payload;
+       struct mutex lock;
+};
+
 /**
  * struct cxl_dev_state - The driver device state
  *
@@ -210,6 +223,7 @@ struct cxl_endpoint_dvsec_info {
  * @lsa_size: Size of Label Storage Area
  *                (CXL 2.0 8.2.9.5.1.1 Identify Memory Device)
  * @mbox_mutex: Mutex to synchronize mailbox access.
+ * @poison: Poison list retrieval and tracing
  * @firmware_version: Firmware version for the memory device.
  * @enabled_cmds: Hardware commands found enabled in CEL.
  * @exclusive_cmds: Commands that are kernel-internal only
@@ -244,6 +258,7 @@ struct cxl_dev_state {
        size_t payload_size;
        size_t lsa_size;
        struct mutex mbox_mutex; /* Protects device mailbox and firmware */
+       struct cxl_poison_state poison;
        char firmware_version[0x10];
        DECLARE_BITMAP(enabled_cmds, CXL_MEM_COMMAND_ID_MAX);
        DECLARE_BITMAP(exclusive_cmds, CXL_MEM_COMMAND_ID_MAX);