Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp47359rwb; Wed, 7 Dec 2022 14:14:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf7E6YPUr/pw8tZ7WgYvWfNJ3zUYGsAdQAlwh/ppfqlGSMlHrwFvGXQvauZRMjLQrQ6gPyyY X-Received: by 2002:a63:5857:0:b0:46f:9763:a37b with SMTP id i23-20020a635857000000b0046f9763a37bmr69895783pgm.177.1670451272723; Wed, 07 Dec 2022 14:14:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670451272; cv=none; d=google.com; s=arc-20160816; b=uoC7aZUwfMIvGcR2m7uFjmrAT8SA0iWw/gYE6mX++hTGlqWgrs1q54qALoA85A/K9u g3EEKX4wbmARJdkgP+KC1+8de2lL9Cm9m1/5xWoZ3hAoHNR4pj8yKjcQBCk+Nq+bIu2L q7XPpbp+S5kJYxpuNi7Yn9WPeJCFVV1O3r19dlkD8G/uhcziASzZh1l89JLQLGA4odnp WkFuGMgVSgoqO+7NHBWXGBoc6w5j7xSeub3qHSAfdLc2fKGjF+mahnYnn3rVN5KZnlQx 1Ycmba3XtV+zcosYd2PRXmc0d/QiwwN5Jmwo2NUGD6H0BGRQHEWLHa0St/d0OrTLm6nr oBqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=5dCNbmox6waUeuX2Iir4OK5SdTorc7GU4B8l9qRHQWQ=; b=CAgcuOlt9BgjIrDKoOImpcJ1VzztUhaaFUhXD46nE00ENf87LoJY38WUrPv9BFdaxX dUYbquLH1z6hhJzbVtdiXM7cEUu6xpgjdq0d8ERhdHpWHFe3IG595/K8BKpb9a+qdWzb nfzrj3j7N03mN8TSVScx8W9ES9anGp049ilNDigkPcUUUNj0jjLHGii18qQW8Y6v8XbX ZuuKBCnk5wJru7Ji5XlPkR1/LwPZI5NVJQeeExz11ngYPHIOsu5rIB74AmP5S1hVRBP7 AvmrlOUiXNvWbfDQi0DaRgtNE8cY79ySRvzVOooZlxAeVunynBuA9BzdYXkldrMmLNiE ufow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vIYh4Har; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s25-20020a632159000000b004785a1141cbsi21809673pgm.485.2022.12.07.14.13.55; Wed, 07 Dec 2022 14:14:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=vIYh4Har; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230095AbiLGVth (ORCPT + 75 others); Wed, 7 Dec 2022 16:49:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229875AbiLGVtR (ORCPT ); Wed, 7 Dec 2022 16:49:17 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF0BE84DE4; Wed, 7 Dec 2022 13:48:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0CE5B8216E; Wed, 7 Dec 2022 21:48:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74030C433D7; Wed, 7 Dec 2022 21:48:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670449734; bh=5dCNbmox6waUeuX2Iir4OK5SdTorc7GU4B8l9qRHQWQ=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=vIYh4Har7Mb8hxyOkjyXUxLcj2ioKv8LNilKJqHb2rNIcREFqI9CBb5Ya5smNOJ0S Bn7Y/u6vdr+V5UAGtGXPRS73IBztInR4k7P+hdWcejUTpZPNk2/qyxOklRkxKpS18Y gIR9qEYDgN8JtNkPOc2N+yRdxBAqNmW8LNNkRuU7vqGopEwRuTN0HUYN/qlq7QuWAI 2hwc7Nzg2f7CbnvSF0AGs8BS6xOsg4lrAjafBp7c2SAcdjMFEpC29lN+hzlSv2FwEN 48yYrCbRgAknQg7VqPpEq7mfcMSC2DK/FZ+Dxjcq12G8ek1AzuizNfEepN91Kjb4vx Kv2apagmDsBYA== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221018-clk-rate-request-tracing-v2-2-5170b363c413@cerno.tech> References: <20221018-clk-rate-request-tracing-v2-0-5170b363c413@cerno.tech> <20221018-clk-rate-request-tracing-v2-2-5170b363c413@cerno.tech> Subject: Re: [PATCH v2 2/2] clk: Add trace events for rate requests From: Stephen Boyd Cc: Maxime Ripard , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org To: Masami Hiramatsu , Michael Turquette , Steven Rostedt , maxime@cerno.tech Date: Wed, 07 Dec 2022 13:48:52 -0800 User-Agent: alot/0.10 Message-Id: <20221207214854.74030C433D7@smtp.kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting maxime@cerno.tech (2022-10-26 06:46:59) > It is currently fairly difficult to follow what clk_rate_request are > issued, and how they have been modified once done. >=20 > Indeed, there's multiple paths that can be taken, some functions are > recursive and will just forward the request to its parent, etc. >=20 > Adding a lot of debug prints is just not very convenient, so let's add > trace events for the clock requests, one before they are submitted and > one after they are returned. >=20 > That way we can simply toggle the tracing on without modifying the > kernel code and without affecting performances or the kernel logs too > much. >=20 > Reviewed-by: Steven Rostedt (Google) > Signed-off-by: Maxime Ripard > --- Applied to clk-next