Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 16:05:19 -0800
From:   Ashok Raj <ashok.raj@intel.com>
To:     Borislav Petkov <bp@alien8.de>
CC:     X86-kernel <x86@kernel.org>,
        LKML Mailing List <linux-kernel@vger.kernel.org>,
        Dave Hansen <dave.hansen@intel.com>,
        "Tony Luck" <tony.luck@intel.com>, <alison.schofield@intel.com>,
        <reinette.chatre@intel.com>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [Patch V1 4/7] x86/microcode/core: Take a snapshot before and
 after applying microcode
Message-ID: <Y5EqP4OtmK04g6bQ@a4bf019067fa.jf.intel.com>
References: <20221129210832.107850-1-ashok.raj@intel.com>
 <20221129210832.107850-5-ashok.raj@intel.com>
 <Y5D20qLOmrj4d2w4@zn.tnic>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y5D20qLOmrj4d2w4@zn.tnic>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pvuIqgW12INIZi1Imq0tBj74yB5BV25TeT5GIH1b4MrA7bAQ/LFVsvEZo+KT?=
 =?us-ascii?Q?oVCJiDzzB+EQvFD9xABwbNWKOp8xUPNK/jdS53syEqnTtAXCMa5NsJjjH1Eo?=
 =?us-ascii?Q?J/ma4Ci9G2ZBC/y0Tsx0rgIouKvO1DWIn6e16o+NT9rhi6ImpDwoJjgfbaX6?=
 =?us-ascii?Q?8wjopHuut7aexdPuYHTbIRIISh3nxDbcRPwcwMnZTMoXsDBWkGkM2jFX1esK?=
 =?us-ascii?Q?5j7RX0eTR+9YYp83Egg0QtdoekvOJpKVwhq7CLB7yZD2k/ptIWKS+nHlR5U7?=
 =?us-ascii?Q?mKj0uDZPDIFGR8sR2BxoitK9WUpvtv775ZY7ZVsxJPWpyNJrZvz246fG0ARS?=
 =?us-ascii?Q?ed2TG28JmPWf1jXpwLT1KF2DP7947+TG3Bf6C597WTvSrZagMP/1dbtVHum8?=
 =?us-ascii?Q?Kk7WaWnXhSU5fd7vg+buDVE1A4Kcs4lGxPyYWQsCguutj/LCeK4CW36S4mp2?=
 =?us-ascii?Q?9bl8F2sim2eHuHx1XVYrwzQ1wuy680HSCCoVPsUhxCemfmCFzf4EhWGGlABh?=
 =?us-ascii?Q?58N5gywXPx+hcRjAMWHWjE17ffwqXiH4yk9Ws8I1XufEQ0SJN8Quzpn5X7Gy?=
 =?us-ascii?Q?C3MIFuVxX+UAyoa3mK/sdp9tWzRB9hIoePF2VNECG48XoPs9YQzxGFXlyrAt?=
 =?us-ascii?Q?Yimxc3O/S+Sq3kYry8EfuJH66jgLroOWSzBQUvNIsO+VzmdY9ZCwYGo+wqu8?=
 =?us-ascii?Q?kNLQlSVVegAQD3nbOT9BPufnXlmdrvxRJ5beVTYopgOVmNZHIaDXsMltxNPd?=
 =?us-ascii?Q?IwbXaoSMD51OCQNtxxAfMUWnX0/6IF4xadyuUvqQ0UdLqvOlVPcITWlEylrz?=
 =?us-ascii?Q?fjflFvrKH/GxPZN92imipm4KoSVioujyursztOIb2qwspo6p6uuHn5m33Eo5?=
 =?us-ascii?Q?hPjlwh3muPf9dNVlV2PADVakL9v1vgYa02vCppsrAQJFgCk4NcXS2aKwNcet?=
 =?us-ascii?Q?lp/RidTqG0QZmGiUMxlvT0U0qRRcqcG9MT50UhhVHnp0WhLL/y8wYQPIF8hT?=
 =?us-ascii?Q?g8X3H0PABlzUGQUp12q9PkE8tmAmEaroVbfyWfECpsni2NHRPXPpHW9AiH0T?=
 =?us-ascii?Q?zE1nlUJLRHjBpnoNuiLO5d8YGPIuYYoTjUIu4iAiBk88OGCYz1PS2W6iyo4P?=
 =?us-ascii?Q?JLXXCGClswdBH3A1ms5lDgv9Jxb46xYLa3D8VSKc/WkBhysrV3UR6dtF06+0?=
 =?us-ascii?Q?0sdfCu04/2Zs0hzYH1M/lqOdTjdnMrQGNt+mtIjLTliXhzlcV86UJ7bhtDcu?=
 =?us-ascii?Q?6xfG9WicPlObluPDsRi4F7uMembj5KWKGSTNDkCsy9Odo0lVqMw2alwwzebN?=
 =?us-ascii?Q?yDlCPW44H3SAoIupSO9dcSOK9zJBVzN696SKgfeWjjwsvpRqTxIWgDCyFUuy?=
 =?us-ascii?Q?siny8Pjv+BvGS/Oq2O2cSIuEi8LA8wee642Fj3M/QHXESMKz/+X5Mwu2xM/+?=
 =?us-ascii?Q?8E0P7/qffL6tN5z3Xd0FE9j50DtjP9fOOJsR16HyxVb5fR55ustmvyFDKny6?=
 =?us-ascii?Q?/mbbD5UzsvZvLWZHpMunIdfOM8guKNGckjjPWel3N1d4Twh5fh9UBvYX5Zub?=
 =?us-ascii?Q?X5WFrLDWdx4IcwnfrKU9NWT9JyP/bjUt62uhJWuo?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f41d1b2-d249-4e6c-91cb-08dad8afe6aa
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6201.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 00:05:24.3274
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kwYRhk8tcwt6+PIYuxDdOfYz29uvopXy02GxBN9Cx7xv/iuKvRa47xD9jBb8yhdgdetfrmEa+z6b7K1ziufB4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4737
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 07, 2022 at 09:25:54PM +0100, Borislav Petkov wrote:
> On Tue, Nov 29, 2022 at 01:08:29PM -0800, Ashok Raj wrote:
> > The kernel caches features about each CPU's features at boot in an
> > x86_capability[] structure. The microcode update takes one snapshot and
> > compares it with the saved copy at boot.
> > 
> > However, the capabilities in the boot copy can be turned off as a result of
> > certain command line parameters or configuration restrictions. This can
> > cause a mismatch when comparing the values before and after the microcode
> > update.
> 
> Hmm, but if that has happened, the capabilities will be turned off in
> your @orig argument below?
> 
> Or are you saying that this copy_cpu_caps() read before the update will
> overwrite the cleared bits with the their actual values from CPUID so
> that what you really wanna compare here is *hardware* CPUID bits before
> and after and not our potentially modified copy?
> 
> I.e., some bit in CPUID is 1 and we have cleared it in our copy.
> 
> Close?

Correct.

> 
> If so, then this should be specifically called out in the commit
> message.

Sounds good, I can certainly add it when I repost.

> 
> > +static void copy_cpu_caps(struct cpuinfo_x86 *info)
> 
> If anything, that function should be called
> 
> store_cpu_caps()
> 
The names sounds more fitting, I can change it as suggested.

Cheers,
Ashok