Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 00:42:55 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Kris Bahnsen <kris@embeddedts.com>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        mark@embeddedts.com
Subject: Re: [PATCH] spi: spi-gpio: Don't set MOSI as an input if not 3WIRE
 mode
Message-ID: <Y5EzD8AaAj0EGnvH@sirena.org.uk>
References: <20221207230853.6174-1-kris@embeddedTS.com>
 <Y5ElXqDduIZhIiAm@sirena.org.uk>
 <1670459801.7091.1.camel@embeddedTS.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4hWHV25Qz4zHeXzX"
Content-Disposition: inline
In-Reply-To: <1670459801.7091.1.camel@embeddedTS.com>
Precedence: bulk


--4hWHV25Qz4zHeXzX
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Dec 07, 2022 at 04:36:41PM -0800, Kris Bahnsen wrote:
> On Wed, 2022-12-07 at 23:44 +0000, Mark Brown wrote:

> > A cleaner fix which is probably marginally more performant would be to
> > make the setting of spi_gpio_set_direction() conditional on SPI_3WIRE -
> > then we won't call into the function at all when not doing 3 wire,
> > avoiding the issue entirely.

> That makes sense to me. I was operating under the assumption that 3WIRE
> mode could be switched in to at a later time via ioctl(), but with the
> death of spidev that is presumably no longer a concern.

Ugh, right, spidev.  Really even with spidev devices should probably
have the mode configured beforehand (I'm not sure pinmux will do the
right thing on most platforms...) but now I check it's part of the ABI
so we can't get rid of it and therefore your current patch probably is
what we need.  No need to reroll, sorry for the noise :/

I'm not sure why you think spidev is dying, it does still exist and
devices use it?

--4hWHV25Qz4zHeXzX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmORMw4ACgkQJNaLcl1U
h9AFoQf/dWk/njflOwqMtkBP7+OFX53BxWtrCGZMwjWfdgV1bHOnN0GVy4rPMlN5
9HggfP9qUQ8zNX/ZdDHlORNe9YMrnyY8TTjrqdwWkcQhC6IGSlR3aFL3CfLpSB1Y
0kyLwu9mMgoL07xzq6wjooyG/eLtISaBMTYwJqgeS9eCk/YzTpTY9K89DmryKVv0
yRkH/hektDnCCh3I3WJSf/OoVQfoqjEcfdP4uVF/c+uV+6yUcPLWjoO6exo/b4Vi
irjQPWbMaLTHi6Lt0n+Fa/n7I8nP2WCnsMod8jglT1faVCkNtWHoXG5970juewi8
iponvZArStFjqDE68vy+rzmZgvMPbw==
=hWr/
-----END PGP SIGNATURE-----

--4hWHV25Qz4zHeXzX--