Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp316488rwb; Wed, 7 Dec 2022 18:41:16 -0800 (PST) X-Google-Smtp-Source: AA0mqf4v+zuaQzj+KCh3R4Sb96CUcYnJMd8u3wAwt5kHta83whXDbI5PDKoPdYQ38wu+MXp6BGWL X-Received: by 2002:a05:6402:1386:b0:458:d7b5:9793 with SMTP id b6-20020a056402138600b00458d7b59793mr20406242edv.377.1670467276307; Wed, 07 Dec 2022 18:41:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670467276; cv=none; d=google.com; s=arc-20160816; b=rOZzDtnVIRwmqlQGuX/6A7YEWQ4HMqcXNb4yKC15A7f7G+y+HMlqn1Vxylj0TF5tMM cocDh80FKuOFoolqTK7jpvO3fOvsfW908RhcLaJv6i1K9tRaGfBNfcnBpiVMBQqBMS6u BKhQTETb94CcaZymA5raN/HbB+zrN6sIrDdslQZ9++Wua1J0+TeHxurAGf3TyO84p26k aTsA1DvtZknN/473EmYJsvIQ5V373qHCAA+T+rlf986PlRrcCki/wO2d/TlXk7lCGQzf FF+yVDBW0Bd7pJnP+H3tnWBPjRIpil1PsGTa45tkxqXqczt/3AnFoM/f4EV2ftBB9szZ dJuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=tYKB/4hRQmNJp7Bpc82wlwoNLccUXdf+TKbOHeIeGhM=; b=bjwMTtcbPQVp08y9TRZsharKulW1KXFCTCs+4wkavcPP0K3MSQDyc99Le0ozpsvmDN z7GQsf1CXjWXZ3ZblutZ0bn1+krh9hqjHHw66kcxVkQ/rFM2EG0Vm83zW+WutmkeReWy faOC37VUHY5YKa3K3htAs1e4XPaUBXeAKSI5Ts8laJh9cKFfMyag+kUiGXIO5YG7ZnDN ZoK7VDpHEKx/8egWjLvlyPh+KNX2xT2orjrcexKnHcSD7qC8LEHf8oTwqGACeoVjVRMY GLl1/idI+oRm9tLM+llm/J0M4RAC84Re51UlAAeFVXqlqYF7VqLV0uErCCcUxpV/CXDO iTVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MoryZRTF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t13-20020a170906178d00b007a953d421bbsi12546690eje.322.2022.12.07.18.40.59; Wed, 07 Dec 2022 18:41:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MoryZRTF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbiLHC1Y (ORCPT + 74 others); Wed, 7 Dec 2022 21:27:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbiLHC1W (ORCPT ); Wed, 7 Dec 2022 21:27:22 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F60F8E599; Wed, 7 Dec 2022 18:27:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EDA6161D45; Thu, 8 Dec 2022 02:27:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DC01C433D6; Thu, 8 Dec 2022 02:27:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670466441; bh=tYKB/4hRQmNJp7Bpc82wlwoNLccUXdf+TKbOHeIeGhM=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=MoryZRTF36q730ReOxY9dgBQWO5BcUUu/Z2tTyd2EsrMylGZ37eBLUREF6XYBsIOr Dl8hv6k/pCrTFxVKPlV+ik+q7tqHd9n9s03jxlmcsKl6zyMA5kdGuByBr1lzCLSPCD pQH7ls1j/dkZO5ZaoUWVML960Bpe1d0jOOwuW+GDuf5vfphij6AiqSHSvYw81fGb1U QpxuEECI8W1nTEhoWz68FugFTRdRmRIvf9K3q9MRVehRYzY4R8kOEfDCuN+jTgJ/p2 HyNEXghl6U05yoE6iNKBG4VU2aazkD0LJKVWkPUREq3Fdgq4WxVATOo/AoO5lHdBRT pk+69KCs+7F3g== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221122133614.184910-1-xiujianfeng@huawei.com> References: <20221122133614.184910-1-xiujianfeng@huawei.com> Subject: Re: [PATCH] clk: st: Fix memory leak in st_of_quadfs_setup() From: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org To: Xiu Jianfeng , avolmat@me.com, mturquette@baylibre.com, patrice.chotard@foss.st.com, windhl@126.com Date: Wed, 07 Dec 2022 18:27:19 -0800 User-Agent: alot/0.10 Message-Id: <20221208022721.4DC01C433D6@smtp.kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Xiu Jianfeng (2022-11-22 05:36:14) > If st_clk_register_quadfs_pll() fails, @lock should be freed before goto > @err_exit, otherwise will cause meory leak issue, fix it. >=20 > Signed-off-by: Xiu Jianfeng > --- Applied to clk-next