Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 7 Dec 2022 18:32:36 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Russ Weight <russell.h.weight@intel.com>,
        Shuah Khan <shuah@kernel.org>
Cc:     "Zhou, Jie2X" <jie2x.zhou@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "Zhang, Tianfei" <tianfei.zhang@intel.com>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Li, Philip" <philip.li@intel.com>,
        Adam Manzanares <a.manzanares@samsung.com>
Subject: Re: fw_fallback.sh test failed in Debian 11
Message-ID: <Y5FMxAJ1SGEezLgl@bombadil.infradead.org>
References: <CY4PR11MB1320DAA7D7972E738EDA754EC5129@CY4PR11MB1320.namprd11.prod.outlook.com>
 <Y4W+/TfM4F9TdSnZ@kroah.com>
 <CY4PR11MB132092589F9270FB559B01D8C5159@CY4PR11MB1320.namprd11.prod.outlook.com>
 <0e688462-7f22-118e-6cb1-de8b582e3973@intel.com>
 <CY4PR11MB13205F799D0A30BB011E4334C5149@CY4PR11MB1320.namprd11.prod.outlook.com>
 <217b7959-facc-1028-19be-1040898a705c@intel.com>
 <CY4PR11MB13206A6918FFDEB5B3D3794BC5149@CY4PR11MB1320.namprd11.prod.outlook.com>
 <57b8f45b-da8c-e9ae-6b3f-ba82f936c9b2@intel.com>
 <CY4PR11MB132068A19AF9704D1B14814FC5179@CY4PR11MB1320.namprd11.prod.outlook.com>
 <4e5bbaf8-58ea-5ebe-a585-496ee7b51bce@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4e5bbaf8-58ea-5ebe-a585-496ee7b51bce@intel.com>
Sender: Luis Chamberlain <mcgrof@infradead.org>
Precedence: bulk

On Fri, Dec 02, 2022 at 08:29:15AM -0800, Russ Weight wrote:
> 
> On 12/1/22 22:02, Zhou, Jie2X wrote:
> >> The above message looks like the problem. Firmware sysfs fallback has been turned off
> >> on this system using sysctl. Can you try turning it on and rerunning the test?
> > Sorry, I don't know how to turn on firmware sysfs fallback.
> > Could you tell me?
> 
> Take a look at the kernel documentation (https://www.kernel.org/doc/html/v5.0/driver-api/firmware/fallback-mechanisms.html) which says, "This syfs fallback mechanism may be disabled completely on a system by setting the proc sysctl value ignore_sysfs_fallback to true."
> 
> Also refer to the sysctl man page: https://manpages.debian.org/testing/procps/sysctl.8.en.html.

I often see folks mis-running selftests, even thougggh in theory it
should be easy. And so I've added initial kernel selftests support to kdevops:

https://github.com/linux-kdevops/kdevops

So try to enable the selftests dedicated workflow, enable the firmware
test, enable building a linux-next kernel and go to town:

make menuconfig
make
make linux              # installs linux-next
make selftests          # builds selftests
make selftests-firwmare # runs the selftests for firmware

I think we have to up our timeout now for the firmware loader as its
currently failing as the tests now take a bit too long. Anyone oppose we
bump the firmware selftests to 200s ?

  Luis