Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Visweswara Tanuku (QUIC)" <quic_vtanuku@quicinc.com>
To:     "Visweswara Tanuku (QUIC)" <quic_vtanuku@quicinc.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     "Vijaya Krishna Nivarthi (Temp) (QUIC)" <quic_vnivarth@quicinc.com>,
        "Visweswara Tanuku (QUIC)" <quic_vtanuku@quicinc.com>,
        "Mukesh Savaliya (QUIC)" <quic_msavaliy@quicinc.com>
Subject: RE: [PATCH] soc: qcom-geni-se: Update Tx and Rx fifo depth based on
 QUP HW version
Thread-Topic: [PATCH] soc: qcom-geni-se: Update Tx and Rx fifo depth based on
 QUP HW version
Thread-Index: AQHY/aYb84iM+7JnME65ZOEDXxLWrq5kB9iA
Date:   Thu, 8 Dec 2022 04:35:39 +0000
Message-ID: <31c4f532ec6646f7977ebf930b8a2812@quicinc.com>
References: <20221121123758.5052-1-quic_vtanuku@quicinc.com>
In-Reply-To: <20221121123758.5052-1-quic_vtanuku@quicinc.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Gentle Reminder!

-----Original Message-----
From: Visweswara Tanuku <quic_vtanuku@quicinc.com>=20
Sent: Monday, November 21, 2022 6:08 PM
To: linux-kernel@vger.kernel.org
Cc: Vijaya Krishna Nivarthi (Temp) (QUIC) <quic_vnivarth@quicinc.com>; Visw=
eswara Tanuku (QUIC) <quic_vtanuku@quicinc.com>
Subject: [PATCH] soc: qcom-geni-se: Update Tx and Rx fifo depth based on QU=
P HW version

From QUP HW Version 3.10 and above the Tx and Rx fifo depth bits are increa=
sed to 23:16 bits from
21:16 bits in SE_HW_PARAM registers accomodating 256bytes of fifo depth.

Updated geni_se_get_tx_fifo_depth and
geni_se_get_rx_fifo_depth to retrieve right fifo depth based on QUP HW vers=
ion.

Signed-off-by: Visweswara Tanuku <quic_vtanuku@quicinc.com>
---
 include/linux/qcom-geni-se.h | 42 ++++++++++++++++++++++++++++++------
 1 file changed, 36 insertions(+), 6 deletions(-)

diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h in=
dex f5672785c0c4..5ea5351f8818 100644
--- a/include/linux/qcom-geni-se.h
+++ b/include/linux/qcom-geni-se.h
@@ -242,12 +242,22 @@ struct geni_se {
 /* SE_HW_PARAM_0 fields */
 #define TX_FIFO_WIDTH_MSK		GENMASK(29, 24)
 #define TX_FIFO_WIDTH_SHFT		24
+/*
+ * For QUP HW Version >=3D 3.10 Tx fifo depth support is increased
+ * to 256bytes and corresponding bits are 16 to 23  */
+#define TX_FIFO_DEPTH_MSK_256_BYTES	GENMASK(23, 16)
 #define TX_FIFO_DEPTH_MSK		GENMASK(21, 16)
 #define TX_FIFO_DEPTH_SHFT		16
=20
 /* SE_HW_PARAM_1 fields */
 #define RX_FIFO_WIDTH_MSK		GENMASK(29, 24)
 #define RX_FIFO_WIDTH_SHFT		24
+/*
+ * For QUP HW Version >=3D 3.10 Rx fifo depth support is increased
+ * to 256bytes and corresponding bits are 16 to 23  */
+#define RX_FIFO_DEPTH_MSK_256_BYTES	GENMASK(23, 16)
 #define RX_FIFO_DEPTH_MSK		GENMASK(21, 16)
 #define RX_FIFO_DEPTH_SHFT		16
=20
@@ -388,7 +398,8 @@ static inline void geni_se_abort_s_cmd(struct geni_se *=
se)
=20
 /**
  * geni_se_get_tx_fifo_depth() - Get the TX fifo depth of the serial engin=
e
- * @se:	Pointer to the concerned serial engine.
+ * based on QUP HW version
+ * @se: Pointer to the concerned serial engine.
  *
  * This function is used to get the depth i.e. number of elements in the
  * TX fifo of the serial engine.
@@ -397,11 +408,20 @@ static inline void geni_se_abort_s_cmd(struct geni_se=
 *se)
  */
 static inline u32 geni_se_get_tx_fifo_depth(struct geni_se *se)  {
-	u32 val;
+	u32 val, hw_version, hw_major, hw_minor, tx_fifo_depth_mask;
+
+	hw_version =3D geni_se_get_qup_hw_version(se);
+	hw_major =3D GENI_SE_VERSION_MAJOR(hw_version);
+	hw_minor =3D GENI_SE_VERSION_MINOR(hw_version);
+
+	if ((hw_major =3D=3D 3 && hw_minor >=3D 10) || hw_major > 3)
+		tx_fifo_depth_mask =3D TX_FIFO_DEPTH_MSK_256_BYTES;
+	else
+		tx_fifo_depth_mask =3D TX_FIFO_DEPTH_MSK;
=20
 	val =3D readl_relaxed(se->base + SE_HW_PARAM_0);
=20
-	return (val & TX_FIFO_DEPTH_MSK) >> TX_FIFO_DEPTH_SHFT;
+	return (val & tx_fifo_depth_mask) >> TX_FIFO_DEPTH_SHFT;
 }
=20
 /**
@@ -424,7 +444,8 @@ static inline u32 geni_se_get_tx_fifo_width(struct geni=
_se *se)
=20
 /**
  * geni_se_get_rx_fifo_depth() - Get the RX fifo depth of the serial engin=
e
- * @se:	Pointer to the concerned serial engine.
+ * based on QUP HW version
+ * @se: Pointer to the concerned serial engine.
  *
  * This function is used to get the depth i.e. number of elements in the
  * RX fifo of the serial engine.
@@ -433,11 +454,20 @@ static inline u32 geni_se_get_tx_fifo_width(struct ge=
ni_se *se)
  */
 static inline u32 geni_se_get_rx_fifo_depth(struct geni_se *se)  {
-	u32 val;
+	u32 val, hw_version, hw_major, hw_minor, rx_fifo_depth_mask;
+
+	hw_version =3D geni_se_get_qup_hw_version(se);
+	hw_major =3D GENI_SE_VERSION_MAJOR(hw_version);
+	hw_minor =3D GENI_SE_VERSION_MINOR(hw_version);
+
+	if ((hw_major =3D=3D 3 && hw_minor >=3D 10) || hw_major > 3)
+		rx_fifo_depth_mask =3D RX_FIFO_DEPTH_MSK_256_BYTES;
+	else
+		rx_fifo_depth_mask =3D RX_FIFO_DEPTH_MSK;
=20
 	val =3D readl_relaxed(se->base + SE_HW_PARAM_1);
=20
-	return (val & RX_FIFO_DEPTH_MSK) >> RX_FIFO_DEPTH_SHFT;
+	return (val & rx_fifo_depth_mask) >> RX_FIFO_DEPTH_SHFT;
 }
=20
 void geni_se_init(struct geni_se *se, u32 rx_wm, u32 rx_rfr);
--
2.17.1