Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <050e7458-c952-1b1f-a98e-6c12c5b30cdb@oracle.com>
Date:   Wed, 7 Dec 2022 21:55:30 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH v7] scsi:iscsi: Fix multiple iscsi session unbind event
 sent to userspace
Content-Language: en-US
To:     Wenchao Hao <haowenchao@huawei.com>, Lee Duncan <lduncan@suse.com>,
        Chris Leech <cleech@redhat.com>,
        "James E . J . Bottomley" <jejb@linux.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, liuzhiqiang26@huawei.com,
        linfeilong@huawei.com
References: <20221126010752.231917-1-haowenchao@huawei.com>
From:   Mike Christie <michael.christie@oracle.com>
In-Reply-To: <20221126010752.231917-1-haowenchao@huawei.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R21hVUtiUmJaRFJYdFJENlM5R2R5QUJVN21EVElNeFNWWjkwdnF6RzBSOHpH?=
 =?utf-8?B?UzN6b1czdjRzemVEaTN1OHRlWHJMZzIxZUJQV1FNZ3J2STRrOGxESDZ5MXNN?=
 =?utf-8?B?RElNYTYyeTFxa3MwNThiS2h4OWo5dWlXMUFWMm14eFBUc3BKMzljWnBGZ2hH?=
 =?utf-8?B?V1RXUEVKZ3NXUmRobXlNb253TURWdVlLT1NORG9RQWRraEJ2bmQzUG5nVm5v?=
 =?utf-8?B?V1hXUnIxY09CSDJIaHk4VEVrdHI4alJuSklWN3prQnFROWkxZEd6M0YrZzFF?=
 =?utf-8?B?RktQYXdPTDFnR2tHd2tyaUUvWnprMXdKWUlwYnplOVg5by9PaktLSEZHdis0?=
 =?utf-8?B?WUtPYWd4MVI3Y1pMd1I3RWI1WnRlMWhoUUdBOVNBc2RuZUllNHZiVWdYYUh1?=
 =?utf-8?B?ZXpsTkNibmxyUXpPRWJ3a1QvdGtvaHdQR041YW42OVczUlJRMTR4ajQxVytR?=
 =?utf-8?B?aXN6dUQzNG1FQm9DYjFWeHplS2VKbFlnTlRiT1hqVlNlWVNQOEMzaUFHQ2dE?=
 =?utf-8?B?S3VRdnFmbWl6Mmh1Yi9DVjRQUUR0S3JZMEtUNGE2aDRhVGtPUWUyUnE5NEtS?=
 =?utf-8?B?SFFSbm11dW5RNUtZOXU4RUEwT1JqY0NKaGFaR1kyMHhCWUZGOGRJOFFpS2J2?=
 =?utf-8?B?TkYvWVpzeTRYVXJZSVVMbG5ReHFPWUVjRzFySFpYMUpGaXNETm5UeVdEdVlX?=
 =?utf-8?B?YjY1RUpabHFnMlJiQnRXLzRFMTBpRzBGNk1iOGI3RkdLODZHbHRJYlRxS0VG?=
 =?utf-8?B?SmNWU3dlSE81d0tVUVp5RTNOVGc4RFBBOG5NdHZIOVVjZGtjc24xV1d1TFRT?=
 =?utf-8?B?R1ZUdUxxb3dUemZYY1MzNjg4VEtEbzZ5eDFjTkNoYWZ2dXV0bndJcDlXc1I2?=
 =?utf-8?B?RkVQYXhwTjNkb1VBNE1CcFFLZlBxY09MdHZ1anp3NTBpVkNrdm5jZk02bXE0?=
 =?utf-8?B?MEhKcllrd3BiczdDU0tNT0dLSjFEdXNhRy9EN3BrQzJUakVZb2RxSHl3N21n?=
 =?utf-8?B?SHdiM01PQnltYVkxY1VCelZ0N2Irc3B6VEk3UXVTa1FtOCtySkZ5aUF3NUlY?=
 =?utf-8?B?R094bnp3LzduRzVlbTlWRUpSK0VrUzF5RytsaGJZWStibTMxZkVtVjQxTStG?=
 =?utf-8?B?S1dCV2xDM24zeVRqK2ExNE00Y2dSYTVRYkU4Z25IbWtaQWRodHRkRFkvWTJV?=
 =?utf-8?B?VktFTnpGMDBSVTB0elNWazNuelgzYTZuWWdZSDByMURCTzY3d3lDTFhIczFQ?=
 =?utf-8?B?UDFIaEljZ1dyVGVETTFoV0MwWVNCc09uY05kTFlvUTB3YnJidXJpMVRmZjc4?=
 =?utf-8?B?MzE1S2FrRDEzWDE3Z0NHRWN4YktzdnhFTXlHazVyaEJid09JSDI1aGhhRkRQ?=
 =?utf-8?B?WU0vVGhOY1dsK1JlN3k5MEo5ZUprdzhSQ3dIV1JhVENkcmQyd0puMU54UWxk?=
 =?utf-8?B?c09yUk1GRkN2QndZTEhhUXo3OGhENVFMVytidnlmK1UrZXJwZS9iUG5yNlM3?=
 =?utf-8?B?NTNHNWVhY0RIMkNNOStiRnFxWDEwbzNtTkErY2FBMnpKSlRnRm90WG5nVHQ4?=
 =?utf-8?B?Mm14MnFLZDUxT3AxdlpsUmVuajYwVGRnK0c5T3lNRTFDT05iUnpFSkJEVEU4?=
 =?utf-8?B?ak14b1R5TXpRQ2dDNTg1eXFibFRxT290NzlCbkplUzJYbDh2cTVvMmlWbGY0?=
 =?utf-8?B?dVVIS1lYMmJITTFvcUZTeVFuWU1Vb3hDMVRBaVAzaThMVTRxb3F3YTdKNWU2?=
 =?utf-8?B?NmV2cGprSmNnK0VXTFNBSHNrWnBrTS9CQW10OGJUdVlwK1BpbTFja1M4UzlG?=
 =?utf-8?B?bHNCbnVsVEZMWmNDeEJRb29wRTRxWEFEaEVyc2ZXbzRpVktHWWJLalU3MklF?=
 =?utf-8?B?OXRQZ2J2cUJXT2tvSUFURXUrVDZITTFWTWdoTW5JNnJmc3J5K1JEM29aOU15?=
 =?utf-8?B?eG9KcEMyT2I5aS96Z040R1pRVEJUMGliOVpKeXBUVXAvVjY4SGlKZExkSDdO?=
 =?utf-8?B?Nkk0ckhuQjlGbVNzTE9EZ1AvdVJoQU1lNGhNWDdObjdoM05pZEV6Q0k4Y2ph?=
 =?utf-8?B?aHlFeGFOenFkRjQ4WnNKaVdCM2JucDdzenRJalBlZDMxeUcyemVuQktVNDhx?=
 =?utf-8?B?aU4vcndLaG5TNGVReTArNC9rZTdLeWt3Nm1IcGx3azJvdlJhS0FQQnlpNVVK?=
 =?utf-8?B?TlE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84199ec4-a99f-48c4-3854-08dad8d00dd3
X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB1466.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 03:55:32.4808
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DFvhN3Y51MeC1AFSBTX3YZDZr+LAu+gionIMghPC1fY84/Y4yeK5Uf1OPYi9VzTJ/iO6K/XmZZzr+rNoLawH15nHRO3+v9rHevD/enpNycM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB6890
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-08_01,2022-12-07_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0
 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2212080031
X-Proofpoint-ORIG-GUID: ZQjf0cLNkHA7qthGqc66tosRC01srCrI
X-Proofpoint-GUID: ZQjf0cLNkHA7qthGqc66tosRC01srCrI
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/25/22 7:07 PM, Wenchao Hao wrote:
> I found an issue that kernel would send ISCSI_KEVENT_UNBIND_SESSION
> for multiple times which should be fixed.
> 
> This patch introduce target_state in iscsi_cls_session to make
> sure session would send only one ISCSI_KEVENT_UNBIND_SESSION.
> 
> But this would break issue fixed in commit 13e60d3ba287 ("scsi: iscsi:
> Report unbind session event when the target has been removed"). The issue
> is iscsid died for any reason after it send unbind session to kernel, once
> iscsid restart again, it loss kernel's ISCSI_KEVENT_UNBIND_SESSION event.
> 
> Now kernel think iscsi_cls_session has already sent an
> ISCSI_KEVENT_UNBIND_SESSION event and would not send it any more. Which
> would cause userspace unable to logout. Actually the session is in
> invalid state(it's target_id is INVALID), iscsid should not sync this
> session in it's restart.
> 
> So we need to check session's target state during iscsid restart,
> if session is in unbound state, do not sync this session and perform
> session teardown. It's reasonable because once a session is unbound, we
> can not recover it any more(mainly because it's target id is INVALID)
> 
> V7:
> - Define target state to string map and refer this map directly
> - Cleanup __iscsi_unbind_session, drop check for session's
>   target_id == ISCSI_MAX_TARGET since it can be handled by target_state
> 
> V6:
> - Set target state to ALLOCATED in iscsi_add_session
> - Rename state BOUND to SCANNED
> - Make iscsi_session_target_state_name() more efficient
> 
> V5:
> - Add ISCSI_SESSION_TARGET_ALLOCATED to indicate the session's
>   target has been allocated but not scanned yet. We should
>   sync this session and scan this session when iscsid restarted.
> 
> V4:
> - Move debug print out of spinlock critical section
> 
> V3:
> - Make target bind state to a state kind rather than a bool.
> 
> V2:
> - Using target_unbound rather than state to indicate session has been
>   unbound
> 
> Signed-off-by: Wenchao Hao <haowenchao@huawei.com>

Reviewed-by: Mike Christie <michael.christie@oracle.com>