Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.200.110.1.12\))
Subject: Re: [PATCH mm-unstable v5 01/10] mm: add folio dtor and order setter
 functions
From:   Muchun Song <muchun.song@linux.dev>
In-Reply-To: <9a3b3346-4916-7ae5-5abc-4d3c34a0a0fa@nvidia.com>
Date:   Thu, 8 Dec 2022 12:44:27 +0800
Cc:     Mike Kravetz <mike.kravetz@oracle.com>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        linux-kernel@vger.kernel.org,
        Linux Memory Management List <linux-mm@kvack.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Muchun Song <songmuchun@bytedance.com>,
        Matthew Wilcox <willy@infradead.org>,
        Mina Almasry <almasrymina@google.com>,
        Miaohe Lin <linmiaohe@huawei.com>, hughd@google.com,
        tsahu@linux.ibm.com, David Hildenbrand <david@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E8CA63D6-858B-40E5-B3A6-8ED870546DA8@linux.dev>
References: <20221129225039.82257-1-sidhartha.kumar@oracle.com>
 <20221129225039.82257-2-sidhartha.kumar@oracle.com>
 <BAD34D59-187B-4BB3-B139-7983A8B62648@linux.dev> <Y5ALigw0kUO/B3z2@monkey>
 <4161AF1A-9508-4DF8-B756-FEB476EB32B5@linux.dev> <Y5DXivFOA+bO0IYQ@monkey>
 <b995eccf-5818-84ee-560e-20c00f9936b4@oracle.com>
 <d5755326-a71e-242b-5e1e-86fc897dc292@oracle.com> <Y5DotA/pLbakONGl@monkey>
 <3F95112C-C1B3-4774-9E21-998CADEC38D4@linux.dev>
 <9a3b3346-4916-7ae5-5abc-4d3c34a0a0fa@nvidia.com>
To:     John Hubbard <jhubbard@nvidia.com>
Precedence: bulk


> On Dec 8, 2022, at 10:31, John Hubbard <jhubbard@nvidia.com> wrote:
>=20
> On 12/7/22 18:19, Muchun Song wrote:
>> How about adding a new helper like "folio_dissolve_compound(struct =
folio *folio)"?
>> then it may be unnecessary to add a comment.
>=20
> Yes, and in fact, I just finished spelling out exactly how to do that, =
in [1].

Thanks for your guidance. I have replied in thread [1].

>=20
>=20
> [1] =
https://lore.kernel.org/all/d17530ad-8e12-8069-d619-a2d72fe80e15@nvidia.co=
m/
>=20
>=20
> thanks,
> --=20
> John Hubbard
> NVIDIA