Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp662789rwb; Thu, 8 Dec 2022 01:02:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf7Z6u2B1dWNv94dh3WqhGZaDfRA7hsDdW6bCS6rRY4cvRKww9aaTHmC3ewjRuzKgzmUKXMr X-Received: by 2002:a17:906:86ca:b0:7c0:fa2d:bc49 with SMTP id j10-20020a17090686ca00b007c0fa2dbc49mr11934421ejy.438.1670490128346; Thu, 08 Dec 2022 01:02:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670490128; cv=none; d=google.com; s=arc-20160816; b=FaYKoHYD6Vl9SseI510daiLuymMHSraz0FJNIrl26N5KMz0i7fZckU7PNNiTc3EOAO 3FOxsqqpIeail1IHqDT9IyGfrzLMU0aTrJGU4mhkbZxUSd3cB1cWK5kPCpHZ/39nFzbX fDmWBchJ90Av86WYBpFwVfndi7pYthf3SXhJZtOyJ0Ef+a8I+6XTf5q2LHJGArPI6L2m Pm/72a18EVtEd0KaYyTZSVwcu2xzWxKhYLtRTF60LocTDu01zuT913rVwD86kQvO61aQ 4kh887HvsImp8LZr/HYamGchTTe1xYtS2qJbv/zbO5um86ZNgGOr5bjhJO+eVER7FXsL Bebw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=8gHSEpYezHhMJOmSVEZifFxAgxnETaQdMkhrItCxX9c=; b=oUzWCCk8GU4F8BIGWoNFMA1mQZdG7MmekWof7hx6TqbJ/kdC/vyVBR1x/3teN9giiu JmLxZT+DtuH48xwH7SkJdtGRp/CryfB3It2AYBJjEigtiQBMDYmewG/D1sM40hJ47RNB aHtqjYabIL+WueeRe9k9PvN5rnaKHPkdN1B3+jAcG8cHPAYuz61G4L2zJNqGsPy/HptN RjfIIHenu2r0JS4w17eHflRwOzUMqCZuG2Il2fm2d0U+ZUdlmNv+ALzygIWiJBSq7nGk IznBY5wntdmTXgVIxJUEngSww0l0yIsU+Z4FlmObm7aW9lBvHvosYUtfwIQR/eyQzfSe Epqw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id rh16-20020a17090720f000b0078b88453306si14157047ejb.285.2022.12.08.01.01.49; Thu, 08 Dec 2022 01:02:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229809AbiLHIUP (ORCPT + 73 others); Thu, 8 Dec 2022 03:20:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229544AbiLHIUN (ORCPT ); Thu, 8 Dec 2022 03:20:13 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55BD256D50; Thu, 8 Dec 2022 00:20:12 -0800 (PST) Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NSRsk2fNfz4xVnl; Thu, 8 Dec 2022 16:20:10 +0800 (CST) Received: from xaxapp01.zte.com.cn ([10.88.40.50]) by mse-fl1.zte.com.cn with SMTP id 2B88K0JM013604; Thu, 8 Dec 2022 16:20:00 +0800 (+08) (envelope-from ye.xingchen@zte.com.cn) Received: from mapi (xaxapp01[null]) by mapi (Zmail) with MAPI id mid31; Thu, 8 Dec 2022 16:20:03 +0800 (CST) Date: Thu, 8 Dec 2022 16:20:03 +0800 (CST) X-Zmail-TransId: 2af963919e33fffffffff75454a4 X-Mailer: Zmail v1.0 Message-ID: <202212081620030740727@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , Subject: =?UTF-8?B?W1BBVENIXSBzY3NpOiBhYWNyYWlkOiBDb252ZXJ0IHRvIHVzZSBzeXNmc19lbWl0X2F0KCkgQVBJ?= Content-Type: text/plain; charset="UTF-8" X-MAIL: mse-fl1.zte.com.cn 2B88K0JM013604 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 63919E3A.001 by FangMail milter! X-FangMail-Envelope: 1670487610/4NSRsk2fNfz4xVnl/63919E3A.001/10.5.228.132/[10.5.228.132]/mse-fl1.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 63919E3A.001/4NSRsk2fNfz4xVnl X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ye xingchen Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: ye xingchen --- drivers/scsi/aacraid/linit.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 5ba5c18b77b4..83db3195cc1a 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -1233,21 +1233,17 @@ static ssize_t aac_show_flags(struct device *cdev, if (nblank(dprintk(x))) len = snprintf(buf, PAGE_SIZE, "dprintk\n"); #ifdef AAC_DETAILED_STATUS_INFO - len += scnprintf(buf + len, PAGE_SIZE - len, - "AAC_DETAILED_STATUS_INFO\n"); + len += sysfs_emit_at(buf, len, "AAC_DETAILED_STATUS_INFO\n"); #endif if (dev->raw_io_interface && dev->raw_io_64) - len += scnprintf(buf + len, PAGE_SIZE - len, - "SAI_READ_CAPACITY_16\n"); + len += sysfs_emit_at(buf, len, "SAI_READ_CAPACITY_16\n"); if (dev->jbod) - len += scnprintf(buf + len, PAGE_SIZE - len, - "SUPPORTED_JBOD\n"); + len += sysfs_emit_at(buf, len, "SUPPORTED_JBOD\n"); if (dev->supplement_adapter_info.supported_options2 & AAC_OPTION_POWER_MANAGEMENT) - len += scnprintf(buf + len, PAGE_SIZE - len, - "SUPPORTED_POWER_MANAGEMENT\n"); + len += sysfs_emit_at(buf, len, "SUPPORTED_POWER_MANAGEMENT\n"); if (dev->msi) - len += scnprintf(buf + len, PAGE_SIZE - len, "PCI_HAS_MSI\n"); + len += sysfs_emit_at(buf, len, "PCI_HAS_MSI\n"); return len; } -- 2.25.1