Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 12:48:47 +0200 (EET)
From:   =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
To:     Tony Lindgren <tony@atomide.com>
cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        Jiri Slaby <jirislaby@kernel.org>,
        Johan Hovold <johan@kernel.org>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra <vigneshr@ti.com>,
        linux-serial <linux-serial@vger.kernel.org>,
        linux-omap@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v4 1/1] serial: core: Start managing serial controllers
 to enable runtime PM
In-Reply-To: <Y5G5Udw6FAEFdAYi@atomide.com>
Message-ID: <3c87186b-336f-6884-a2c-6ee3c9d70@linux.intel.com>
References: <20221207124305.49943-1-tony@atomide.com> <7f105ff9-cdc3-f98e-2557-812361faa94@linux.intel.com> <Y5G5Udw6FAEFdAYi@atomide.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8323329-1480847773-1670496537=:1682"
Precedence: bulk

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.

--8323329-1480847773-1670496537=:1682
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT

On Thu, 8 Dec 2022, Tony Lindgren wrote:

> * Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> [221208 09:12]:
> > On Wed, 7 Dec 2022, Tony Lindgren wrote:
> > > +	ret = serial_core_add_one_port(drv, port);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	mutex_lock(&port_mutex);
> > > +
> > > +	/* Inititalize a serial core controller device if needed */
> > > +	ctrl_dev = serial_core_ctrl_find(drv, port->dev, port->ctrl_id);
> > > +	if (!ctrl_dev) {
> > > +		ctrl_dev = serial_core_ctrl_device_add(port);
> > > +		if (!ctrl_dev)
> > > +			goto err_remove_port;
> > > +		allocated = true;
> > > +	}
> > > +
> > > +	/* Initialize a serial core port device */
> > > +	ret = serial_core_port_device_add(ctrl_dev, port);
> > 
> > How is ->port_dev supposed to work here?
> > 
> > ->port_dev is not set until in serial_core_port_device_add() but you made
> > serial_core_add_one_port() call before that.
> 
> Hmm do you mean you want to call serial_core_add_one_port() later after
> serial_core_port_device_add()?
> 
> Or are you seeing some uninitialized use of port->port_dev (and not
> port->dev)?

With the other patch on top of this, yes, I did see uninitialized 
port->port_dev already in serial_core_add_one_port()->uart_configure_port().
While that could be solved by removing the pm_runtime_*() calls from 
there, I think it's a generic problem because after 
serial_core_add_one_port() the port can have anything happening on it, no?


-- 
 i.

--8323329-1480847773-1670496537=:1682--