Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Thu, 8 Dec 2022 13:11:31 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     =?utf-8?B?TWHDrXJh?= Canal <mcanal@igalia.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        Oded Gabbay <ogabbay@kernel.org>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Melissa Wen <mwen@igalia.com>,
        =?utf-8?B?QW5kcsOp?= Almeida <andrealmeid@igalia.com>,
        Emma Anholt <emma@anholt.net>,
        Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
        Wambui Karuga <wambui@karuga.org>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/6] drm/vc4: use new debugfs device-centered functions
Message-ID: <20221208121131.cm2f6e33el5agf5p@houat>
References: <20221207132325.140393-1-mcanal@igalia.com>
 <20221207132325.140393-4-mcanal@igalia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cdlhnzwr5xdlwq2a"
Content-Disposition: inline
In-Reply-To: <20221207132325.140393-4-mcanal@igalia.com>
Precedence: bulk


--cdlhnzwr5xdlwq2a
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 07, 2022 at 10:23:22AM -0300, Ma=EDra Canal wrote:
> Currently, vc4 has its own debugfs infrastructure that adds the debugfs
> files on drm_dev_register(). With the introduction of the new debugfs,
> functions, replace the vc4 debugfs structure with the DRM debugfs
> device-centered function, drm_debugfs_add_file().
>=20
> Moreover, remove the explicit error handling of debugfs related functions,
> considering that the only failure mode is -ENOMEM and also that error
> handling is not recommended for debugfs functions, as pointed out in [1].
>=20
> [1] https://lore.kernel.org/all/YWAmZdRwnAt6wh9B@kroah.com/
>=20
> Signed-off-by: Ma=EDra Canal <mcanal@igalia.com>

Reviewed-by: Maxime Ripard <maxime@cerno.tech>

Maxime

--cdlhnzwr5xdlwq2a
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCY5HUcwAKCRDj7w1vZxhR
xSQfAQCguhxm2S1zvh5BBhAJyMgFNk/ClSljeUu03PYGiWRe4QD/WSMFCxQR/XHL
Oqeu1UwlNpWUWtA1dk/QAB9UsIiUfgc=
=P3DW
-----END PGP SIGNATURE-----

--cdlhnzwr5xdlwq2a--