Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 14:18:06 +0100
From:   Michal Kubecek <mkubecek@suse.cz>
To:     yang.yang29@zte.com.cn
Cc:     salil.mehta@huawei.com, yisen.zhuang@huawei.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, brianvv@google.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, xu.panda@zte.com.cn
Subject: Re: [PATCH linux-next] ethtool: use strscpy() to instead of strncpy()
Message-ID: <20221208131806.n6ahsirtkd2ivaru@lion.mk-sys.cz>
References: <202212081947418573438@zte.com.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="zjzpm4etpypm44o4"
Content-Disposition: inline
In-Reply-To: <202212081947418573438@zte.com.cn>
Precedence: bulk


--zjzpm4etpypm44o4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 08, 2022 at 07:47:41PM +0800, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
>=20
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
>=20
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>

The patch looks good to me but the subject prefix should rather be
"hns:" to reflect its target code.

Michal

> ---
>  drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/n=
et/ethernet/hisilicon/hns/hns_ethtool.c
> index 54faf0f2d1d8..b54f3706fb97 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c
> @@ -644,18 +644,15 @@ static void hns_nic_get_drvinfo(struct net_device *=
net_dev,
>  {
>  	struct hns_nic_priv *priv =3D netdev_priv(net_dev);
>=20
> -	strncpy(drvinfo->version, HNAE_DRIVER_VERSION,
> +	strscpy(drvinfo->version, HNAE_DRIVER_VERSION,
>  		sizeof(drvinfo->version));
> -	drvinfo->version[sizeof(drvinfo->version) - 1] =3D '\0';
>=20
> -	strncpy(drvinfo->driver, HNAE_DRIVER_NAME, sizeof(drvinfo->driver));
> -	drvinfo->driver[sizeof(drvinfo->driver) - 1] =3D '\0';
> +	strscpy(drvinfo->driver, HNAE_DRIVER_NAME, sizeof(drvinfo->driver));
>=20
> -	strncpy(drvinfo->bus_info, priv->dev->bus->name,
> +	strscpy(drvinfo->bus_info, priv->dev->bus->name,
>  		sizeof(drvinfo->bus_info));
> -	drvinfo->bus_info[ETHTOOL_BUSINFO_LEN - 1] =3D '\0';
>=20
> -	strncpy(drvinfo->fw_version, "N/A", ETHTOOL_FWVERS_LEN);
> +	strscpy(drvinfo->fw_version, "N/A", ETHTOOL_FWVERS_LEN);
>  	drvinfo->eedump_len =3D 0;
>  }
>=20
> --=20
> 2.15.2

--zjzpm4etpypm44o4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEEWN3j3bieVmp26mKO538sG/LRdpUFAmOR5AYACgkQ538sG/LR
dpWJLwgAk1ejDKpZghnAdrZdWOWzkF9cjpxPC0q1+Z1ZLpt0uUhrYxlDYeW2dy5n
S2O0Nfc80h3W3tqW5TcyIwxXWGmlB8Lz2PCi1tJCCo9rbft9eYuCQfh3WU08dZTE
4ODiYUhbiEM09JCVnaMvT7GIaJDdRHyi5T8ERvF4D+DgpjT7Uvm+qoSPAgkJKhg+
2vi2P5ic+UhFpQUYHgRJduIMBUjl+T7HpPnycurrr2sAM1xEaXx08o/DOJo6jm6k
tCRjmQQq1Pyb9+D7LP5YkIQFPahTe8H43llwoYXJDdAQhgp+dT08iKjHDvm9bFl6
KCSK9tuAIEu6VSsvSQNDDVO09Bu6Ow==
=TKfg
-----END PGP SIGNATURE-----

--zjzpm4etpypm44o4--