Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cdfb37dd-ad8f-249a-2963-87aca53c94a5@amd.com>
Date:   Thu, 8 Dec 2022 15:36:51 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [RFC PATCH V2 16/18] x86/sev: Initialize #HV doorbell and handle
 interrupt requests
Content-Language: en-US
To:     Tianyu Lan <ltykernel@gmail.com>, luto@kernel.org,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
        seanjc@google.com, pbonzini@redhat.com, jgross@suse.com,
        tiala@microsoft.com, kirill@shutemov.name,
        jiangshan.ljs@antgroup.com, peterz@infradead.org,
        ashish.kalra@amd.com, srutherford@google.com,
        akpm@linux-foundation.org, anshuman.khandual@arm.com,
        pawan.kumar.gupta@linux.intel.com, adrian.hunter@intel.com,
        daniel.sneddon@linux.intel.com, alexander.shishkin@linux.intel.com,
        sandipan.das@amd.com, ray.huang@amd.com, brijesh.singh@amd.com,
        michael.roth@amd.com, thomas.lendacky@amd.com,
        venu.busireddy@oracle.com, sterritt@google.com,
        tony.luck@intel.com, samitolvanen@google.com, fenghua.yu@intel.com
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
        linux-hyperv@vger.kernel.org, linux-arch@vger.kernel.org
References: <20221119034633.1728632-1-ltykernel@gmail.com>
 <20221119034633.1728632-17-ltykernel@gmail.com>
 <ddb23472-3f8e-191d-fa5f-d18f1a9e4ad7@amd.com>
 <c3123488-1623-831e-783f-dae215b3f457@gmail.com>
From:   "Gupta, Pankaj" <pankaj.gupta@amd.com>
In-Reply-To: <c3123488-1623-831e-783f-dae215b3f457@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVp0ak5mNzJNUDNSNmNmdmxqRlJTVHozNXgxU3U0MVRuR2I1NjBBYjlVcFhZ?=
 =?utf-8?B?YzBDa1JYUWg5dmF3eWM0ZWZoNDI2ZnNIY2ZqZTBneVhSWStDVklZS3d1d3Vy?=
 =?utf-8?B?TitxNjQrSUJDWUgrNjk2Ky9pREx1NllLc2Q5aDVNRUYvdDlHNHBWTDA2bmU2?=
 =?utf-8?B?T0dxZFRPNWZWcDRrTTlzbzZNc004QTdZb3RTUTI1VndLcTdmTy9UeGVvQWN1?=
 =?utf-8?B?aXRIQ0xjTHJkT2JOR3JoblJMY0xFOTgxcllvU3dwZnUzS1NCSkhRQ3h2dUVE?=
 =?utf-8?B?U1BRQldxQTVhcUVGcFFuK2d4RjA0dy9GL05TMkF6aUdpUHgxQlF0WUFCWkpi?=
 =?utf-8?B?UkxydmtRWHkzWVFQajEwWHUyenFvUGtkZE9oYXcvcjRmQXdrZGpIcEgxYUN4?=
 =?utf-8?B?R3YzbXZENkYrcUEwQjhGM2lMMlR5UEZoSUttUFRCTnZsRnVBaGMrUURWVi9w?=
 =?utf-8?B?cDJ5Z2pMRzVva29PREFOUi80N004SFZuWUxaSWZ6aDhHQk9kSGFTTE9hWlJ0?=
 =?utf-8?B?SlJ3TWZva3I4Sk1yUVdJa0pPUW8vc0ZxWkY3UmJUZmptNWxYRTVudU83eVg3?=
 =?utf-8?B?MkVDM0VKQThMaU9MVmVMMmxPTWVwL0NOcWtyZ3FpNG5QWENWc3NKT3dTSlR1?=
 =?utf-8?B?ZFh1anZPWGFzWE5HaFJOMTF0NlRBcTZOZkgwUW5yc0dXTk03eEVjc3VOOW1H?=
 =?utf-8?B?WVFrZmN5YnkzanhKRWI0a3c5blZuakR6L1JuMTM1cURxSWRlaUxYeWZDTC81?=
 =?utf-8?B?NlFiOWVRdUFnekRxcTRoZHNwVjgweWlGWWMxN1U1eTZJV2JzZEkxL2ZlV3c2?=
 =?utf-8?B?K3B2RGI0L0lTcmFBOThmMWlTRTJ3dm1uTXNuR2tQQWdzRnV5Z21GVE05YXNp?=
 =?utf-8?B?aHg4Tk9tYUMrRmJCWXMrOWVBNzg1anpWbXBLSit4bE5zSFJVNjdpRHR4MzI3?=
 =?utf-8?B?SXZRNnZBeG5qUnUzUHhDa2lMWnAvVS9wL2x0T0NxTWY2ZSs0UzhYRFprV2NR?=
 =?utf-8?B?MnpnQnNWQXpCVGlDV0d3SzJvWkxGSE0rbmJ2b1dCK0hna29hOXk2c2g0L01Y?=
 =?utf-8?B?b3d2TVIrWmo5Sm9wd2ZsMUlwTWp1ZlFmMERtSWdnQWVVSmV2UGRFWldaMTlp?=
 =?utf-8?B?V2Q0aE9lWEZaUUM4T2VZOENvOEt1N0tIY0JGa1BSd3ZycGtJdm9KalZtTUZu?=
 =?utf-8?B?NmpKNm8xdmZBeDRFbE1PTnN5Z0t1T3ozTm5iQWFnUVdsNVUvc2puUk9hT05L?=
 =?utf-8?B?QmY1OWhIQjBabDBhWW1OVmZhL0JONERRc2E3NU9yZFVvWkJyem1zcWQxV3lq?=
 =?utf-8?B?YkpqTmhvL1BybU9wUHEwMW0zUG4vaVc2YTM3L1JzSFkvY1F6cWNySVRGUWhJ?=
 =?utf-8?B?bXRCc3FFdWNqVmE5aWFBdDBaV1owRURRVVlkZHk0ckx0NWtHU1dGZmo2aFNB?=
 =?utf-8?B?ME9LMEdOZHFQTHMwK25pRlhqQUdXSjAxWUQxUlpHeDdheW11UnlEVFZBdmlh?=
 =?utf-8?B?dWhsVmRmeDQ3R2c3WmROWjVweGZnemhBOTc1U0lTWDVDakY0TjRTOWJQT0Za?=
 =?utf-8?B?SGlyQkVvcG1VaVBYcEhSSXcyVVlUNTl4Vk9yM1FjUHA0YUErMlA2UjRXSDJk?=
 =?utf-8?B?NDdzdnVzQzhJVmFGd2JHNFpYMzY2OGtkQStueGVaWnJRRWg4UWlhMmwva0cx?=
 =?utf-8?B?QUx0OTFhRTIxYW1aUGptWkFDRUJqdzJKUFdqdFQzcHBreGZMY2c0WTViL2Ex?=
 =?utf-8?B?LzlLT010TkJkWFFwQkI4Y0tINlpQQVZqcXZpaDZxaytDQW9aU3FkVW1tbjdI?=
 =?utf-8?B?UUxvSXY1eWEzUFdhWXVNc1kxaWlEQk5sNTI2T0k3VDc4L0ZuZE5HRXBtY2hK?=
 =?utf-8?B?WWZacEFYcVZjdUNPQ2FZS2N1enhMTGNUWTZSYjNGUWxGZnhlRGZOelplM3Fs?=
 =?utf-8?B?YkZ1dUVSUUNISFpWemJEQ2tGbDVpUGFSM2N0Zi9SSDE5dGoxOUVxZEV4VUhP?=
 =?utf-8?B?SUtUdDZvcWorWTZDK3ZGTk9jUUJ2U09Sd2hFSDJPVFV3QTk1dllWb2pvK2tM?=
 =?utf-8?B?S1JJVlNFakMyM2gyMmZRY0t3YktsUGFLdVRRcmRTOVF2bjM1bUEyZHM0SC9N?=
 =?utf-8?Q?sOeQjtOi1orYE1YwywRrS7lci?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0bd51f2f-33e5-4bcc-bb71-08dad929b445
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2810.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 14:37:17.1920
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Nxe6iiH3VC8sj+5fZezymMPqOuWbFII1U8tJfHXbdorwBBCMbCz+Y4beHk4IdsR8xa8dNWhEoG1vHDHrF0/bGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5118
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/8/2022 3:21 PM, Tianyu Lan wrote:
> On 12/7/2022 10:13 PM, Gupta, Pankaj wrote:
>>> +#endif
>>> +}
>>> +
>>>   static __always_inline void native_irq_disable(void)
>>>   {
>>>       asm volatile("cli": : :"memory");
>>> @@ -43,6 +59,9 @@ static __always_inline void native_irq_disable(void)
>>>   static __always_inline void native_irq_enable(void)
>>>   {
>>>       asm volatile("sti": : :"memory");
>>> +#ifdef CONFIG_AMD_MEM_ENCRYPT
>>> +    check_hv_pending(NULL);
>>
>> Just trying to understand when regs will be NULL?
> 
> check_hv_pending() will be divided into two functions.
> 
> The one handles #hv event in the #HV exception code path.
> The other one handles pending irq event in the irq re-enable
> code path。 In this version, the "regs = NULL" for check_hv_pending()
> is used in the irq re-enable code path.

Got it.

Thanks,
Pankaj