Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 15:39:12 +0100
From:   Alexandre Belloni <alexandre.belloni@bootlin.com>
To:     Claudiu Beznea <claudiu.beznea@microchip.com>
Cc:     mturquette@baylibre.com, sboyd@kernel.org,
        nicolas.ferre@microchip.com, krzysztof.kozlowski@linaro.org,
        linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] clk: at91: do not compile dt-compat.c for sama7g5
 and sam9x60
Message-ID: <Y5H3EH7kPOwGI2SQ@mail.local>
References: <20221208114515.35179-1-claudiu.beznea@microchip.com>
 <20221208114515.35179-4-claudiu.beznea@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221208114515.35179-4-claudiu.beznea@microchip.com>
Precedence: bulk

On 08/12/2022 13:45:15+0200, Claudiu Beznea wrote:
> There is no need to have dt-compat.c compiled for SAMA7G5 and SAM9X60
> as there is no in kernel device tree that could use it. Thus avoid
> compiling dt-compat.c for them.
> 

Isn't it time to drop dt-compat.c? I was going to send a patch after 6.1
is released

> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> ---
>  drivers/clk/at91/Makefile | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/clk/at91/Makefile b/drivers/clk/at91/Makefile
> index 79301e1c1c36..89061b85e7d2 100644
> --- a/drivers/clk/at91/Makefile
> +++ b/drivers/clk/at91/Makefile
> @@ -3,7 +3,7 @@
>  # Makefile for at91 specific clk
>  #
>  
> -obj-y += pmc.o sckc.o dt-compat.o
> +obj-y += pmc.o sckc.o
>  obj-y += clk-slow.o clk-main.o clk-pll.o clk-plldiv.o clk-master.o
>  obj-y += clk-system.o clk-peripheral.o clk-programmable.o
>  
> @@ -15,12 +15,12 @@ obj-$(CONFIG_HAVE_AT91_H32MX)		+= clk-h32mx.o
>  obj-$(CONFIG_HAVE_AT91_GENERATED_CLK)	+= clk-generated.o
>  obj-$(CONFIG_HAVE_AT91_I2S_MUX_CLK)	+= clk-i2s-mux.o
>  obj-$(CONFIG_HAVE_AT91_SAM9X60_PLL)	+= clk-sam9x60-pll.o
> -obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o
> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o
> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o
> -obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o
> +obj-$(CONFIG_SOC_AT91RM9200) += at91rm9200.o dt-compat.o
> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9260.o at91sam9rl.o at91sam9x5.o dt-compat.o
> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9g45.o dt-compat.o
> +obj-$(CONFIG_SOC_AT91SAM9) += at91sam9n12.o at91sam9x5.o dt-compat.o
>  obj-$(CONFIG_SOC_SAM9X60) += sam9x60.o
> -obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o
> -obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o
> -obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o
> +obj-$(CONFIG_SOC_SAMA5D3) += sama5d3.o dt-compat.o
> +obj-$(CONFIG_SOC_SAMA5D4) += sama5d4.o dt-compat.o
> +obj-$(CONFIG_SOC_SAMA5D2) += sama5d2.o dt-compat.o
>  obj-$(CONFIG_SOC_SAMA7G5) += sama7g5.o
> -- 
> 2.34.1
> 

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com