Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1177020rwb; Thu, 8 Dec 2022 07:35:34 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Zpzw3kwiV5N1e2Z5z7xFUiCpSSH1+qizN6zZ52KXQfWHPB+zYhIb/f6MXA3VFrfQh44tr X-Received: by 2002:a17:906:99cd:b0:7c1:10d9:8897 with SMTP id s13-20020a17090699cd00b007c110d98897mr7835241ejn.660.1670513733905; Thu, 08 Dec 2022 07:35:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670513733; cv=none; d=google.com; s=arc-20160816; b=N/6V0NtG2tK0y0K+ZVflC4GmdUlcAU5X1diePMYBoNmtlLYF4rWqSk7qniOrKLjoCC i6izlHReExiIVynVH8id1YVCHKY00kJJEyrpBRdLeNAFYby0hKoXRvUVfUrYZYzkZkrW Wpg+ziFp5F0f0q29Dvd+35Sj9rBto6J/XcG+jtJHBzVjrCSATrDtqMf2XknY9DTwXy54 NcyFG0cmdopJjA+jCDrzS5yavhcyoJQJEubfctzuqbG9a6+3uOAjijQ9Wr2FPDdIW5Zg 31xz4tua0mQKNMIB16PIc7sdiFFBQKsD477ZL5kDcL4CoLs0cE2asd0wJ+d+j8P8XIYq rHQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=C7Bq1jaABPqnvcdD20frWPwa1ZDzg3R23L+HGhf2pEY=; b=db2O3NXI9GmnzDBsgxUG5kjP1p7x8nCH+tQv8x3IhlrFa09T/DZ1tbWULlxWQCwh6v vO0v5LJ7N/xb+OOxaNSgYDSyo1CPZUgQqzyhMGvuid45DXJRS74XM5n8F6cy2f9YrAoC pZ48rt9kdEo6PONxfgjMCeol82FX4EfbDY699GMxVj7Nh2pMLRf5khvPBNdhh8RK2KpM 910qW9z3nEc6cMH6kJOGb/A+C4aydA+p8X4bEse2bJNIZNi/LUe7EUFc+HhSwzim7dXZ bngGVxNjmflNJWEoLeD1psdJy82W2cANfn7wSaGEPf3A+3NeoLZHBixgl3aIjFaMcImJ GkTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=dsGSXrzi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz15-20020a0564021d4f00b0046af62544a0si8401132edb.401.2022.12.08.07.35.10; Thu, 08 Dec 2022 07:35:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=dsGSXrzi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229942AbiLHOUq (ORCPT + 72 others); Thu, 8 Dec 2022 09:20:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbiLHOUf (ORCPT ); Thu, 8 Dec 2022 09:20:35 -0500 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB97883EBC; Thu, 8 Dec 2022 06:20:34 -0800 (PST) Received: (Authenticated sender: paul.kocialkowski@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id D4BF7C0008; Thu, 8 Dec 2022 14:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1670509233; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C7Bq1jaABPqnvcdD20frWPwa1ZDzg3R23L+HGhf2pEY=; b=dsGSXrzij4d5S1T4L635XDwIWwMSrZsfUJHtTCTXR20N82Gh8+cQjVwmvHLUKeFGzTx8be Ta3MgnNVoUyd4JyGL1caOFxiLW7mMcHTznQhTUqKSm/TI7a7OrGNPiQvV3H88bgqrjcyxK bf0f3+gEnAzeVN+8RFrs70wxZm2aH5MVwP3Mg9Ok0AqJsJ/Lbat3qtMhObopIvEN4v9Hp0 RHA++MXD7sYagbu6iAnpV1gklbUOy7Ocf1a57TAcIu31hc0V+yAiKsYDQOdXkq42lFPjCQ x0OxieCbWG58PDx9Ws+u4grmFQQghMT/BMhkKBhduUxNpU75h1RhMlb9EoMARA== From: Paul Kocialkowski To: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Cc: Yong Deng , Paul Kocialkowski , Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thomas Petazzoni , Hans Verkuil , Sakari Ailus , Conor Dooley , Nathan Chancellor Subject: [PATCH v3 03/12] media: sunxi-csi: bridge: Declare subdev ops as static Date: Thu, 8 Dec 2022 15:19:57 +0100 Message-Id: <20221208142006.425809-4-paul.kocialkowski@bootlin.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221208142006.425809-1-paul.kocialkowski@bootlin.com> References: <20221208142006.425809-1-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The static keyword is missing in the v4l2 subdev ops definition for the bridge. Signed-off-by: Paul Kocialkowski Fixes: 0d2b746b1bef ("media: sun6i-csi: Add bridge v4l2 subdev with port management") --- drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c index 4517c0346eef..7fcb0815cb42 100644 --- a/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c +++ b/drivers/media/platform/sunxi/sun6i-csi/sun6i_csi_bridge.c @@ -587,7 +587,7 @@ static const struct v4l2_subdev_pad_ops sun6i_csi_bridge_pad_ops = { .set_fmt = sun6i_csi_bridge_set_fmt, }; -const struct v4l2_subdev_ops sun6i_csi_bridge_subdev_ops = { +static const struct v4l2_subdev_ops sun6i_csi_bridge_subdev_ops = { .video = &sun6i_csi_bridge_video_ops, .pad = &sun6i_csi_bridge_pad_ops, }; -- 2.38.1