Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <27378fda-5b0b-1be8-dc2e-bd408fad4071@socionext.com>
Date:   Fri, 9 Dec 2022 00:09:49 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH v2 03/16] dt-bindings: pinctrl: Fix node descriptions in
 uniphier-pinctrl example
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc:     Masami Hiramatsu <mhiramat@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20221207055405.30940-1-hayashi.kunihiko@socionext.com>
 <20221207055405.30940-4-hayashi.kunihiko@socionext.com>
 <edd39013-af5f-5868-6c78-173d8f163754@linaro.org>
From:   Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
In-Reply-To: <edd39013-af5f-5868-6c78-173d8f163754@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/12/08 17:07, Krzysztof Kozlowski wrote:
> On 07/12/2022 06:53, Kunihiko Hayashi wrote:
>> Rename the parent node to the generic node name "syscon".
>>
>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> index 14a8c0215cc6..186fc550af4c 100644
>> ---
>> a/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> +++
>> b/Documentation/devicetree/bindings/pinctrl/socionext,uniphier-pinctrl.yaml
>> @@ -69,7 +69,7 @@ examples:
>>     - |
>>       // The UniPhier pinctrl should be a subnode of a "syscon" compatible
>> node.
>>
>> -    soc-glue@5f800000 {
>> +    syscon@5f800000 {
>>           compatible = "socionext,uniphier-pro4-soc-glue", "simple-mfd",
>> "syscon";
>>           reg = <0x5f800000 0x2000>;
>>
> 
> Not visible in the diff but this is a poor example. It has only
> compatible! Drop the parent node instead and extend the pinctrl node to
> show complete picture of pinctrl.

I should add some child nodes of groups and pin attributes as an example
from the devicetree.

Thank you,

---
Best Regards
Kunihiko Hayashi