Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 17:11:08 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     yang.yang29@zte.com.cn
Cc:     salil.mehta@huawei.com, yisen.zhuang@huawei.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, brianvv@google.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, xu.panda@zte.com.cn
Subject: Re: [PATCH linux-next] net: hns3: use strscpy() to instead of
 strncpy()
Message-ID: <Y5IMnKja6kyhuq01@corigine.com>
References: <202212081953254923522@zte.com.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202212081953254923522@zte.com.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FQ2KDPHyGdqdxKq9fRze793BR0oJ/ykNxiqw/Uv23MG1S2IDtHI9ed0GUz1f?=
 =?us-ascii?Q?nrg2aTaPXBWP88EOrhQX0roFkNWXbrhiB4RoNOT+EA8V3+6rna9iGeAm+4NX?=
 =?us-ascii?Q?cZLSz4uVPmj9ZGpHVjOou4SpIdQ4yeB/QvqRP0uYjqBbnhG3/Y1WRd7u58AA?=
 =?us-ascii?Q?CtI2TB4BEgtuLTLHRjFXn+ozR4t31Qgdrghzf+Wm5btNBOlZplVVMmeSDcNn?=
 =?us-ascii?Q?A1FFrHJ9yMrernNNNcRACBc8VBbs6YLgV66nYg7/Rbkw8wdTAivAIyByIN4Q?=
 =?us-ascii?Q?tF76MgG+x50Mrv32/si6bpcA6s2VpS5EZie4VJrFxAkMToKPOoT7kJnlpcZX?=
 =?us-ascii?Q?Vaf+0wGcZkOxB0AriMBa95Ty5PgOvHFg7ZikiioHYmXui1HwKocbi7ZM3O/B?=
 =?us-ascii?Q?/jFwcfCbSktpm+3sFZAocg32fo3Cq2OmaVpcrWzxukVcC+RxkcTKnKDPI2DC?=
 =?us-ascii?Q?H8fvd3/xjudthS6EVZbIxmlPVhiaDEWGhWk971Q9neMZoPTOMzBgD39vtGLB?=
 =?us-ascii?Q?mamKUieECPl+mEQ3SA3TkeVzGEbvS6AfKEf9K0uAdGoLdk1fMAOBnj91TGj8?=
 =?us-ascii?Q?3JqS+e3WE2zCekgbobo37C7CHAWVq0Rtq6XNU6A7E34xlknU5LCp/EvgIhEH?=
 =?us-ascii?Q?6QjayUMNI0p6QzXGV9dE4RPnXb07GrvH1O3nFsO0QUtsUcSQ+ePemvtYplE/?=
 =?us-ascii?Q?ZSYFShxTfbUM9X5XK+LqjZ1HEghqx3BcGrfFq9t4n+EdABtC5kVwuC4e87ps?=
 =?us-ascii?Q?3XXybmc1b25Cr3DKix4TVZIQ3r9Vnz+y+QzM4/DX4TnJFfd86x8L7Hv2Z0da?=
 =?us-ascii?Q?zkZwjyvByLyNvyMTOQu6bvoeEi2Y4aekE90La73+2rJkK5AZcCQhC8B8FuLK?=
 =?us-ascii?Q?hzhKHaoBVnkV97FdxMNL0FAQCkh867RLXYPXVjESt9VGV1N2t1dkmZx02zPQ?=
 =?us-ascii?Q?RRhGKn3W0wvKiMFOFH8MSATyI7nhmuY4xJqz3pC8Ea+ZfF4uc/T53shxFHzg?=
 =?us-ascii?Q?XxPZ2PLSVf3sPVDZcVNnbMwIrzOZ/QE7GaePlAV+Ashh7DbYOuQYOHGagwgh?=
 =?us-ascii?Q?Hz46bshmV/3H7bIxgbGinTDmMSP68To/dx068Vp/XdSaG9Q4S8MxPJcgZFF6?=
 =?us-ascii?Q?mDC7Rq6gKG2KRvZBN9aapHZXXQRw4bACudx+JdTfNrPqoz4KwLRXFiotPnuK?=
 =?us-ascii?Q?Qbfs+c8KM/MLJ094L3XzcgHFVGCEjb2WeumO4yJ7ooa3fu8mmpfWP+c9TpIl?=
 =?us-ascii?Q?2Ex6LdFgjaZmmyy/31AFUwJqQNVB9hF4uuLldINh4YKMP9rnDTRSMlTJK69A?=
 =?us-ascii?Q?979EuQtc+fg2jnTT47RZcyRFZb2Q5zUdOgbb/1MBYGEU03zdZxLE6gBTm4rz?=
 =?us-ascii?Q?vd01OYbr/MzZLbYGLyclR4shJYcC9NM9rERetEVE4PQjnDvyPu3RqC8kbLEo?=
 =?us-ascii?Q?N2hmJ7xhKDPycHh2Y9Qgag1asmecOfgOMmLSVM2pxciwTHgrN8TQXzZoFf8x?=
 =?us-ascii?Q?AxgJusjKuVqRjOZXoBaVDKyQqb21SaLDQ4MC3uZXBjPXp4eRz2AeNmi7ouEM?=
 =?us-ascii?Q?ywAzWKpSPxD/mfoRu+8OCMq48YQ+vgxv0NZRt3Unj4/khkM+p0a2OAW7BOmX?=
 =?us-ascii?Q?nFCNrnHH1jcGG0BTGXMOdCST5coBS6y1tH5sh+Flwq2jvn8jvP9E49PXQacB?=
 =?us-ascii?Q?2xM0wA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a6c860a-82ec-45b5-3019-08dad936d870
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 16:11:21.1382
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: juESjCS1NML9fOrjKvf5eAD5isbv8FGU9Nx9m4lVfHlxGpnoTF7RvQyPEvhqdHuuLcA/K6fKCS3FgRTjbZqzFzFNgGpx4NWKFJ348JC1PSg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR13MB4834
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 08, 2022 at 07:53:25PM +0800, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
> 
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>

This change looks good to me, although it should probably be
tagged for 'net-next' rather than 'linux-next'.

  [PATCH net-next] net: hns3: use strscpy() to instead of strncpy

That notwithstanding,

Reviewed-by: Simon Horman <simon.horman@corigine.com>