Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1330664rwb; Thu, 8 Dec 2022 09:15:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf73N/RMTeogwRnLasgB9pxbqaLyd7+7dw3ij5iyvjf4gTU2mE+VLxPantdK1P4qSljXGaeE X-Received: by 2002:a17:902:b685:b0:186:5e2f:44b4 with SMTP id c5-20020a170902b68500b001865e2f44b4mr10981485pls.29.1670519758725; Thu, 08 Dec 2022 09:15:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670519758; cv=none; d=google.com; s=arc-20160816; b=tWLldLn/09yIVV4RFpDRVhl8ibAagPqDSbAD1o1dh7zVWGJiZ3pIGLzMR9hvHGOOWd bXT0NMhxDnA69RAp8e3e0HDDMx7+Nk7oy+nX1i7r2M5yjS3bYrFfKH0RX9vfiyGfl6EV ImL6SRnKTVUTx+QdMrr2CgcHiAYhlVudPeWUsK2qVS0Z+E0j0VkACDtMsZYMfIixCBXe PP/OuOsbMEp7KBPgrJbaq7YRFTw5JI3Nn0GKC/IiFty/cSdVqtlNLtzJHKDgpA27PaxM SH72AVok7Q/BpewZKmhO3jjBnINwIstDf8B2P0VitJMADkdb0DzZMdb8wUJ/dCjLB6pr qb/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:message-id:user-agent :references:in-reply-to:subject:cc:to:from:date:mime-version; bh=HfMJIIIsnHXOxUZNfkQWuZlrngVAWZpa/V93PAhxjCk=; b=Oe6FhRBASNXXXObonGRptRoqCUht0514wjjz76q7kIFflzUn/+K367fKOmmbUGBymO LqmJzcBGZtlbyGDDVb1Xb9/U/PPSMwGB6s3Kf5a40cqNBhV03Xz7XlmY9Bh/JvGU4hg0 Cdo8yVwAC7JJi4c1o8m2VATnZofST8viFiROfyEAIjQNISuBsQ3asf5wzeGUyDmUz/ql 9y3l7j6GsmpCkLkbAwpX3USCEMwQdyibZJBcRsObbwymyDZ3YBwCPEVybY8pBIWTmHZq 9hZWNf/1doz1TxhWU7+8rvJ1ilDJ6M92/FbpjtHqXUVe3eyMjBMFs0JIcBgZ2a08vMLq DJLQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pw17-20020a17090b279100b00202b984842csi4771165pjb.35.2022.12.08.09.15.49; Thu, 08 Dec 2022 09:15:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229772AbiLHQEJ (ORCPT + 72 others); Thu, 8 Dec 2022 11:04:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230018AbiLHQEF (ORCPT ); Thu, 8 Dec 2022 11:04:05 -0500 Received: from mailout-taastrup.gigahost.dk (mailout-taastrup.gigahost.dk [46.183.139.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E4339B2AD; Thu, 8 Dec 2022 08:04:01 -0800 (PST) Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id DF03A1883A08; Thu, 8 Dec 2022 16:03:59 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id CD4E825002E1; Thu, 8 Dec 2022 16:03:59 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id BF2359EC0022; Thu, 8 Dec 2022 16:03:59 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Thu, 08 Dec 2022 17:03:59 +0100 From: netdev@kapio-technology.com To: Vladimir Oltean Cc: Ido Schimmel , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli , Eric Dumazet , Paolo Abeni , open list Subject: Re: [PATCH net-next 3/3] net: dsa: mv88e6xxx: mac-auth/MAB implementation In-Reply-To: <20221208133524.uiqt3vwecrketc5y@skbuf> References: <20221205185908.217520-1-netdev@kapio-technology.com> <20221205185908.217520-4-netdev@kapio-technology.com> <580f6bd5ee7df0c8f0c7623a5b213d8f@kapio-technology.com> <20221207202935.eil7swy4osu65qlb@skbuf> <1b0d42df6b3f2f17f77cfb45cf8339da@kapio-technology.com> <20221208133524.uiqt3vwecrketc5y@skbuf> User-Agent: Gigahost Webmail Message-ID: <7c7986329901730416b1505535ec3d36@kapio-technology.com> X-Sender: netdev@kapio-technology.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-12-08 14:35, Vladimir Oltean wrote: > > So it appears that frames which get a VTU miss will still also cause an > ATU miss, and that's what you're seeing. > > The solution would be to acknowledge this fact, and not print any error > message from the ATU IRQ handler for unknown FID/VID, which would just > alarm the user. Thanks for clearing that up! At leisure, do you have an idea why it will encounter a VTU miss violation at random? I guess I must check if FID != FID_STANDALONE instead then...