Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1350871rwb; Thu, 8 Dec 2022 09:30:40 -0800 (PST) X-Google-Smtp-Source: AA0mqf7GkX8ByRTxYgbuhwExRnaVQWLytw+dq50nJDdykFLJMYkSOdHvbH3tZoyEekTlbBbTNW8L X-Received: by 2002:a17:906:30c3:b0:7ba:a674:22e4 with SMTP id b3-20020a17090630c300b007baa67422e4mr54853562ejb.279.1670520640395; Thu, 08 Dec 2022 09:30:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670520640; cv=none; d=google.com; s=arc-20160816; b=pC+rx+qiFqSIb7ORN4NGIsmhDD9kg/+Va8qN9NcvwDPEKKOi76s3kYfM61qiKwPInD QfY5/2CP/CYDKYO2Fc/et5lnS+c97uhvR1czJo3CN98kfoKm4tmwQfVcoWr9pxjaejln N3M1cdGKoCPGKFmqzGvK+GuklrKYiVpnHn2RI/g+3roRASH+4xhYwiulkhPhnK4s959W rt84Mw8M+wVTrRcnKr4Pw8kZ79dTeYykvq7ptofVeMYr6fUkVMoaQA5qQqynpbMVSfaR iShytmY8es3ATjpyr+UB5Un+h4hGY9uJIUsWZgpFAWJO7gaZavouXGfOAkxyxmquVE6s fYbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PgTcP7Sb6G+mxt6RrmX5diGBUpEOwhypZwyQEkEjZUo=; b=DQTXZZozQ3fzCDkbq1rXK4cI9s+sVu01sT1aT71kUx0bRXFBrDyBGfsHTPRJPtRFAj YQtLUhEwwn6DGglbPuR4aMgWiSEJYoPboJvd4fnvD6IXHCcfKjyszKMik6qWDgsn4QYw vPYX7el9M3l5sJ4/WUKOLWztgWtSDbcEpC/3PUQQgeuO+Hf2XYaYSdnSulnwG0Rk/7Rq g8RKCWfs6YK90CJTqSAf7srE33CAkptuu9Hs/uMjNrZ4gv5xvFHUlN7/fiUDzLvnDxgV V/kH8SYCN3XA8rMbY2auKwzGd1T8RHxoncs+m8HzdHF6wzshvnESVDaeo+J+08besh0f ZzQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=KLiZD2qB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m24-20020a056402051800b0046cb20e357esi6189040edv.366.2022.12.08.09.30.22; Thu, 08 Dec 2022 09:30:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@resnulli-us.20210112.gappssmtp.com header.s=20210112 header.b=KLiZD2qB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbiLHQCQ (ORCPT + 72 others); Thu, 8 Dec 2022 11:02:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229896AbiLHQCN (ORCPT ); Thu, 8 Dec 2022 11:02:13 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFB139B28E for ; Thu, 8 Dec 2022 08:02:11 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id vv4so5142434ejc.2 for ; Thu, 08 Dec 2022 08:02:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PgTcP7Sb6G+mxt6RrmX5diGBUpEOwhypZwyQEkEjZUo=; b=KLiZD2qBOu/qNsJ2cZjRu0xhRjkjzMUvesjTwJF+Nj34blnUwi+EXBP1laZJLS8qQj cAr+pVGQEkgP7EGIXfq2cAWyFCTDfhDG4cfZCYyiuGXVclg4Ynx/DWUMEaRSTGz833dN NCoHV26jGRcTcQFsYg2jyVoKA97rHaaFhk9n7HsPuWB/Tb8YKl8MTuMkV3zveMStl4JV Fs1Hau6UHdvfP1TGdyZ2wg9UWxVTI+u/sCEEHMSHyEXMjnoVcHwKffCOiWvuQNiEBOqL qxXGyjwsH7GGufZlywGdDJo7ICy0YGaGpAj92BiZSrgKRLKt3z8huikoi8IE9RYGETD6 s8fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PgTcP7Sb6G+mxt6RrmX5diGBUpEOwhypZwyQEkEjZUo=; b=CNtcInEeFmxg+myVaXv2vYFGfGb1jYCXJ1b9uhN/XZva0hIcgSRT5lpAQfcddqnl49 8XUZN3ASUQrB+20G2bh7IxvYbun7yzHgDhHWaSU2/+mgjO4bYvtyhsX7XFY08OlWqrJZ nCc5hXf/5Fa3VcRovgUXHbFDyIc13VUyUm9julsTz/vOzJzRB5WMEN8sF2qmxZXGBfiz ErR/kiabBycaZ2J3JerydtP/ZI2B1lkrmqU4t4Tzf76SMXyqJls6noNmd4TQ4CQrRPJb Z/a21W/WJ+Sryatkxb4QRpriz5/Tswutwn4TB9ZC6v3Vw3DgRksL57wWdOvcJTvKWsbg ZIZA== X-Gm-Message-State: ANoB5pk5hW5eMp9S7rcefgjTbX0u3nT4pD2r8MNZm1ltG0rMM1pUC9+r BYoNqw8OlJmtnDMoyxYFPOsiqg== X-Received: by 2002:a17:906:1e4d:b0:7c1:ac8:73a0 with SMTP id i13-20020a1709061e4d00b007c10ac873a0mr2285776ejj.51.1670515330398; Thu, 08 Dec 2022 08:02:10 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id z16-20020a1709060f1000b007c1175334basm2675858eji.78.2022.12.08.08.02.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 08:02:08 -0800 (PST) Date: Thu, 8 Dec 2022 17:02:04 +0100 From: Jiri Pirko To: Jiasheng Jiang Cc: leon@kernel.org, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net v4] ice: Add check for kzalloc Message-ID: References: <20221208133552.21915-1-jiasheng@iscas.ac.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221208133552.21915-1-jiasheng@iscas.ac.cn> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thu, Dec 08, 2022 at 02:35:52PM CET, jiasheng@iscas.ac.cn wrote: >Add the check for the return value of kzalloc in order to avoid >NULL pointer dereference. >Moreover, use the goto-label to share the clean code. > >Fixes: d6b98c8d242a ("ice: add write functionality for GNSS TTY") >Signed-off-by: Jiasheng Jiang Reviewed-by: Jiri Pirko