Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 17:07:50 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     yang.yang29@zte.com.cn
Cc:     dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, xu.panda@zte.com.cn
Subject: Re: [PATCH linux-next] net/liquidio: use strscpy() to instead of
Message-ID: <Y5IL1up0Z4uT2TVc@corigine.com>
References: <202212081955061873542@zte.com.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202212081955061873542@zte.com.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nDhfQmUtxHIseOd2D36QhY6a2xD2Mj4xucL7HbOvvzVjGmkZ3gdV2yd501i8?=
 =?us-ascii?Q?JfO2LzqbJsGtYB5ZBp8HSggEJs8g3tcpDRrUb7xga7ElecYQ+oS8pgDFrUnA?=
 =?us-ascii?Q?BKN0ovFGaSzMVKTaSfO48hrsnwp6Y3i/A5NJ7HEFo4yNPnUVKXTAWYvdqfG4?=
 =?us-ascii?Q?DwPgQdl8gFjoihJniE4W6IhpNV3yHFL4LDJyn2oNHX3+8HHM+rf1PRnVume/?=
 =?us-ascii?Q?gRsx+bzAFiEyVrU+WK3vJdLy4AkgUX1FvL9pRkBOT8Iec0ujbuPIVnDr3HE8?=
 =?us-ascii?Q?j1gInmIAUVNhIQTdgmUVTO3+ppqcPx5NDR60fPGJ5NGw5oRLcGmdBBhwfqTG?=
 =?us-ascii?Q?UoYf2Wx6OCcevk3MwKxNAWzm1XuXtnD2kufF9IUgGe2QRSZPWMsK09aycQ3X?=
 =?us-ascii?Q?Y5ltACWm/w4rl+yzxcM7uDUvaBy3Z7vJfmIl62OKkXoWbgtceQih1/36xWtO?=
 =?us-ascii?Q?mIcKGxm3gS0ri4jR/wtvH5VSW/GKuczKE/KeJHou1/2Zjq4o1HUDH+7s/Ytn?=
 =?us-ascii?Q?OOfqY/RwDnogBUAUcjxZj6pw2LRm7riE6smISr8LPAJxdsavyYJfiNdjUDXY?=
 =?us-ascii?Q?q4GRlrlfrBA/PGMt5/i+sc4OhP5ZvVrBx4EmXoMAnfWXaqEt1V4wnzeG5gfP?=
 =?us-ascii?Q?wVAEKeVKjngajxcewXx5JtraTsrPoHMMvOsYpwHj5FDOi5duMoG5TFvta+rK?=
 =?us-ascii?Q?qnZhmlYWhVLwbcNsKyBAFnpylpN1aLsUyMHGNPTur+gw9jcJbI7wmrn7O3RI?=
 =?us-ascii?Q?uzDb7rysgDdtaWS/kj23/eflsrGm+zg615kPI9dtSUUvKq4P2Q4OaxRi3XKE?=
 =?us-ascii?Q?wMUhS8PpKo+6A+k5i9CV2s1h2ReErtjrcQTqIkgXSxitYkbblnAB4CqMNSE3?=
 =?us-ascii?Q?ujwZFharScJXok+jtVs7LIl+jI7lw0nDERpqZX4H7ioCYsbtmGuMwvAUjnGt?=
 =?us-ascii?Q?OqOx6TUxp9QGGvzj9UzU+r9kVkhpLLIIa9/hM9NXICrzDiJRBzgh8YJKFGeM?=
 =?us-ascii?Q?5Xe2l8MOjhERKQNxUcDNkqZGajDAwv3GDX/4bKHMm8CDm2z0S16s4WR96F2K?=
 =?us-ascii?Q?Un9sOMFnxXK2yzrwL4oePvV7/L0cnETWjz5rSuzSCSwlcXX1R37gnMiqnUHn?=
 =?us-ascii?Q?LqNmXxBouRk4lM98UugYdxlZVhTRm8Ul4+M7rqdbDf2dmhI7FDPBofzJa8RH?=
 =?us-ascii?Q?ILACZzCkk6aePRGKn6A7duA8zu7QuVhG1uuaDWBpf1fnGXBd7/TpuemlCg/8?=
 =?us-ascii?Q?BgVSyHUimJJ97UakElTcnbNGYKeswQliGLqrkUfI5+tnQAsL4MXib5Y3xsf0?=
 =?us-ascii?Q?f9BdgfjOH6Epc57mAu3FVejwwgTN/q6ocJg3AgxpWuQpFDZSLzuAndAqnpuz?=
 =?us-ascii?Q?bsYLYgjixZ4kgYG6r49U1gUJE0VRDhSO0Rr88NqL0/htAtHw2vwZFCSPwvpV?=
 =?us-ascii?Q?kn1wViEn3puFL5FHRhOPkPaRgAycnOiJHokX63ZXYut/CgHwdcuKcF3eKxTN?=
 =?us-ascii?Q?rYQ2gGYf5IsjSPC7lLWf4OQW86FeDdtCR+UxxXhBWZfsjosjraOvRMyR6gRY?=
 =?us-ascii?Q?p1VOSzPjVNXGugwzcICM9FmA6MJWIoquBWUzqnAcRWrNE696QLGyZRUIZN+n?=
 =?us-ascii?Q?bk1PSVflu3LsXcP072f3wQdu/709/gic7KkK0EjNpgRLoYWYW6772Dmr/eGI?=
 =?us-ascii?Q?3CXwpA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f0809ae-8730-4025-0090-08dad9365e4d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 16:07:56.2412
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BOkwwx3XDn/+Ac6Sms79hJ5y4vNRythPAWFQCUtiQQE5EU/kOnN7Lcobe+mQdJoRBLgqgLygudkiOcfeyYHdPVH4VJznntV6ZvYtQ2ExaKE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR13MB5726
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 08, 2022 at 07:55:06PM +0800, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
> 
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>

This change looks good to me, but I think the subject should be:

[PATCH net-next] liquidio: use strscpy() to instead of strncpy()

Also, in the same file, does this need attention?

        /* Save off any leftovers */
        if (line != &console_buffer[bytes_read]) {
                console_buffer[bytes_read] = '\0';
                len = strlen(console->leftover);
                strncpy(&console->leftover[len], line,
                        sizeof(console->leftover) - len);
        }

> ---
>  drivers/net/ethernet/cavium/liquidio/octeon_console.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_console.c b/drivers/net/ethernet/cavium/liquidio/octeon_console.c
> index 28feabec8fbb..076e11f7cbec 100644
> --- a/drivers/net/ethernet/cavium/liquidio/octeon_console.c
> +++ b/drivers/net/ethernet/cavium/liquidio/octeon_console.c
> @@ -247,8 +247,7 @@ static const struct cvmx_bootmem_named_block_desc
>  					struct cvmx_bootmem_named_block_desc,
>  					size));
> 
> -		strncpy(desc->name, name, sizeof(desc->name));
> -		desc->name[sizeof(desc->name) - 1] = 0;
> +		strscpy(desc->name, name, sizeof(desc->name));
>  		return &oct->bootmem_named_block_desc;
>  	} else {
>  		return NULL;
> -- 
> 2.15.2
>