Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 17:13:36 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     yang.yang29@zte.com.cn
Cc:     christopher.lee@cspi.com, davem@davemloft.net, edumazet@google.com,
        kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, xu.panda@zte.com.cn
Subject: Re: [PATCH linux-next] net: =?utf-8?Q?ethe?=
 =?utf-8?Q?rnet=3A_use_strscpy=28=29_to_instead_of_strncpy=28=29=C2=A0?=
Message-ID: <Y5INMK4YaZAT2syD@corigine.com>
References: <202212081952034833496@zte.com.cn>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202212081952034833496@zte.com.cn>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bHPPWsGne9Ixmclqe5cOzwGpVB7S93aGYVVjgj+WTIhUfSJg9mq2cI28iCzZ?=
 =?us-ascii?Q?RGDnmMskVvt/P32iPilo2PZ0CBISRU7hjVAJFJAhc+kAj9Vm+OMMsHrh6vPh?=
 =?us-ascii?Q?cBkH2CZ5LgDRcNpQ+oPSqttvsNS3tzboRIlI6fGY2hM3znp6HG8Efno2wySd?=
 =?us-ascii?Q?1gmVfBPm5dvfAa/5rplhZrpv+Kvon91I7KbjIPAuXy9YbN7yCJUcSOrzjvc9?=
 =?us-ascii?Q?O+tjqCw+TVE9gS9BWD0YDStmOQC5CaxrdSpTHjTWprCwxci8aqkT6dBNSsug?=
 =?us-ascii?Q?ueICidA7yXGUMRp02Oct4hxafiKek/v6BxSs4GxWHxwnIVARELz+PgSRVjHr?=
 =?us-ascii?Q?spGOE4VMAEFXJxizXJZdAESdTm1S5GMQQNI5T1xO/8OGKfirN3BGYTk9it0d?=
 =?us-ascii?Q?Ic2/Dm9puLc0Nauob1xJ79np6jVJjiUlfnqIR19kbtxXn2ICfzJTxhH6KSKI?=
 =?us-ascii?Q?cumFjhkdISba8+KCiyH6r+6JA0NUxYQoWRapGULtF/OjLR0oE0YxYa9oyhy8?=
 =?us-ascii?Q?MNLYqfl5vkUgl0F2aEc6DkK4vk644k35VJVUNqMeGCPRRvc8ilTiZWVFfb9J?=
 =?us-ascii?Q?qwf1eR4CpYWzYhu64e/hd8zA47xiQ+2lY2wzNL6/abBgkYZeMJCK2gi8adY/?=
 =?us-ascii?Q?86KXK4TptSPFBV8UkBRE8NjcftpvBVa+Y+zvkTxnFkgrsNsujcT/cburRC0m?=
 =?us-ascii?Q?CnQt4nK5UvC1n7XeX21MlxjASp2QFReuX238RqwhRVYBHtohQVNeIpsPVOgp?=
 =?us-ascii?Q?6TjIN0eA/6GC9UXhUVwDi4EACFjeVWOjjD04FPTPGG5bgdbFGFfy7mbuL0zv?=
 =?us-ascii?Q?Njbd5wtzj+8j1IKkHdZacPjV6h/IzUVucY2ySJGUNMtM46jVHd7wgvuzX5JE?=
 =?us-ascii?Q?SBT41Yah7bLu0US89HZDRpz3ELurAPZpYTZcSpiixKsuUzwCQsMxy7rgVFcZ?=
 =?us-ascii?Q?Ne+a5htrY7GWm0o7xDSqQkn0wXZBNq+I4sQ37Jb6A/xn+4KUsW7zaS0i/vh7?=
 =?us-ascii?Q?1d7/RAl4fgAADiqtqshRCvXP5MhOCOqDgVa4LfXHg8mMM+1HIU4pTgDOqpBt?=
 =?us-ascii?Q?8QJN2L4EIzl4GPF0pdXRKOTLCcIws8MOh6hTHWHByRgX7w/catgH9xWedql3?=
 =?us-ascii?Q?HdfuXvXFOQHyPYXI3l4DROy8KLbyL8LTPQx+qN0ikGnwllu0RI8BO1iLkO/B?=
 =?us-ascii?Q?phFReO/e4+vlZ023TaB1znkU+XgQxPowc8l0tNY6mU42hoTDFs8jVxuEtom7?=
 =?us-ascii?Q?IKq74T59vZmlPTX49T5Kp80AvgQSBkQPp0CSNX+pO/NRTFYHmEJ/F/O8Y3hI?=
 =?us-ascii?Q?FAkd4sB/LfcQ07+Sh18ZtkecOG4OPVeV3ikz0oYJu1m3ud/FzJrPes9NLll7?=
 =?us-ascii?Q?XT4XvWH8OOHkO20CP0xcqG7Zp5ab1cqq/8GJ0Sc8DLSIK2ZZ2tGzbj6Z9OIa?=
 =?us-ascii?Q?P+F6kKyuFEl5HQ/A/DjnxS0rIa7f9FCPhbgOzgiynuyXCpmO/mJPRCujADUH?=
 =?us-ascii?Q?/T/siDwJnJ0NxRwgtsdGAx4Yh80kCsEM1F93KkYvJAa9rFp0IfrIpqNo0AaX?=
 =?us-ascii?Q?TGeD3FyWMbFqpQthdI5T4elwWjULyiaAlF8/b+mKbGVMtcFfy10wJeG03/VC?=
 =?us-ascii?Q?/lLohY224FksWfYZFDhr/4MEuEhzSiSA+uR82pN2iURFqZxQZmuPv82gXPsm?=
 =?us-ascii?Q?O2jEhA=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d08fa7d0-9de6-4371-ba4a-08dad9372c9d
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 16:13:42.3184
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: wbAxVwJgrap0Uck1kvUXtK2NKNOV91lMj1oUcaeNSCi5WeXugqVmgpjUcCuNvMQWapDyS9OrsfGKCVhtabRgfm983v9+G0f41OQaIAk9hBA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3694
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Dec 08, 2022 at 07:52:03PM +0800, yang.yang29@zte.com.cn wrote:
> From: Xu Panda <xu.panda@zte.com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.
> 
> Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>

This change looks good to me, but I think the subject should be:

  [PATCH net-next] myri10ge: use strscpy() to instead of strncpy()

That not withstanding,

Reviewed-by: Simon Horman <simon.horman@corigine.com>