Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Frank Li <Frank.Li@nxp.com>
To:     gregkh@linuxfoundation.org, Rondreis <linhaoguo86@gmail.com>
Cc:     balbi@kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
        imx@lists.linux.dev
Subject: Re: [PATCH] usb: gadget: Assign a unique name for each configfs
Date:   Thu,  8 Dec 2022 11:53:23 -0500
Message-Id: <20221208165323.3520326-1-Frank.Li@nxp.com>
In-Reply-To: <YxiHE9s4NDZOILpe@kroah.com>
References: <YxiHE9s4NDZOILpe@kroah.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?g4nUL9minGzPDznPvhmnCZrCwrrXBUKUBYlaO9yXpZ2/XWBq9Gh5u7DLMDI+?=
 =?us-ascii?Q?pFg28zNPcu2WU/zOAeqDYub0tl5QB6zkY50zCbbSTjqPKC3n9eXBexkxgXHh?=
 =?us-ascii?Q?URfUnZocDFRwr1VKqqo1+HFTJZe2Qz+tZbR2rFakdC9W0IQ5UNw9EUySG9UP?=
 =?us-ascii?Q?z/F7cgzja2P58E9VMjTzHQvQ39I5UVtoqZA13CO6jO7GivNqZxq2gC8uB4hK?=
 =?us-ascii?Q?sLij/Zxg8/4MfGGqU/YBB6zqfTFbgMIfyF+M+U6YqRzpa4npp0W1Tds5NsCT?=
 =?us-ascii?Q?UXQ8tEckXDZohOwndRAbTW+XfeAoFBqme/nmxJHkPXzzE/IeCb60Z2AOp0Ho?=
 =?us-ascii?Q?OgQgPD8ypGwEvmuzogszIMG2WGJSyDUHvD4lx2eyVKtlt2iv0eK/zfxrIRn6?=
 =?us-ascii?Q?wXxc84xOFR/8ARzhBI4OtvuipcLwoYwg+wDQrl6HUH2C/Kj7kzu9uly5Z8Hf?=
 =?us-ascii?Q?oxtqlRvkvv+m9i2Pju6w7QCRiIkfr0MCRTv+mNKG7IwewqWe8/oKmD46snN7?=
 =?us-ascii?Q?XAeI3sBpgYAotB9kPzfcSYwor4IlzKzeYAdlCLxfpNGdOEYkSH2uLtVQv54p?=
 =?us-ascii?Q?CCA82spbQ2Uh0Qr1XhUMvvGzE3fIszbKBY1YVVLN8dB2n+34KIjZM1447H1i?=
 =?us-ascii?Q?3cij8H2ars1jRlxAscegpsb8ZOd4vuywpItOe4r9WzZ3mipRgm+XWAW5X/X2?=
 =?us-ascii?Q?DqET/IOBMdWOU/2sBzMq5Um7TcSb6LzYrY8AreI8TNYS/hIzyGZINwJ16nGY?=
 =?us-ascii?Q?TsZ2kr/trrgUPnyobGHjS+rYaCiPFUsoEy0TOOqXUH+KSuFNsDCawRL3ojCY?=
 =?us-ascii?Q?Lnj+7AkeVy+T54Dxlkwtg2OPaQ7CmX3mXyneyLUL6jvPMS7PJ0EeB1HtriPy?=
 =?us-ascii?Q?71dKMb6Ebc+plxppAv7NUuERisnlWpxjd2zcnXe4g8kSSQSYmhVFGt76gbcY?=
 =?us-ascii?Q?QdL11h4Q0ZHY1bUw72V/kgTHDuDY43lhQPnb8Bfhf15ly8Dm8XRmoUCqBHNi?=
 =?us-ascii?Q?LKZVQ1M5HK/Te7VppuajR6l5N6B1bRJ02EPCYDLA0D75iWjUCjSoWiOrW+J5?=
 =?us-ascii?Q?hZhrXZAeDXAbnPfOVV3/o7CcpTprOLs7pYEGxzQPrn+oxRX4VOTT6HZY98Jr?=
 =?us-ascii?Q?SU/9P5YTPyw1QiAnzXb/MDlVhMOgTfOeQoaJMXPJL+FMBWwpZgOGc/tIJjXO?=
 =?us-ascii?Q?pYv2sUS9hF/+h+2U/quXqV2LWdSs+/H/AVX7UnD4YeN9M1Q1FgX3g0ml0KaF?=
 =?us-ascii?Q?8Q7LZR3yGvo//vjhccljoYRaTqM6HrsUYaGGQTOdXvM31LLt7nsLtYSfuN+W?=
 =?us-ascii?Q?IwweWt/N9ykVNokHPsM8mr5J0jPUIWi+MZMf1ajmokRnIw1+ZHn5Qi+t+aS3?=
 =?us-ascii?Q?pZZEFl2qWFL17S07VHKD+97fi2SGcnJ/5lfgaR5i2JaCfJKaS6tbsA4dw+LW?=
 =?us-ascii?Q?Gek7mnMD9MZPSitva6mQBXyaonKbgim5/jZ8ZkybctZontEfeubHO9Fmhbe7?=
 =?us-ascii?Q?ai+ouIRS2ATNv10zI09AWBHrxBCKpfmMCqpiCmpY+na8kTqC8sv1AxszO7yY?=
 =?us-ascii?Q?x74RrR9Xx5u1mVKBFcZnOq3yQhDS+QAX1QW9jIDZ?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a372911-9d74-4eaa-47ba-08dad93ccb3d
X-MS-Exchange-CrossTenant-AuthSource: HE1PR0401MB2331.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 16:53:58.1307
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dzbZ1tqeg2oJU3qKMjGnnurfx2dWV0EMb2bXHl24Za+/NLAJEi8762XWPMqp2YDv9qO1APwURTkvFJQMg/Bd7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9642
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Frank Li <Frank.li@nxp.com>

On Wed, Sep 07, 2022 at 01:57:07PM +0200, Greg KH wrote:
> On Wed, Sep 07, 2022 at 07:22:10PM +0800, Rondreis wrote:
> > When fuzzing the kernel, I couldn't use configfs to attach more than one
> > gadget. When attaching the second gadget with a different UDC it always
> > failed and the kernel message said:
> > 
> > Error: Driver 'configfs-gadget' is already registered, aborting...
> > UDC core: g1: driver registration failed: -16
> > 
> > The problem is that when creating multiple gadgets with configfs and
> > binding them to different UDCs, the UDC drivers have the same name
> > "configfs-gadget". Because of the addition of the "gadget" bus,
> > naming conflicts will occur when more than one UDC drivers
> > registered to the bus.
> > 
> > It's not an isolated case, this patch refers to the commit f2d8c2606825
> > ("usb: gadget: Fix non-unique driver names in raw-gadget driver").
> > Each configfs-gadget driver will be assigned a unique name
> > "configfs-gadget.N", with a different value of N for each driver instance.
> 
> Please wrap your changelog text at 72 columns like the documentation
> asks for.
> 
> > Reported-and-tested-by: Rondreis <linhaoguo86@gmail.com>
> > Signed-off-by: Rondreis <linhaoguo86@gmail.com>
> 

I met the same issue, do you plan continue this patch after fix greg's comments.
If you have not time, I can continue it. 

Frank Li