Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1395282rwb; Thu, 8 Dec 2022 10:04:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf7Fo+qg8otRBRiLQEZiQ901oLoMotfAPVtmJ3rC6jmIFRH6pCfZW/osYXkR++0YWzn1P4YP X-Received: by 2002:a17:906:2e83:b0:78d:b3f0:b5c0 with SMTP id o3-20020a1709062e8300b0078db3f0b5c0mr82300106eji.141.1670522670862; Thu, 08 Dec 2022 10:04:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670522670; cv=none; d=google.com; s=arc-20160816; b=trHRNS1K/QqMUJw6svms+mtJZ5US4tJzFHWWES16lyJSW2KmyBeP8j3YNSwN9CS7/Z rKtZphvAuHdUpfRe8Z7zoSF78A9J94Elk0eFZbB+ny6+wCu5jMH0ZV0w8fg3njHwajat sMoqYYOQamF4lkJIDTknCPYTWkFlamuKyEpzQDhWTys2M3UEnU5dyaQeC+O0PX1VyNDK kCn0mWI34QGz9PfaJenDimkQUvkdgx4Q6Oc/OgS1wvyh7meM3J6N8XJSnJ8prVTM4qi5 i47I4dP8ZaibmLddvEDUtq78kpuB0YNDHByBQ9gIlcy3c/dWhiWtaYbDAtWA34a8n0zx bBlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from:dkim-signature; bh=YGASGdT0r7NnaA1e4kT6G5JiKwWgMW8ILoizErp/fuA=; b=bIOw7KmYEhX4Tngs3i2wSrdS7kkFA6FgLjiAKfXXAqj75gPrtTJC2BocuPQZIGNUvZ BppTn1YVDBCxiQv1zrLanwZ+G0+cxT1LKWnnwKgK5ifE0aAtoNus+6ZZ1TuqQeyRhoKG KgHA3mxsnyPbJTl5KantlVo2EEwLC+HKycBp8k5Yv3npcE6LpfWYMnzdCMNvz7A5zcHN k5n61c2djHamYKAyj2rsQ+XLSTeazgXaBsmSnjk0bLS1LKTtKAXu8WzhYa7f99p5SVYk Hzx7LNC8R3F1j/wN7rrlKT2ELGwYiXFr2U3y4EpTb+0P8d4RP+RSrk/9zTkixLu+0VVQ dc+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=3cTmyGd7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e6-20020a056402190600b0046b2aaf7544si9214648edz.398.2022.12.08.10.04.12; Thu, 08 Dec 2022 10:04:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=3cTmyGd7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230317AbiLHQ1Q (ORCPT + 72 others); Thu, 8 Dec 2022 11:27:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230210AbiLHQ1F (ORCPT ); Thu, 8 Dec 2022 11:27:05 -0500 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E15F973F52 for ; Thu, 8 Dec 2022 08:27:03 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id j28so1059518ila.9 for ; Thu, 08 Dec 2022 08:27:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YGASGdT0r7NnaA1e4kT6G5JiKwWgMW8ILoizErp/fuA=; b=3cTmyGd7FiNaOd4/sthMFl990S0QTtP747E5NX3mtjTVd8iTdTnwR3pgcy/Qys0cO9 faIqpdtoDWkJdKzd6wVT4kaXnz7ODbkhdWHZ27ATrsdgYcYqxV5K9JkSEivflyXztXXZ 981U95OZZptesAhsvqD2D/kjcv0L0l3oxa8T7oTzk4hrRunjRckDcu+wAdA5UcanTc6p /jE1RH9RYBN9RCFBB4OJhSa19D6fGkEzRTO9DIccojqIVoiyQhj1GETx0KKUz12wuP3D bw7/TYwQGv4Zhwcgt88TAKQQxFEoGfwl3CDKVxjkuFgNu0vW3bi+64K7MXcwE6Zs19LW rduw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YGASGdT0r7NnaA1e4kT6G5JiKwWgMW8ILoizErp/fuA=; b=QNWrBPYwBQLjuEZfAoOCZUvHlRgSLurTmEIFySMcuIC63zI3uYNhl0iteu1O78Gno9 V3jUKVfbLVngHiwHbKAUSQ8RuzlNulHVOKmDSUOZtiNT9bPuY9OvikDebS71nrN5TGv5 wUlnMKYK328lnuJ6RidMl5VFIGjm12Zw7PpjrGZ42vVyvOMZixO79dMp0B6jTXuw14XP /PG0Djnn/3d1siaD3yxLujaStBCm4sm3dpmcDlEaHg8tOEeEJSDGXKS8gb4o2EcJuc7o g9kpGZkPgShazhxUfYQpn6T5DuX47KPQ3e0+vwEmDFB/q8NJy9YmQ0TYtNFL3HUvUNiy 8fTA== X-Gm-Message-State: ANoB5pkz1hqWtzQQSpAiRUaB16+eQi21NPY6Tmc59Kx/TmZM5ECRLtIN MklRwyQa5j0rmEKI7E9lYdwpWA== X-Received: by 2002:a05:6602:2109:b0:6e0:194a:4f47 with SMTP id x9-20020a056602210900b006e0194a4f47mr6359294iox.134.1670516823258; Thu, 08 Dec 2022 08:27:03 -0800 (PST) Received: from [127.0.0.1] ([207.135.234.126]) by smtp.gmail.com with ESMTPSA id l10-20020a92d8ca000000b003030d8b3cb7sm882758ilo.42.2022.12.08.08.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Dec 2022 08:27:02 -0800 (PST) From: Jens Axboe To: rostedt@goodmis.org, mhiramat@kernel.org, acme@redhat.com, mingo@elte.hu, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Jihong In-Reply-To: <20221122040410.85113-1-yangjihong1@huawei.com> References: <20221122040410.85113-1-yangjihong1@huawei.com> Subject: Re: [PATCH] blktrace: Fix output non-blktrace event when blk_classic option enabled Message-Id: <167051682259.135565.3126267294037734458.b4-ty@kernel.dk> Date: Thu, 08 Dec 2022 09:27:02 -0700 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.11.0-dev-50ba3 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Nov 2022 12:04:10 +0800, Yang Jihong wrote: > When the blk_classic option is enabled, non-blktrace events must be > filtered out. Otherwise, events of other types are output in the blktrace > classic format, which is unexpected. > > The problem can be triggered in the following ways: > > # echo 1 > /sys/kernel/debug/tracing/options/blk_classic > # echo 1 > /sys/kernel/debug/tracing/events/enable > # echo blk > /sys/kernel/debug/tracing/current_tracer > # cat /sys/kernel/debug/tracing/trace_pipe > > [...] Applied, thanks! [1/1] blktrace: Fix output non-blktrace event when blk_classic option enabled commit: f596da3efaf4130ff61cd029558845808df9bf99 Best regards, -- Jens Axboe