Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 19:36:04 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc:     Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>,
        Andrew Lunn <andrew@lunn.ch>,
        linux-arm-kernel@lists.infradead.org,
        Robert Jarzmik <robert.jarzmik@free.fr>,
        Haojian Zhuang <haojian.zhuang@gmail.com>,
        Daniel Mack <daniel@zonque.org>, linux-kernel@vger.kernel.org
Subject: Re: PXA25x: GPIO driver fails probe due to resource conflict with
 pinctrl driver
Message-ID: <Y5IulKoRctcrWBzl@probook>
References: <Y5B4QeNMNboJ42n4@probook>
 <Y5CxBzy47Gjn/V5a@lunn.ch>
 <Y5C0F/o4JS5MwkkJ@shell.armlinux.org.uk>
 <Y5DDCmXnamC6Zikx@probook>
 <Y5DbKNI3e+tFA++1@shell.armlinux.org.uk>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Rc/mWC0E3+AOr2MX"
Content-Disposition: inline
In-Reply-To: <Y5DbKNI3e+tFA++1@shell.armlinux.org.uk>
UI-OutboundReport: notjunk:1;M01:P0:cbYmOp7ZiqE=;lw4M7yo4Pj3NBk/nY/2eEMc/LM6
 rSe4mFIYzQW5LyW03vj6HqpLGHblh7ouZn1b4uCpyEJrR69yyppl2/3Gb+R2ztjhzW4lD+6by
 Q7mBO5tRMBjuP3A/RHJWyKrBXq1fvsVJIDO+3MIBO8Vw4Yhry2EnNxDHTQ8bE9ZqsJzPOW/Wj
 Zv9K4UynPINkjV15f3O3Pb+sZoGzTL9YmLm6kMafjaC2AnaVKFFfiVuk5gz78Eed9n0MBPqNq
 jT2jp84PnuxBQ/8QY++IZHL1c3TD826Q3XT6rb6nO1yoO/DBY6P3JSzGf7je3DZLndSAD/cda
 1P42d9hUKOGJM1gPJWk2aTsxfp65sOj07kyYwGMuGQTNZiqxRHEyfWCnp5I57G4kajy3wyy2S
 z37R2DUs7Xkss2uK3Izczh6XN8CfAAU8F7dQZxFowAh2TsNM9xMPXAAn1GlPFL+AtBcwxSDXk
 aQn1nvO0cDUMQgjzhENS34g+CEcnDk0JwO60eZtDASO9KAjab5zzCzHO6r95ZqCzQLVQwNyKZ
 emdSAtgH/WmVKq6+ba3pWjrH3Xo4SMAtaHX8kYz4LpAsoPDOaktKsK+f/13Q5vTumV5SpD9/k
 dVs+h3q2N/b3ymcIRoUa95BtbDA21iFfrJ/RLs/+vs8gqY01LvKE3uZT8f7UE/O91YJasyVQA
 aaJjzM866LTpINcxGQo7Sutr08mwttoReMMfwyqo97uXed4ZYGpE3b4W38RimA9UoEP3jYkUz
 hhqz/BNCM0J/P7pCBdtd1yoPoX697qMtNlbW9lXZ2bantao7yg97oICY4GPLev/0RlVf9jPLM
 Y9Pnl7sTBzVxGZES5lIxOlv2Aqrt6GxsCChrgA1je56Aicgs0ux0gWttCJzNoLgiWBSBO7fxT
 T6WPoa+P0GpA0bZ3URBPLWH1q6LPB4603Xax1T2EM6o4me730Yj3Bz38DEjQl3nBikOMtOn+f
 hDGSXQ==
Precedence: bulk


--Rc/mWC0E3+AOr2MX
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 07, 2022 at 06:27:52PM +0000, Russell King (Oracle) wrote:
> On Wed, Dec 07, 2022 at 05:44:58PM +0100, Jonathan Neusch=C3=A4fer wrote:
> > On Wed, Dec 07, 2022 at 03:41:11PM +0000, Russell King (Oracle) wrote:
> > > On Wed, Dec 07, 2022 at 04:28:07PM +0100, Andrew Lunn wrote:
> > [...]
> > > > How are the registers arranged?
> > >=20
> > > As documented in drivers/gpio/gpio-pxa.c - it'll be easier for you to
> > > look there rather than for me to explain it - but suffice it to say
> > > that the pinctrl registers are amongst the GPIO registers.
> > >=20
> > > > Is 0x40e00000-0x40e0ffff simply too
> > > > large, and making it smaller would fix the issue? Or are the regist=
ers
> > > > interleaved?
> > >=20
> > > They're interleaved. Looking at the .dtsi file for PXA25x, it seems
> > > that the pinctrl claims just the addresses that it needs, but the GPIO
> > > controller has no reg property in the .dtsi, so I'm not sure what fil=
ls
> > > that information in.
> >=20
> > The GPIO reg property is in pxa2xx.dtsi.
>=20
> Looks to me like pxa25x should override the reg property with a smaller
> range (0x54) and  pxa27x probably should have used a second set of
> entries in reg the subsequent group of 3 gpio blocks at offset 0x100.

Without further code changes this wouldn't be sufficient, because the
pinctrl driver also touches the GPIO direction registers at offset
0x0c-0x14.


Jonathan

--Rc/mWC0E3+AOr2MX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmOSLnIACgkQCDBEmo7z
X9sDcw/+NOGItwyuFjYli1yeq2yxp94FYbLj2r8Y8GQKQBAecd8TVbVKGS0S/FFI
o7udq8vqtWuPzomlglonHSvRNLW2RS39IjsPnSsWz6bb6SvGSi6jfeeEJuyCA+yV
foifZI1H7crTIRyGaDpYFsZSfh3JIhLMxmLPf+AYctvFDuldqlY0XHfLPWqKZhuI
Cs6Qq8XPL4IoNDKdfZpRGMA6AkEljogUqkOl6d7L/CR4aA6hb69lvwGIfPz4/psc
hQjbzFPx40iJ5fCqUz7TUhwtS3latC9v3XRRuuIKjJmS6fgbn3ftWaTwKFspgRQZ
Oy5SjDPuT2gIZs6Z6uZAi3v3q+wfGpsFE2sw9FUGUqMbikMQ7KR5ExOIiIxiJte3
2pAJ5ea/G4CbX1oi/o+wEpRfrd/memiyymbgKAyLhLnJAHRlG65rf8UbFSxeTZ8p
mT0MyGzUMwtuQTgeHxR2UP+N8FO8+ivfq+KVHfgIg3+7eKF2cFKIJLCPNHFegKDg
JlhbsPlPs+K76iljbOu/iGzNm5fgIUWhi9Q1XZzRPdBDrliCJekEXAMPsKk24WRb
c4FdDNOmnSB9v5hWNmyWytYq1m+SehufCejfNRMwK79T85kFXp6gTqa+cSlSb7Hd
kJIGYtAIlWhjVZv01h06N4pGIxBhXo4rG+Yym8u7ItBBSPNj6po=
=BF1n
-----END PGP SIGNATURE-----

--Rc/mWC0E3+AOr2MX--