Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e3153841-6a20-f175-8174-2efc9efd8dc9@oracle.com>
Date:   Thu, 8 Dec 2022 13:04:35 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.1
Subject: Re: [PATCH v14 3/7] crash: add generic infrastructure for crash
 hotplug support
Content-Language: en-US
To:     Borislav Petkov <bp@alien8.de>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        kexec@lists.infradead.org, ebiederm@xmission.com,
        dyoung@redhat.com, bhe@redhat.com, vgoyal@redhat.com,
        tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com,
        hpa@zytor.com, nramas@linux.microsoft.com, thomas.lendacky@amd.com,
        robh@kernel.org, efault@gmx.de, rppt@kernel.org, david@redhat.com,
        sourabhjain@linux.ibm.com, konrad.wilk@oracle.com,
        boris.ostrovsky@oracle.com
References: <20221116214643.6384-1-eric.devolder@oracle.com>
 <20221116214643.6384-4-eric.devolder@oracle.com> <Y5Bn2Y4ANWX0U89U@zn.tnic>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <Y5Bn2Y4ANWX0U89U@zn.tnic>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0ExaW1FSGRYRzhGa1A4dGlaSUhvdUdJeHdBR2NMUFE5a1o0U2dJWE9Bckw1?=
 =?utf-8?B?d3JtQ3ZWeHpOcnJ1M20vVWVxNnFuZ1BqdmJHN0JJRndrZHBTZlFWRFd1QXN2?=
 =?utf-8?B?ZlBpWm1iaUxNSU16b2FGOHl5SFdURVZPYmx1Zm5QMk10ZHpjenRaeG5NVk1L?=
 =?utf-8?B?VDVsazBoYWZONjZWSzQ1cXJ4UkhpL0hGanUzdXJScGp4WHl3WS9FSnZHUXpL?=
 =?utf-8?B?dnVRODZuQzVadkRybjhMNzZCRmIwWm5YcHNhbzljcUQzT1RvVG54aDdBeFhT?=
 =?utf-8?B?SjA1THFqQ1hhVmdrNzJNOHFORktIQ1hpRG1pVkdVbjQrK1huN2IwQzJ5S0ZK?=
 =?utf-8?B?ZkEyYUUxNHBhbitlSTdsbUdqWkloVTh6WWlsM1FLNmZMeDEyeFF5bkJNMDRS?=
 =?utf-8?B?UnJqaHhSeENhTzdGUUtMTnpKUmhDZGhLMmxaUkJ2VDBDSzFJMGRnWnM4ejA5?=
 =?utf-8?B?d3NMUU5kdEJxUFd2a3d0OWlGT3MxNHdhMkJubXdTM0c2c0xCNHFDRm5vS2FB?=
 =?utf-8?B?TUovVDZmUkllNDBVSWpkWUl1ZkUzSTEvTVc0aTgxYUVNWU9DWDVXcTNFV2xl?=
 =?utf-8?B?ZE02Tkg3V2hRZ0QxR1B3UnQ2eGdiTHVFTThoYVNIQ1JRUHgwZndhVlZaaWxG?=
 =?utf-8?B?cWxYL0daWnFOWGF2YmRGZ2tnNDcyOEptd21tdDhOYncrTS8rNW5acUZoaWxZ?=
 =?utf-8?B?NVBUdlFvZWVQQVh5L1ZNK3h0czQ4Y3pjZWJRamZxa0lubEtBMDZFNVlNbVU5?=
 =?utf-8?B?Z1JkNVhyMHBTeXNuaXcxNlFGdXdnT1AzSVN0ZjRmdFVYaUR3T2tSOENPckRY?=
 =?utf-8?B?bllBc050ZHB1d0FPUWVRV0xINGZDRmxQREZvNFRjYWp3UkZJUkRFOWZnd0xk?=
 =?utf-8?B?TmI1SWFPVmsweGptY1lYWWQvd3dNazY2UzhqcXV3aG5EWWt6bWFUSE8rT2hD?=
 =?utf-8?B?WFcwTlhFUUlmUkZEN241T1hlRWhKZFFHZ3hrQ1NZQWVzRHAvOEt3SjFMRVFa?=
 =?utf-8?B?ZlJjSlNIY0JIOHF3cWVVUy9oM3ExWTJsZUhqUHdEYnFQdkordnQwTlV6NjlY?=
 =?utf-8?B?ekRDcUlJQk5rcW1aVEpueC9TQ3luc1F5aXB1YW1DZ2x0M3hheUdIaXJTUmFy?=
 =?utf-8?B?RmZwdktjaUVvd1JNMHBySzhBY1pyNmxDSG0wNENhR3lBQ2xLbUlwUlZmZi91?=
 =?utf-8?B?REtseW4wQjFKNVhuZmdYcElZeVdveFJPVGIwTTFjYXQramRSK1luaWh5dEtv?=
 =?utf-8?B?RzJtY25mN1dEUTYzTWFuOWV1c0t0ZFBVQitXbmtpVGxqVWpLT3NmMFlkdkxD?=
 =?utf-8?B?WU11WXAwNGIzWVg0QXNGWjNxQnJpd2pFcTFjNDRBU1dqbDAyMnhyQWtRZnVE?=
 =?utf-8?B?QmZ5dUpzdnIxQ2lXeGZFQ3h5WjVPSTNoemY5QzF3dHV1VEJkSVVXWTFHclJX?=
 =?utf-8?B?ZHRZUUNJOGFnazg4aVpRalZXQWRtcktQZ2JiaVJhdTdHdE9LY1RjMHZUT25v?=
 =?utf-8?B?b1cxSHRGZkQrTDQrNG05Mzc2M0EvOTF4NUJzdWtqcWpWQ2xGM2wzaGVXN1dU?=
 =?utf-8?B?UDZEN250cG9mY1Y0Sm5CZmZOSGJ5aDRTZys3QlAxcnFnam5wQWNUUm93Y2RP?=
 =?utf-8?B?TUNyTzFNNEh2NnJ1K21hQTBpZnlBWnBpb3lMMEJMdDZCamdZRy95Nnpid2JR?=
 =?utf-8?B?SkJOWGpLRFZtMElsQmVOeUJ3YUlxRmN0S3FWdmZ6TEFpSFRQOTQ4YVdEMFph?=
 =?utf-8?B?NW9jTEZjUnlTTzhKSFZaUU5EN1NnWGN4bGlIcTFSRDhpZUdWTFQvTCtITGZR?=
 =?utf-8?B?RS9zNFN2UUljVFI4cEt6WnBBRGlMSmFOZ3lPMm1xNWU2UnBlSlIxa3dkQ3BB?=
 =?utf-8?B?RnE5d0lVaGpxWngrL2NyWHZaSGthT0hVTGM3eERuQlhYSW9uRTllbXlYWGp3?=
 =?utf-8?B?THlEYS9OSHpDVWtRYzVMVFd6SEFTdS9oUE0vMTJnZUVWbEI4Ri9kRmlLY2sy?=
 =?utf-8?B?bHJGdVRTTGYxUGI1blFmMHVFQjZ4Uzc4ZFAwSEw2c2JxemlYWHdUVXF3MXg3?=
 =?utf-8?B?aXZwR1c0QnpqR2w4Z0U1dzZBTjExQm1MZC9vS20waFBjTVhvaXJvSDkzdGhB?=
 =?utf-8?B?SnNNN3dWRXJQeEZuc1BEY0JvYms4NkNzTjFOb3hmL1NxNGIydWlPb3FuTmU1?=
 =?utf-8?Q?1HV9p/MiT0S1UEUzb5fadCA=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a7d0e11-c90a-4f59-560a-08dad94f1033
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 19:04:42.8008
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gD5CNT/v+/rjPJnSZfkvhWEtEayShYBOHKAS6vhDWmThhcGvYRGC1kNh2vML/OuTYJdZpRA8/0YVne0niybx0mOkKf2T72gNQszdzqLeKQc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR10MB6233
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-08_11,2022-12-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 suspectscore=0
 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2212080161
X-Proofpoint-ORIG-GUID: -jjCjWzYHmCXCzDoesPV9ZgkG3f2qejy
X-Proofpoint-GUID: -jjCjWzYHmCXCzDoesPV9ZgkG3f2qejy
X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/7/22 04:15, Borislav Petkov wrote:
> On Wed, Nov 16, 2022 at 04:46:39PM -0500, Eric DeVolder wrote:
>> +#ifndef arch_map_crash_pages
>> +/*
>> + * NOTE: The addresses and sizes passed to this routine have
>> + * already been fully aligned on page boundaries. There is no
>> + * need for massaging the address or size.
>> + */
>> +static inline void *arch_map_crash_pages(unsigned long paddr,
>> +					unsigned long size)
>> +{
>> +	if (size > 0)
>> +		return kmap_local_page(pfn_to_page(paddr >> PAGE_SHIFT));
>> +	else
>> +		return NULL;
>> +}
>> +#endif
>> +
>> +#ifndef arch_unmap_crash_pages
>> +static inline void arch_unmap_crash_pages(void *ptr)
>> +{
>> +	if (ptr)
>> +		kunmap_local(ptr);
>> +}
>> +#endif
> 
> Why is that function still here and why aren't you calling
> kmap_local_page() simply?
> 

Corrected!
eric