Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 13:22:04 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Fan Ni <fan.ni@samsung.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     "alison.schofield@intel.com" <alison.schofield@intel.com>,
        "vishal.l.verma@intel.com" <vishal.l.verma@intel.com>,
        "ira.weiny@intel.com" <ira.weiny@intel.com>,
        "bwidawsk@kernel.org" <bwidawsk@kernel.org>,
        "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
        Adam Manzanares <a.manzanares@samsung.com>,
        "dave@stgolabs.net" <dave@stgolabs.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cxl/region: Fix memdev reuse check
Message-ID: <6392557cc0aeb_3cbe02945b@dwillia2-xfh.jf.intel.com.notmuch>
References: <CGME20221107212232uscas1p20a000834b76db7a7e459708b06638120@uscas1p2.samsung.com>
 <20221107212153.745993-1-fan.ni@samsung.com>
 <63699774d1af_18432294b8@dwillia2-xfh.jf.intel.com.notmuch>
 <20221207001852.GA2414318@bgt-140510-bm03>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221207001852.GA2414318@bgt-140510-bm03>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GoAquaqOKp1WE4KnUs2wAL4z2T/uhmKcJF7EDhn2x6uTiJMFMywSF/NNjYo+?=
 =?us-ascii?Q?ISHUd7nFxGe6kBOLA7K/cCeTUbibtU8k1C1/ZwxaApbKcN5GODxnNUiYv2bh?=
 =?us-ascii?Q?j8+84uItax9Iyx3Fac0XxMkENJidKg1z+af1Jzqy4TOm2OuIRdinXX+s5E39?=
 =?us-ascii?Q?uo25jhQrZlzvEIAGcatxHLLOUHEupP3PJjorTmGq5aFOEGem4LlAotfrRqrN?=
 =?us-ascii?Q?5dzHy7F2ARrZZhfowUVoJrJ0nDpiIQcuhG5lWlRbugeJG7uKwsjklwZGjfhJ?=
 =?us-ascii?Q?0/XBnanYoayUvcVsSdpw/DpK5v+sWMR7Y+jcmvjqBNL1RI0Ra9PG34xsSU7i?=
 =?us-ascii?Q?+6KmaWxg7w9VSyGbf0M0drS2bEKzPBhmPuCRyvkQh+eMDyl+WFYt4Rz+MX7L?=
 =?us-ascii?Q?9Z2pD48dPCeSEYxE/V7D87ivk2W5QUFF/QkB6ogEqzumF0aXUshYEw9eLo7x?=
 =?us-ascii?Q?kkfqeG9m5T1umcrRtRAZm03tzrhf2QLCwr3UgllQke7znR9EWmAj9STnuiHx?=
 =?us-ascii?Q?S6xON48ypWY/i3V1+6Gw43BsY4eWPQ2VEvxTkHqEeu9iK6RTsp/JUB/z/zWk?=
 =?us-ascii?Q?0aHGpvg7zu7M6LCLCxi4FRAMytAV2KAVqu+I4zB2yQFGhixy7jq0N8tuOPjZ?=
 =?us-ascii?Q?hWxSKdMqhfrogwbUuw75lNAUpZ01xEUk1P+2xs8ywVCJ5jgeviI6+IjQ3Lw+?=
 =?us-ascii?Q?Rb3LxGFuY13iLSUUTlBqfecMssDVnin7JDDsAVN6Ziuk0C/Aub/uz5WKRYBf?=
 =?us-ascii?Q?6KYlk/cc+YHZkNXMDlQkONzDtQuRBLf5uVJhxIrSSE5A5l89zNEhtB8rp2+1?=
 =?us-ascii?Q?ODsrMUgjPGTTzz+e4m97/DAG+ttugI2jQ8KJFK3MzNM/cq05YAFb/eDWiupO?=
 =?us-ascii?Q?goMpCGCgRwsbGfNOBkH+fPAiIEiDblspsDjlm2IEeW5TTtlZ13XmNNlPbVzs?=
 =?us-ascii?Q?WoTAQ6lrkh+HqbzZ4YuimdGttRRqGH2HeEEXxE8MetbMi5kPB6vPYfUf5Slt?=
 =?us-ascii?Q?QB1WQfT0P+otclEzsqRVEENi+JHgYPuQlVq80caiirEJ17pkIbVCSrkqGkYP?=
 =?us-ascii?Q?LvpOpkLi7bcoZ0gEo0BfIAlLle+ooee+c82yLyEEUUD4AdouEKif+pRDoNuR?=
 =?us-ascii?Q?p5tW28lgETWlgS1GGOfjVGPE2k7LXfJZQK1C8nqa1uyXw/9C8ZmbT3r5fXnw?=
 =?us-ascii?Q?7x0q0NxljfK0JhtIR2NImWJoO89EMZi08edhexBwtNnjNIa9ECs7QTYriW45?=
 =?us-ascii?Q?20SYy5udBVGyoalWsImwraSSXTtI2j47krNzzeFGKTZyPqVVC8eJd4GMFvSI?=
 =?us-ascii?Q?q2PuVLb1FT2Gwfil7yhXPI9+WFfJh0CenosI3cZXJjPZwzBq5ZsRJbFDVhT4?=
 =?us-ascii?Q?XtmcmVCnqYYx6dS0cYmJrT2iKKadGJsxhRZmELiK3G8uVm4TEzMCbrBrM/K8?=
 =?us-ascii?Q?4TZniGRqtIBWwP39zwcq5YWsbi9bYB9ttd/wLs6KJC9n7aMjDpMMZ5HeO2b2?=
 =?us-ascii?Q?tw5mMmn00gFi8O4I78rztSTSdjM4xKWJgjvpiR6c14VgpQXFj15yIAa2xwRX?=
 =?us-ascii?Q?kspVashH2l/U3UQHBCWbSY/u0EEvjCjjD0v2Fr8dGitOiQl6PJcQ7wwHajXa?=
 =?us-ascii?Q?Fg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e86a8b0-e694-4f1c-389a-08dad9624271
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 21:22:07.3116
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kZ1CWdboSPfjO67rXozNOhJodOKnkV5Gzy7nOBFq/5x/7hQPsmYzIdJbkkL2qU9zQ0QSGUsrq8BftPAuSVn9c/G8U4vjFYclim2RjmFMixk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7926
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fan Ni wrote:
> On Mon, Nov 07, 2022 at 03:40:36PM -0800, Dan Williams wrote:
> 
> > Fan Ni wrote:
> > > Memdev reuse in a region currently does not iterate over all of the
> > > interleave targets. Fix this by using existing iterator for memdev reuse
> > > check.
> > 
> > Not enough detail, what does this actually fix in practice? For example,
> > if an end user encountered this bug, what would they see as the
> > symptoms?  I could probably figure out, but for bugs I should not have
> > to, and more importantly downstream OSV kernel maintainers, who do not
> > have the same context as CXL developers, also need that information to
> > decide if this is a fix they want to backport into their kernel.
> > 
> 
> Hi Dan,
> Thanks for the feedback. Here are more details about the patch, and
> I will refine the patch.
> 
> cxlmd_target = cxled_to_memdev(cxled_target);
> if (cxlmd_target == cxlmd) {
> 	dev_dbg(&cxlr->dev,
> 			"%s already specified at position %d via: %s\n",
> 			dev_name(&cxlmd->dev), pos,
> 			dev_name(&cxled_target->cxld.dev));
> 	return -EBUSY;
> }
> 
> Before the patch, the check of whether or not a memdev has already been
> used as a target for the region (above code piece) will always be skipped.
> Given a memdev with more than one HDM decoder, an interleaved region can be
> created that maps multiple HPAs to the same DPA. According to CXL spec 3.0
> 8.1.3.8.4, "Aliasing (mapping more than one Host Physical Address (HPA) to a
> single Device Physical Address) is forbidden."
> 
> The CXL specification allows a device to have more than one HDM decoder
> ("The number of decoders implemented by a component are enumerated via the CXL
>  HDM Decoder Capability register (see Section 8.2.4.19.1"). If a CXL device
>  has multiple HDM decoders the current code allows to create memory regions
>  that map multiple HPAs to a single DPA.
> 
> Fan

Thanks for this explanation I folded this into the changelog and applied
it for v6.2.