Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Dec 2022 05:08:01 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Lukasz Luba <lukasz.luba@arm.com>
Cc:     linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        rafael@kernel.org, dietmar.eggemann@arm.com,
        vincent.guittot@linaro.org, saravanak@google.com,
        wusamuel@google.com, isaacmanjarres@google.com,
        kernel-team@android.com, juri.lelli@redhat.com,
        peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org,
        bsegall@google.com, mgorman@suse.de
Subject: Re: [PATCH v3 1/1] cpufreq: schedutil: Optimize operations with
 single CPU capacity lookup
Message-ID: <20221208233801.s26awslkx6aloxyd@vireshk-i7>
References: <20221208160256.859-1-lukasz.luba@arm.com>
 <20221208160256.859-2-lukasz.luba@arm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221208160256.859-2-lukasz.luba@arm.com>
Precedence: bulk

On 08-12-22, 16:02, Lukasz Luba wrote:
> @@ -332,12 +333,15 @@ static void sugov_update_single_freq(struct update_util_data *hook, u64 time,
>  	struct sugov_cpu *sg_cpu = container_of(hook, struct sugov_cpu, update_util);
>  	struct sugov_policy *sg_policy = sg_cpu->sg_policy;
>  	unsigned int cached_freq = sg_policy->cached_raw_freq;
> +	unsigned long max_cap;
>  	unsigned int next_f;
>  
> -	if (!sugov_update_single_common(sg_cpu, time, flags))
> +	max_cap = arch_scale_cpu_capacity(sg_cpu->cpu);

I will rather do this at all three locations:

	unsigned long max_cap = arch_scale_cpu_capacity(sg_cpu->cpu);

-- 
viresh