Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 15:42:24 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 02/47] hugetlb: remove mk_huge_pte; it is unused
Message-ID: <Y5J2YLW6UWtowZDM@monkey>
References: <20221021163703.3218176-1-jthoughton@google.com>
 <20221021163703.3218176-3-jthoughton@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221021163703.3218176-3-jthoughton@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?s06ABgm+WqmENKB02I/NuCSoGBPxC3ef4padHFVlgJ4L15qKAFDkEHRiQgjj?=
 =?us-ascii?Q?+dcWzyQ3k7hi3WGw/KCG8OIosKWA+nrig2W0sDpvrmXV/NZ9WpivYD9SZZsf?=
 =?us-ascii?Q?kbfrvL4vQau2ph9oaSs5qyYVo4iGtTaNQ3lnmalch39vEx1y5xz6OmLwpA2r?=
 =?us-ascii?Q?ezFdCQ4hb0eXEVpLbxN+EI1oDYw9NIqTpEtfxDoIKqXi7mg/zIAzyYPzaBGv?=
 =?us-ascii?Q?vC9unvbH5yTLzzc+91z/iwC8+DhTQ046VnNnJDq1J/KKkPqyox+1Ta1r+HTg?=
 =?us-ascii?Q?OzEQQlk3eytIBuQ+WagR4itzR4CjLjU44NB5FRfxxf05FfD7zuqI3/FDexzv?=
 =?us-ascii?Q?bkrxV4mQ0bvp1QWarZDS6ChBDiowbd3eUrtxr1d9su2P5OeVYc+LMOyOWb2F?=
 =?us-ascii?Q?ndpiux19+Rt3OOwdk4L0fwEgnssLbO64+McBEXV479UNWZso6DlrRNhk6JEA?=
 =?us-ascii?Q?MBVuoNOZTRVtM7TF551Bju3/ELyTccEsQJ4QBzmZCWxJtpAknkD5cM94qKE2?=
 =?us-ascii?Q?mvnTLzN3FKAKoYuEqMG0UiVVIDQU+fCt9tzyK/G332Xqo0YxIhzoltqn+8Z6?=
 =?us-ascii?Q?5pOHM2/CZ7RCdURP3BFV1nexm+PFbHuotJ6Sn7SBp5idJ64HKf+fCV57wlOF?=
 =?us-ascii?Q?5ArvgeNr69ceEIxvdmyMusqHCWdUlJv/eTwDCObeT3QdWmcPVboL7+ovxRal?=
 =?us-ascii?Q?+x+MrdeyZQB0N+uwxaLk1Uj+bTD8owQfFtcE08xbwbRX5orChnEI0jhuwZfU?=
 =?us-ascii?Q?zCU0Wc0gumFUeRTpU+S+gG/kaB0H08bqkf7BGbfwQcR4QjE5m+ipQVwrpXFK?=
 =?us-ascii?Q?6CzQl2DyiXtkiAk0N0lD88DsyesryvXd+wVeXGPieittndoCvnZqc27NvNga?=
 =?us-ascii?Q?vl05a3C/Jva05zZl3GRrObSup/wjgD2JrfmjY/IMs/xfMuv8G7kgXI4GsrMH?=
 =?us-ascii?Q?a/DnEJ+e8AKAClNK5ht8N/qH7Xh/rsK+Qk64AEy+HWaHUT4W8s99oISLN6Sc?=
 =?us-ascii?Q?dTS9u7PTU1wpVqzWSay0BjtPdKAh89pArV7Sr6KqaFGbnR3tOJGWawHJutjb?=
 =?us-ascii?Q?KVH8a0KWy77RhNeDxG/M1KY8auPZYy+1M1TRGnjScEHI75iz2iv35O5Zwkde?=
 =?us-ascii?Q?Nw1Sp7VJ/L7fWMNJpmaoRIc6AeXGJN5X8Cd7AosCQavL5MeJQ70ov+hd3YGf?=
 =?us-ascii?Q?zv6deM9Z4X3Nx+Gftdo7oyo9h6HEGYDjK2UErRce6bi3wktQ2ZbbGFr1UoHw?=
 =?us-ascii?Q?bsrGLL/xb9k63QyROYcawkOALInuUlrQacCwqxauGbw2VLjCoisYbdoLIl05?=
 =?us-ascii?Q?rsmNvYcYzYofs0IahbRdSSVPO+eopCceWagLBeR3RtXy3ugzFRXJG+LbCdAE?=
 =?us-ascii?Q?RrWfHbxzO4HP5BckzDgVB4WkroDXOQ51NXeMje4sCldgoUBoQ+7sBsuA+wFk?=
 =?us-ascii?Q?pSFb0eXehfjUQvH0D1jWs8qdlfWODC7+HcOtQtf4toQztiXNCVsMGCVd3jfs?=
 =?us-ascii?Q?13M6SbquYSgi9JkWMRO6I+m1iwh8rYezaD8q4AtiIpPwn39uWUUlAecsXGYc?=
 =?us-ascii?Q?WvNwk/oT293um5d8MHOfIuO8Dj2wzfIfLx3zEzuJzwZQrBMrxd3qVb7WDvB9?=
 =?us-ascii?Q?Rg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a05731f-2f32-4fcc-7651-08dad975dd14
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Dec 2022 23:42:27.2196
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: URq7cKaDyeEOXRrZudtiGsjcg2c1cWqDmitHqUi2R6WPojKviGDCSYEc4B8NyDMbVs5LGdQh5H8wQM2mqTrsOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5693
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-08_12,2022-12-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=881 bulkscore=0
 suspectscore=0 phishscore=0 malwarescore=0 mlxscore=0 spamscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2210170000 definitions=main-2212080195
X-Proofpoint-ORIG-GUID: nHO8d5uJwwiuxsF1CaG7lnFyVetMWpMr
X-Proofpoint-GUID: nHO8d5uJwwiuxsF1CaG7lnFyVetMWpMr
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/22 16:36, James Houghton wrote:
> mk_huge_pte is unused and not necessary. pte_mkhuge is the appropriate
> function to call to create a HugeTLB PTE (see
> Documentation/mm/arch_pgtable_helpers.rst).
> 
> It is being removed now to avoid complicating the implementation of
> HugeTLB high-granularity mapping.
> 
> Signed-off-by: James Houghton <jthoughton@google.com>
> ---
>  arch/s390/include/asm/hugetlb.h | 5 -----
>  include/asm-generic/hugetlb.h   | 5 -----
>  mm/debug_vm_pgtable.c           | 2 +-
>  mm/hugetlb.c                    | 7 +++----
>  4 files changed, 4 insertions(+), 15 deletions(-)

Thanks!

I suspect there is more cleanup of 'hugetlb page table helpers' that
could be done.

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz