Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
In-Reply-To: <20221111223108.1976562-1-abrestic@rivosinc.com>
References: <20221111223108.1976562-1-abrestic@rivosinc.com>
Subject: Re: [PATCH] RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path
Message-Id: <167054299652.8453.17062801658432513942.b4-ty@rivosinc.com>
Date:   Thu, 08 Dec 2022 15:43:16 -0800
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Cc:     linux-kernel@vger.kernel.org, Atish Patra <atishp@rivosinc.com>,
        Guo Ren <guoren@kernel.org>, linux-riscv@lists.infradead.org
From:   Palmer Dabbelt <palmer@rivosinc.com>
To:     Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Andrew Bresticker <abrestic@rivosinc.com>
Precedence: bulk

On Fri, 11 Nov 2022 17:31:08 -0500, Andrew Bresticker wrote:
> The return to userspace path in entry.S may enable interrupts without the
> corresponding lockdep annotation, producing a splat[0] when DEBUG_LOCKDEP
> is enabled. Simply calling __trace_hardirqs_on() here gets a bit messy
> due to the use of RA to point back to ret_from_exception, so just move
> the whole slow-path loop into C. It's more readable and it lets us use
> local_irq_{enable,disable}(), avoiding the need for manual annotations
> altogether.
> 
> [...]

Applied, thanks!

[1/1] RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path
      https://git.kernel.org/palmer/c/e1ceb0964163

Best regards,
-- 
Palmer Dabbelt <palmer@rivosinc.com>