Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1822039rwb; Thu, 8 Dec 2022 16:04:00 -0800 (PST) X-Google-Smtp-Source: AA0mqf7an3sR8qEa+N5ZvMQPxvj00ImN4Y9VHPdPj2fyJln5URlJHFXJdpn0mroodTqjjGKBngz8 X-Received: by 2002:a17:902:ab92:b0:189:b3b8:6865 with SMTP id f18-20020a170902ab9200b00189b3b86865mr3436925plr.11.1670544240159; Thu, 08 Dec 2022 16:04:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670544240; cv=none; d=google.com; s=arc-20160816; b=ZaPMIpF+i619hNHS84FJi+o89DTxjJ5K8uZ18y8Qk7ztkNxaXvGJvrhDOEYEL6GSbM sPHH1h1/hqrzjSeNn37CDlzFaV6oY71tfpS82OQgGDpYShfTqR3eKWOS+kxV6TGA34aP zD2fjkBXO2P7A2op0faVlr54HaQNq3Wo+qQrL1XOU7fWOdxZ51METDR6CAe849GKufHY KwvQ4HqtfcBvIOii/gEbJEAXzSEKQYi66VMfiWm1Q5WNop0RzvVhDc13eBlYBhDTUknT NXlSW6FRRIa/CqO5hZPzqq8K6VTnNIkijVZb29kn5lNBOxHj7av062SKE9lYU7XGY+rl FdeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=X4TXKhNz7etGvAKMxErNJkr9CfmZIrdZ/EWpu2KKGOU=; b=zfVPIet3uP1rYw4zggnhL4xg+Jh11uzJNd3xcik2N6I6aYAsDPxkrMRsBeCgv6Hjfa am+jhGHJkO+N5W7UbvoUE9YzyWBmXwESkRRkXHkflGdXVdMrUFs0JZ9JRXWR61zGDmi4 V4RHeUo8m3HfoAyZiogVmYkXtcbCw3eiRnavNV0WbF1oU+ANvCEACDDlQaQMz6ZHQjpO XWu9V2g/goGkooV4YXUt+eYKGS8HLSBLBj38pg/Z1Nv7YjMJWYmGFmIVxF1wV+/cj0c8 +Yqsw7QymaObXQRtGvmV+OY9f4f1JEhH+UT9kdPKTd+eZz8D9uzG06Izu8jCmScrwZDT UTWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fGdZtnqF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a17090341cb00b00189fdf3b84csi1296ple.385.2022.12.08.16.03.50; Thu, 08 Dec 2022 16:04:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fGdZtnqF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229907AbiLHXuS (ORCPT + 73 others); Thu, 8 Dec 2022 18:50:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbiLHXuR (ORCPT ); Thu, 8 Dec 2022 18:50:17 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E77301C405 for ; Thu, 8 Dec 2022 15:50:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D571620DA for ; Thu, 8 Dec 2022 23:50:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id B9481C433F0; Thu, 8 Dec 2022 23:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670543415; bh=YEg/kqUiMcU5Qvfb4M+IRYn0TXWZlyRJBxtS+d/nXXc=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=fGdZtnqFz6beBEyysnoTt2npctzN43nHJUoyg9RiMsBxoL3VnR275JwPW3xYazSG5 LxcUi+oqKGq+M+vCnwElDn67aCOzQTOJNUDOBSXUksEl4EsTh9Y+fOQZJ71NdAaiM3 qd6tzDoKvhfk5KlcbF6WJjS8G7EeDbJuPd6DZAO8/FpyPMm81TN0ZZerFS10X+0N6M JcI+wc0hHK+5u0ubY3oc8hWQuiglqbi67ogiAnm6UG6ZYFA1PsW1qJk4jjO+hmalQ9 Hrisdhhh40rF/kdMuzn3MQmdjQETHqwp0yDte8F1F4eWWQYFOp+EM8eE8jpU7DlHON CAQ+OM0XbGFRg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 96397E1B4D8; Thu, 8 Dec 2022 23:50:15 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path From: patchwork-bot+linux-riscv@kernel.org Message-Id: <167054341561.16966.16448595920168997874.git-patchwork-notify@kernel.org> Date: Thu, 08 Dec 2022 23:50:15 +0000 References: <20221111223108.1976562-1-abrestic@rivosinc.com> In-Reply-To: <20221111223108.1976562-1-abrestic@rivosinc.com> To: Andrew Bresticker Cc: linux-riscv@lists.infradead.org, palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, atishp@rivosinc.com, guoren@kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to riscv/linux.git (for-next) by Palmer Dabbelt : On Fri, 11 Nov 2022 17:31:08 -0500 you wrote: > The return to userspace path in entry.S may enable interrupts without the > corresponding lockdep annotation, producing a splat[0] when DEBUG_LOCKDEP > is enabled. Simply calling __trace_hardirqs_on() here gets a bit messy > due to the use of RA to point back to ret_from_exception, so just move > the whole slow-path loop into C. It's more readable and it lets us use > local_irq_{enable,disable}(), avoiding the need for manual annotations > altogether. > > [...] Here is the summary with links: - RISC-V: Fix unannoted hardirqs-on in return to userspace slow-path https://git.kernel.org/riscv/c/b0f4c74eadbf You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html