Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp1868744rwb; Thu, 8 Dec 2022 16:46:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf7lwTxoJQNV8hDmWuBF5BZPzgGSS8dXpjcgWqP0+/EhWNGgZRvQMypCoykaHbYtbPfwoFBP X-Received: by 2002:a62:a509:0:b0:56b:f127:f21f with SMTP id v9-20020a62a509000000b0056bf127f21fmr3661502pfm.13.1670546770713; Thu, 08 Dec 2022 16:46:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670546770; cv=none; d=google.com; s=arc-20160816; b=vZcXls/aDoCLS0xiAFl6F7xagZYX3xfuFxkIFsE5/AaoxMbSS9W8WZm1ChWQuqRX8J 9EDbipWWk7QdIaqIwxs3E4XSPjqbf+RPNX2csiEZUyNkHTCnwIcAewCeyfDm9EMxl+lV Do9K58kwHYo2cqkHDK6OySsFn6sEiED7LffyV1DVok/hSxuPqYvH7bYrbtcI5fAKUcbx Lk1xW+Dmvkb9Ac6Ux1ZuZyDwpRsPdSI1L6mCZTjJD3/6HroDiIN2WsXDo1mqGW56ZT9Y bS+qCYY/OB17Q5xHSnAtB5VsuNlWPrc/2eEPaI0m9n6C5SCdaP3sStR2NqwvJaHGRe/0 I3ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=4ZjR+Vl1hcBujpMBxlKjQQPIWlNHLScCkpetoAeaF2M=; b=VdbQxiwZh0fq5hLF6saAyvqhRs628Sp4JrGfp7YxMXc/UnJoBMzCr/7ceAca0TZe9y ZBtLNhX/V7q613WYIkfv3jh/neXTIfw/q+HEaYr2n8AZvqHL4FFaOqf7DajskXolPC6H d7cKtRqst6a0Z/uqvqluRmwZJ8AHTf0vZCTAjMpb8qLs6potSeptgVJ5o7jdG67jnsOz h9ZXjYtGeWaz1ZPTsuv/PQBITsIy0cRFh7wySCvEAxYPzY/F/eprH123ouKmbUL8qLzq Im56PDKUKR77yxZHqoS21p1pbR18OpbiU9Maa1xHmgrIfqNRJQMEi1gHp+tU4EsKbG8e 1Adw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=exbjf7j8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u18-20020a056a00159200b005763ac23ae3si301753pfk.171.2022.12.08.16.45.35; Thu, 08 Dec 2022 16:46:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=exbjf7j8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229684AbiLIAWX (ORCPT + 73 others); Thu, 8 Dec 2022 19:22:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53084 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbiLIAWT (ORCPT ); Thu, 8 Dec 2022 19:22:19 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A63FF92310; Thu, 8 Dec 2022 16:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=4ZjR+Vl1hcBujpMBxlKjQQPIWlNHLScCkpetoAeaF2M=; b=exbjf7j82t7oVPV96bEocY40JJ BtdYsgLkcvWd9xpaMM3gtzzSXyCPmNw4VYB+s0x9TCnXkJxg6G1yddqnZyONXkGMRVv2/z/1DD8z+ iHVJhq1htjop2GRn0gtqCNh19/u//2bbc004nNMNq6p/myuw0gNCwd13EiQLX9u+wSX/mf0a6sasJ jT+8Z1W3WrhpaCXBmd/pf11drGf1AlkH5spdPoMIuQaLOkPEKAkKlPHF1STFEBSCeSsa3cq1BvanO HC2Inf3f12R0ivOB0rhouK2gCJCLpBqdkU9UezpS8mRaizfVL1QvFohARM/YetxOKKMYDNhYEEz2M ARp8aJqA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3R9S-00GKtb-OH; Fri, 09 Dec 2022 00:22:06 +0000 Date: Thu, 8 Dec 2022 16:22:06 -0800 From: Luis Chamberlain To: Song Liu Cc: Zhen Lei , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Alexei Starovoitov , Jiri Olsa , Kees Cook , Andrew Morton , linux-modules@vger.kernel.org Subject: Re: [PATCH] livepatch: Call klp_match_callback() in klp_find_callback() to avoid code duplication Message-ID: References: <20221207032304.2017-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Luis Chamberlain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 08, 2022 at 04:11:06PM -0800, Song Liu wrote: > On Tue, Dec 6, 2022 at 7:25 PM Zhen Lei wrote: > > > > The implementation of function klp_match_callback() is identical to the > > partial implementation of function klp_find_callback(). So call function > > klp_match_callback() in function klp_find_callback() instead of the > > duplicated code. > > > > Signed-off-by: Zhen Lei > > Acked-by: Song Liu Thanks, applied to modules-next given this depends on the kallsyms stuff there. Pushed out. Luis