Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 8 Dec 2022 16:22:55 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     James Houghton <jthoughton@google.com>
Cc:     Muchun Song <songmuchun@bytedance.com>,
        Peter Xu <peterx@redhat.com>,
        David Hildenbrand <david@redhat.com>,
        David Rientjes <rientjes@google.com>,
        Axel Rasmussen <axelrasmussen@google.com>,
        Mina Almasry <almasrymina@google.com>,
        Zach O'Keefe <zokeefe@google.com>,
        Manish Mishra <manish.mishra@nutanix.com>,
        Naoya Horiguchi <naoya.horiguchi@nec.com>,
        "Dr . David Alan Gilbert" <dgilbert@redhat.com>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Baolin Wang <baolin.wang@linux.alibaba.com>,
        Miaohe Lin <linmiaohe@huawei.com>,
        Yang Shi <shy828301@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 04/47] hugetlb: only adjust address ranges when
 VMAs want PMD sharing
Message-ID: <Y5J/3+cDZ8Md956A@monkey>
References: <20221021163703.3218176-1-jthoughton@google.com>
 <20221021163703.3218176-5-jthoughton@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221021163703.3218176-5-jthoughton@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uu8Iz+NKeI4eOXGDC3VyZBlWveUuyRvfTGpfMU0BgiByAsjjxP1QPSIhEVso?=
 =?us-ascii?Q?rn7xsW5JagU8jwZtSD+S/d4jB7sw1FGzirl7Kr18jg2uI5onfddvFOIuJ1+7?=
 =?us-ascii?Q?0fcj5AJ8reN9fXeQjFH7w/kuIR32vl2xcd82shuHn8KMjybXn1z0N0wIz7ra?=
 =?us-ascii?Q?EP9jQ2IeDdVJptpYPBg3VsEHhkc/CrPOap0LoyuwKpp6nEshJelZ6J8Bwz0p?=
 =?us-ascii?Q?JWrkjJrLGFxhYXKamSPs2nZMdU3xMvJM98iPqNA0FEewwdAJvpmHy8jxr7C2?=
 =?us-ascii?Q?HTiw2xIDoVFMOSgimVfgIe/cFBrDkOw5Jn38JFBetfxCXTNnTFbTYzVUaLJm?=
 =?us-ascii?Q?kJLW8MUnn7lCigzo7uj5/IedmZZjRCLKcKQ6EZnVQxhOrb1CcK/i3DBc68lC?=
 =?us-ascii?Q?xvbjsfBReMg6pt51SeOR48DacgiCKIs1ijUsONF7R6x+g06zxSdFHflY/CY1?=
 =?us-ascii?Q?ytnm4LoNqQWG8OL9MvsH0C/fp0dpkYWBlJDzmVy+iW7a4B9q7XsOwXVEA6H4?=
 =?us-ascii?Q?/AOS247LTcVD+4WFLLgJXi5fNgEBUXCY+jjucPPDANJTemjsa2+bvMsujntf?=
 =?us-ascii?Q?UmRLwc3drQtEryFWTBRy9IKiKOnTGzbYX8CDx8lLtnvVQ4LMUjXx3AwAgdF8?=
 =?us-ascii?Q?xWXod0HtOZnYDm5OAO7x8aMeNwpvF1aJYmRw97oN2dXfJBPFJkiiz/PdCqxs?=
 =?us-ascii?Q?cDj5GAx6jVhiikaijuHe4XOHjzYh/UYLfE1++gYjDe0rQ0qaLlyHMRRgwuu0?=
 =?us-ascii?Q?uiIMQpK6f6xnxFk6MY9gnRUGZ0dGMg6oCcV0SzQulPnGtU3ZYoc5avdDvFve?=
 =?us-ascii?Q?9kxmnfh3nHwqM58uxpG4R+Q6MKGh6ruSCA4y+WQ+UeG6WmmD4y0i8pZhdJpz?=
 =?us-ascii?Q?3Gs2Iz4xh/n57sdHDO6mX4SJ1KwXCKOW3tEVEnhad7SNgP31zK4qNndm0+Cy?=
 =?us-ascii?Q?8ZHGa0tm2GJi4kA9OaXseKzp0pmMdeOUEmWG1E5vujLfFk19YYauaGqXNES2?=
 =?us-ascii?Q?gWtB/YiF7iX8L9bCqAy3bRDimA/atANgtDCkDvI9ebApGL6xeq21GPqGXkaU?=
 =?us-ascii?Q?1q9mgoSPO9a6XfqZX3enELaGYFJmsDRTmzf91O9HRu1roBhNq+H51V/GeOab?=
 =?us-ascii?Q?PES0KLL2OQEFVpfDYvWArODn/gVRkEHpgGRU3ID3wo/g1bHzhoTv8OtdtxOG?=
 =?us-ascii?Q?6LRIvbT3V2I7aLEmtYlJakskoBgAIYfmRYLV5bMDmhFkbS9rmPVrXb1ZSGV6?=
 =?us-ascii?Q?IGFd9jH4u28C+OFhlt4QNyRxjODQ7D/3dgFLzLy5ol0c+mkrHYutk7mEPyzm?=
 =?us-ascii?Q?Yj6pb+ZAZaw0trgJZWzKDv3XsV3b4BcbNug48nyF8Tf/wGMChBh+RGU8h3ux?=
 =?us-ascii?Q?W6h7J1PDMDMBZ0uAJ5pxqtfmLM74MVMHFCP728wAsSphpuvypAMpkVLQhuU5?=
 =?us-ascii?Q?0odaMAlgwzElXgmtQdPhoY6zJ6tZOM2x/n2x5rvXPUR1bPDj5X41hqd2jktq?=
 =?us-ascii?Q?LxDRr5uc6m6PCVpgAiu6+/MvhvFgKWWBNFyOe44hxnhaCgq+rVF4ZyYcBzRi?=
 =?us-ascii?Q?JBe3Zf2wOl6zXv3otlOo0P89d/w+evI3yL7AfqeVkP9ncRPVW1DMpuc/Er1b?=
 =?us-ascii?Q?wg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a93c5944-2839-4b7e-6203-08dad97b8660
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4201.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 00:22:59.0638
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0aA40ZXM/vbfQQ7YbFDhNDDoPrkdkAaH25WAPtdAMuF2/tA4VcKSDWNHPYtVmotzhzaMOiHq+OJOoadFk9A4Pg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR10MB5979
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-08_12,2022-12-08_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0
 suspectscore=0 mlxlogscore=901 malwarescore=0 phishscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000
 definitions=main-2212090001
X-Proofpoint-GUID: R-dm8ness_-HkrrA-k9eOf2rxhTFvOW5
X-Proofpoint-ORIG-GUID: R-dm8ness_-HkrrA-k9eOf2rxhTFvOW5
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/21/22 16:36, James Houghton wrote:
> Currently this check is overly aggressive. For some userfaultfd VMAs,
> VMA sharing is disabled, yet we still widen the address range, which is
> used for flushing TLBs and sending MMU notifiers.

Yes, the userfaultfd check is missing in the code today.

> This is done now, as HGM VMAs also have sharing disabled, yet would
> still have flush ranges adjusted. Overaggressively flushing TLBs and
> triggering MMU notifiers is particularly harmful with lots of
> high-granularity operations.
> 
> Signed-off-by: James Houghton <jthoughton@google.com>
> ---
>  mm/hugetlb.c | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)

Thanks,

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
-- 
Mike Kravetz