Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221208180209.50845-1-ryncsn@gmail.com> <20221208180209.50845-4-ryncsn@gmail.com>
 <Y5I2RiQzH/kFD6zX@casper.infradead.org>
In-Reply-To: <Y5I2RiQzH/kFD6zX@casper.infradead.org>
From:   Kairui Song <ryncsn@gmail.com>
Date:   Fri, 9 Dec 2022 10:00:02 +0800
Message-ID: <CAMgjq7DXqrcMvfFt6Ue_gXharkdjL01GGy8zaVrXDM5Uj4j6Jg@mail.gmail.com>
Subject: Re: [PATCH 3/5] swap: fold swap_ra_clamp_pfn into swap_ra_info
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Miaohe Lin <linmiaohe@huawei.com>,
        David Hildenbrand <david@redhat.com>,
        "Huang, Ying" <ying.huang@intel.com>,
        Hugh Dickins <hughd@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Matthew Wilcox <willy@infradead.org> =E4=BA=8E2022=E5=B9=B412=E6=9C=889=E6=
=97=A5=E5=91=A8=E4=BA=94 03:09=E5=86=99=E9=81=93=EF=BC=9A
>
> On Fri, Dec 09, 2022 at 02:02:07AM +0800, Kairui Song wrote:
> > From: Kairui Song <kasong@tencent.com>
> >
> > This make the code cleaner. This helper is made of only two line of
> > self explanational code and not reused anywhere else.
> >
> > And this actually make the compiled object smaller by a bit:
> >
> >           text    data     bss     dec     hex filename
> > Before:   9502     976      12   10490    28fa mm/swap_state.o
> > After:    9470     976      12   10458    28da mm/swap_state.o
>
> FYI, you can use scripts/bloat-o-meter to get a slightly more
> useful analysis of object code changes.
>

Thanks! That's very helpful info, I got following output from bloat-o-meter=
:

./scripts/bloat-o-meter mm/swap_state.o.old mm/swap_state.o
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-35 (-35)
Function                                     old     new   delta
swap_ra_info.constprop                       512     477     -35
Total: Before=3D8388, After=3D8353, chg -0.42%

I'll attach this info in commit message from now on.