Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2014821rwb;
        Thu, 8 Dec 2022 18:59:19 -0800 (PST)
X-Google-Smtp-Source: AA0mqf7ZQeQcxgMc7E1VCJ+nrjDd8Du4OuUAEXXhT22QP9LJvB6QEAG9s04yRdAL9bRCw9KqZAX9
X-Received: by 2002:a17:906:60c9:b0:7c1:b65:14c1 with SMTP id f9-20020a17090660c900b007c10b6514c1mr3434410ejk.10.1670554759387;
        Thu, 08 Dec 2022 18:59:19 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1670554759; cv=none;
        d=google.com; s=arc-20160816;
        b=bT0QxpyoZGotYMLnBJ0FaIJDBIrnSmBUqeFPD/qIB29RWoWE0pjJxHOgNU1zzyX1Xr
         WeTb3wQd+XaNtyJYDKCiBHDWkfSlRKlwQRJD35LgqWRrKzENNthpuxtT4dJ1PJ8SwwXX
         iEL3Wg+iT2xNhAxn1pn4Oa/cQUOeM6LijzShNCg01yLrsx7VHY52l3n1J+jOW0AJgYxe
         Uf1t04X5HEaUlKbYrWJNrgrsfDJ2i8rcLumJBu57/JEHJwNBZwfX7a34k0BWO+rhQIQX
         yqHwyCtquS0XwEBjY4N7H5d4Ydp/MpV1j4pihw/d26yzJP6QlRx/A5bLAM5i4T9lVKMx
         v71g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=hMnS+yISNCWUm5hsAqcKumTTe3dDNAMtpRlRMUFYoLc=;
        b=xYrwKxP5W0DHrLmkZywL2QzUqjJCkHjW+1QMm22SmbOm9w0LVdReC7Iosisq4OXA3Y
         57YJAOsn0gbXmCyiiUgon1Eo6FRRhOgPSo294/9caRzNMgy/hVGnlqw8v856AxQKsPrW
         EvfchwWkAchxXtXBY4hhsPeuSEgWDrqvoi22os2J7OkEM4rXGwCBhmSEkxDJtVVSvzyw
         iF7IPTojp2/x62m/xi1RvyF7jZFvDvw+eea0Vz0JfiLX1KWI5/9dQMVWR3zkyrr83YaU
         enK4thqqDhrw4Famvcjl0oEo4KxGgnBZpSV6EUsj4NazHsoUgFB24XzRzf3CNtX+oI9L
         KrLA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TJIjT6wQ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id sg10-20020a170907a40a00b007a7a3b40920si45423ejc.995.2022.12.08.18.59.01;
        Thu, 08 Dec 2022 18:59:19 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=TJIjT6wQ;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229843AbiLICdc (ORCPT <rfc822;2014014876lha@gmail.com>
        + 73 others); Thu, 8 Dec 2022 21:33:32 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57180 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229561AbiLICd3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 8 Dec 2022 21:33:29 -0500
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54439275D9;
        Thu,  8 Dec 2022 18:33:29 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 11D85B82607;
        Fri,  9 Dec 2022 02:33:28 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5A734C433D2;
        Fri,  9 Dec 2022 02:33:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1670553206;
        bh=hMnS+yISNCWUm5hsAqcKumTTe3dDNAMtpRlRMUFYoLc=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=TJIjT6wQzZWjZFqwX9/IpIrZbkfNEvL5C2i7LWM0y7PLaE0GRW4nBhWeRBzmH0AVi
         S0p5fj8O8Qp79Byu5pbcUBd2vlh1Z52DPfaBsmXjwBARBeKmswIuH9SwfNOsj8I3em
         to9+pRdOoJEmTRiE+DxfWHz0cU0+Aji+UtZ1FBP7zmaExAcUCoTAC6rhbnr/xyMRtH
         5eeZhU0TXJAmK8wdL0kTSLdRMH5MqcMnz9Wo1z5PtiB5y3PaRLpHw2OzpHBNy1o4Ug
         SzzOqia/yo6i6XCgH1lqwz5lQxhO5xIe2G5Pyr63fAj+BSwVw0EBI2uw/+qP/GPLLN
         gLgiKTH6DxNVQ==
Date:   Thu, 8 Dec 2022 18:33:25 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     <ehakim@nvidia.com>
Cc:     <linux-kernel@vger.kernel.org>, <raeds@nvidia.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <sd@queasysnail.net>,
        <atenart@kernel.org>, <jiri@resnulli.us>
Subject: Re: [PATCH net-next v4 1/2] macsec: add support for
 IFLA_MACSEC_OFFLOAD in macsec_changelink
Message-ID: <20221208183325.3abe9104@kernel.org>
In-Reply-To: <20221208183244.0365f63b@kernel.org>
References: <20221208115517.14951-1-ehakim@nvidia.com>
        <20221208183244.0365f63b@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 8 Dec 2022 18:32:44 -0800 Jakub Kicinski wrote:
> I think you're just moving this code, but still.

And by "by still" I mean - it's still a bug, so it needs to be fixed
first.