Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Dec 2022 10:22:36 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Niklas Cassel <niklas.cassel@wdc.com>, linux-kernel@vger.kernel.org
Cc:     Hannes Reinecke <hare@suse.de>, linux-scsi@vger.kernel.org,
        Damien Le Moal <damien.lemoal@opensource.wdc.com>
Subject: Re: [PATCH 25/25] Documentation: sysfs-block-device: document
 command duration limits
Message-ID: <Y5Kp/JhhwF1rjrdu@debian.me>
References: <20221208105947.2399894-1-niklas.cassel@wdc.com>
 <20221208105947.2399894-26-niklas.cassel@wdc.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="CYmK+XGGjrI5DVYI"
Content-Disposition: inline
In-Reply-To: <20221208105947.2399894-26-niklas.cassel@wdc.com>
Precedence: bulk


--CYmK+XGGjrI5DVYI
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 08, 2022 at 11:59:41AM +0100, Niklas Cassel wrote:
> +What:		/sys/block/*/device/duration_limits/enable
> +Date:		Dec, 2022
> +KernelVersion:	v6.3
> +Contact:	linux-scsi@vger.kernel.org
> +Description:
> +		(RW) For ATA and SCSI devices supporting the command duration
> +		limits feature, write to the file to turn on or off the
> +		feature. By default this feature is turned off. If the device
> +		does not support the command duration limits feature, this
> +		attribute does not exist (the directory
> +		"/sys/block/*/device/duration_limits" does not exist).
> +		Writing "1" to this file enables the use of command duration
> +		limits for read and write commands in the kernel and turns on
> +		the feature on the device. Writing "0" disables the feature.

Sphinx reported inline emphasis warning due to unescaped asterisk above:

Documentation/ABI/testing/sysfs-block-device:101: WARNING: Inline emphasis =
start-string without end-string.

I have applied the fixup:

---- >8 ----
diff --git a/Documentation/ABI/testing/sysfs-block-device b/Documentation/A=
BI/testing/sysfs-block-device
index 44841f91c69bfe..2cf806b638fbb3 100644
--- a/Documentation/ABI/testing/sysfs-block-device
+++ b/Documentation/ABI/testing/sysfs-block-device
@@ -107,7 +107,7 @@ Description:
 		feature. By default this feature is turned off. If the device
 		does not support the command duration limits feature, this
 		attribute does not exist (the directory
-		"/sys/block/*/device/duration_limits" does not exist).
+		"/sys/block/\*/device/duration_limits" does not exist).
 		Writing "1" to this file enables the use of command duration
 		limits for read and write commands in the kernel and turns on
 		the feature on the device. Writing "0" disables the feature.

> +
> +
> +What:		/sys/block/*/device/duration_limits/read/[1-7]/*
> +Date:		Dec, 2022
> +KernelVersion:	v6.3
> +Contact:	linux-scsi@vger.kernel.org
> +Description:
> +		(RO) For ATA and SCSI devices supporting the command duration
> +		limits feature, this shows the set of 7 command duration limits
> +		descriptors for read commands currently set on the device. For
> +		each of the 7 descritors, the following read-only attributes
> +		are present:
> +
> +		  - duration_guideline: specifies the preferred length of time
> +		    in microseconds for the completion of a command.
> +
> +		  - duration_guideline_policy: specifies the policy action
> +		    taken if the duration_guideline attribute specifies a
> +		    non-zero command duration guideline that the device is
> +		    unable to achieve for a command.
> +
> +		    Possible values are:
> +
> +		      - 0x0: The device will complete the command at the
> +			     earliest possible time consistent with the
> +			     specified command duration guideline.
> +		      - 0x1: If the specified command duration guideline has
> +			     not been achieved and the command duration
> +			     guideline policy field is not the seventh command
> +			     duration limits descriptor, then the device
> +			     continues processing that command using the
> +			     command duration limits descriptor that has
> +			     the next higher number.
> +		      - 0x2: The device will continue processing the command
> +			     as with no command duration limits descriptor
> +			     being used.
> +		      - 0xD: The device will complete the command and an IO
> +			     failure will be reported to the user with the ETIME
> +			     error code.
> +		      - 0xF: Same as 0xD.
> +
> <snipped>...
> +		    Possible values are:
> +
> +		      - 0x0: The device will complete the command at the
> +			     earliest possible time (i.e, do nothing based on
> +			     the max limit not being met).
> +		      - 0xD: The device will complete the command and an IO
> +			     failure will be reported to the user with the ETIME
> +			     error code.
> +		      - 0xE: Same as 0xD.
> +		      - 0xF: Same as 0xD.
> +
> <snipped>...
> +		    Possible values are:
> +
> +		      - 0x0: The device will complete the command at the
> +			     earliest possible time (i.e, do nothing based on
> +			     the time limit not being met).
> +		      - 0xD: The device will complete the command and an IO
> +			     failure will be reported to the user with the ETIME
> +			     error code.
> +		      - 0xF: Same as 0xD.
> +

The lists items above looks poorly indented in htmldocs (due to use of
proportional fonts). The fix is to align to first character after bullet
list marker, like:

---- >8 ----
diff --git a/Documentation/ABI/testing/sysfs-block-device b/Documentation/A=
BI/testing/sysfs-block-device
index 2cf806b638fbb3..79f67b975d57ac 100644
--- a/Documentation/ABI/testing/sysfs-block-device
+++ b/Documentation/ABI/testing/sysfs-block-device
@@ -135,21 +135,25 @@ Description:
 		    Possible values are:
=20
 		      - 0x0: The device will complete the command at the
-			     earliest possible time consistent with the
-			     specified command duration guideline.
+			earliest possible time consistent with the
+			specified command duration guideline.
+
 		      - 0x1: If the specified command duration guideline has
-			     not been achieved and the command duration
-			     guideline policy field is not the seventh command
-			     duration limits descriptor, then the device
-			     continues processing that command using the
-			     command duration limits descriptor that has
-			     the next higher number.
+			not been achieved and the command duration
+			guideline policy field is not the seventh command
+			duration limits descriptor, then the device
+			continues processing that command using the
+			command duration limits descriptor that has
+			the next higher number.
+
 		      - 0x2: The device will continue processing the command
-			     as with no command duration limits descriptor
-			     being used.
+			as with no command duration limits descriptor
+			being used.
+
 		      - 0xD: The device will complete the command and an IO
-			     failure will be reported to the user with the ETIME
-			     error code.
+			failure will be reported to the user with the ETIME
+			error code.
+
 		      - 0xF: Same as 0xD.
=20
 		  - max_active_time: specifies an upper limit in microseconds
@@ -165,12 +169,15 @@ Description:
 		    Possible values are:
=20
 		      - 0x0: The device will complete the command at the
-			     earliest possible time (i.e, do nothing based on
-			     the max limit not being met).
+			earliest possible time (i.e, do nothing based on
+			the max limit not being met).
+
 		      - 0xD: The device will complete the command and an IO
-			     failure will be reported to the user with the ETIME
-			     error code.
+			failure will be reported to the user with the ETIME
+			error code.
+
 		      - 0xE: Same as 0xD.
+
 		      - 0xF: Same as 0xD.
=20
 		  - max_inactive_time: specifies an upper limit in microseconds
@@ -185,11 +192,13 @@ Description:
 		    Possible values are:
=20
 		      - 0x0: The device will complete the command at the
-			     earliest possible time (i.e, do nothing based on
-			     the time limit not being met).
+			earliest possible time (i.e, do nothing based on
+			the time limit not being met).
+
 		      - 0xD: The device will complete the command and an IO
-			     failure will be reported to the user with the ETIME
-			     error code.
+			failure will be reported to the user with the ETIME
+			error code.
+
 		      - 0xF: Same as 0xD.
=20
=20
Thanks.

--=20
An old man doll... just what I always wanted! - Clara

--CYmK+XGGjrI5DVYI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY5Kp8wAKCRD2uYlJVVFO
o7EiAQDbFwVWhF/CVWXIYKBEOf576MDRyDzz42i92hrpx2BanwEAvM3aItECUxbW
3suLyS9RuTyeMDquZDebuRurHcvqJw4=
=QP6J
-----END PGP SIGNATURE-----

--CYmK+XGGjrI5DVYI--