Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: rvwe1aGXIXBQ4PL4Cj4ffvsbm0idwTZP66Lu9VxgmZaqbzrNTRRt5HY518QmLoXwJi34LI8OLP
 OXJIENH1B2rJfiRwWzGIwRzVSAxTbyVd485Ve631InAvkdffv1JFkkkV+S8CF46yrJ6cwUj/hf
 tagW/bfs+x0PaX6ojvob+clRGHBIrg5xhL9N0MD9yn1/m2Ecjm9IlAy4Noy/nCx3VZraEyxJBw
 HXq6qNJQrtkAmJIuTOKcDtOhupQDQJ3tkGDE/RhS1b3wcFP40BePXUY9fnEcxoo8M7S4fmp91j
 UPk=
IronPort-SDR: TrAUaM0OUoKu4wMm2KJFEGKYe4+ulHWDn9KfDAEG7zXv9JsE8qosgcu+rtU9ibOgbbzQYX79du
 EtDv1Ju3KScZjpJDJG9S5APH5KGF/IJAGNv70QCSuBY8azmTkAY3xrUhOI5ApFSylPQVWzNBI4
 CZYx+hhNJFqNBPkVQYH2bmtozJrvJJbzzqzm6/p/BkvZP+mAjHo2MVhUavEHh4SPfJ5AbghjSs
 AFcRjXGBXVVHhPM4Vyg+h4amyHtjG5yYstzcDYblb2i9PZAlQerydoJyDqZbaaM6LO2wUQSAwc
 Hg8=
WDCIronportException: Internal
Message-ID: <ad6c7534-14dc-d48a-f5f1-a35c649a42bd@opensource.wdc.com>
Date:   Fri, 9 Dec 2022 12:31:19 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH 25/25] Documentation: sysfs-block-device: document command
 duration limits
Content-Language: en-US
To:     Bagas Sanjaya <bagasdotme@gmail.com>,
        Niklas Cassel <niklas.cassel@wdc.com>,
        linux-kernel@vger.kernel.org
Cc:     Hannes Reinecke <hare@suse.de>, linux-scsi@vger.kernel.org
References: <20221208105947.2399894-1-niklas.cassel@wdc.com>
 <20221208105947.2399894-26-niklas.cassel@wdc.com>
 <Y5Kp/JhhwF1rjrdu@debian.me>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <Y5Kp/JhhwF1rjrdu@debian.me>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/9/22 12:22, Bagas Sanjaya wrote:
> On Thu, Dec 08, 2022 at 11:59:41AM +0100, Niklas Cassel wrote:
>> +What:		/sys/block/*/device/duration_limits/enable
>> +Date:		Dec, 2022
>> +KernelVersion:	v6.3
>> +Contact:	linux-scsi@vger.kernel.org
>> +Description:
>> +		(RW) For ATA and SCSI devices supporting the command duration
>> +		limits feature, write to the file to turn on or off the
>> +		feature. By default this feature is turned off. If the device
>> +		does not support the command duration limits feature, this
>> +		attribute does not exist (the directory
>> +		"/sys/block/*/device/duration_limits" does not exist).
>> +		Writing "1" to this file enables the use of command duration
>> +		limits for read and write commands in the kernel and turns on
>> +		the feature on the device. Writing "0" disables the feature.
> 
> Sphinx reported inline emphasis warning due to unescaped asterisk above:
> 
> Documentation/ABI/testing/sysfs-block-device:101: WARNING: Inline emphasis start-string without end-string.
> 
> I have applied the fixup:

[...]

>> <snipped>...
>> +		    Possible values are:
>> +
>> +		      - 0x0: The device will complete the command at the
>> +			     earliest possible time (i.e, do nothing based on
>> +			     the time limit not being met).
>> +		      - 0xD: The device will complete the command and an IO
>> +			     failure will be reported to the user with the ETIME
>> +			     error code.
>> +		      - 0xF: Same as 0xD.
>> +
> 
> The lists items above looks poorly indented in htmldocs (due to use of
> proportional fonts). The fix is to align to first character after bullet
> list marker, like:

Thanks for the hints. Will fix that in v2.


-- 
Damien Le Moal
Western Digital Research