Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Firo Yang <firo.yang@suse.com>
To:     marcelo.leitner@gmail.com, kuba@kernel.org, vyasevich@gmail.com,
        nhorman@tuxdriver.com
Cc:     mkubecek@suse.com, davem@davemloft.net, edumazet@google.com,
        pabeni@redhat.com, linux-sctp@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        firogm@gmail.com, Firo Yang <firo.yang@suse.com>
Subject: [PATCH v3 1/1] sctp: sysctl: make extra pointers netns aware
Date:   Fri,  9 Dec 2022 13:48:54 +0800
Message-Id: <20221209054854.23889-1-firo.yang@suse.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iJJrHQeGRFLS6RDIm7rPA62+OpQ3pmXlA9AwL7lYoxrFj08JwWhuJt/06BzS?=
 =?us-ascii?Q?j1PUOWQXf9fOWwTmCBhBV/0PF0CQLFP+6DiQ2/+K/dogykx/zF/VpfqCELP8?=
 =?us-ascii?Q?10sgeZiBY1L3sumMcSFpr9P58BDvIl2E7sXr3b9tTLFALqourO/3Z7k9QObF?=
 =?us-ascii?Q?NLCc33pG/C+obiJuT53AVnH5P0SMhcJgu++AjRzHCA8fG9TBtXmg97jL8YHg?=
 =?us-ascii?Q?HuEVQDrNiXVdPjDiH+HrydNEL9X4WxqZ/vYk8ooY/bk7DNR7vqCGXCgKdj03?=
 =?us-ascii?Q?QOLXOElF9dI+YNrjxScoKjohpuotDttYZ8V8k79YjVipJnzBLjjsXnsWEu2w?=
 =?us-ascii?Q?VxqhnbL1DXZgwfCNMb1GBmwK4TFJ5U0prZftB+CHOBqcAqNt2YDjh1rYSX+Z?=
 =?us-ascii?Q?UX8yRK1RcOTR1vlaGoSFo47sKVga365/O7C5R8ZhVnkCvC/BBJ1MUiUfnO6N?=
 =?us-ascii?Q?0tgoA0pbdCWLm1La2QFXx+qOFcPUtyDeDnAYLLGD1saFgbgzD3p9/f1Xs+Ot?=
 =?us-ascii?Q?UHdvkPLf+W7vT9pDxgRjaCcTU8pWWEDSXBs2kcGreThF8E+mpkcfF7DZYyS2?=
 =?us-ascii?Q?WVE5kYyd91DpFIlI23jua3cIMEJbmvU4PHV/0/OcjjKDPdMKp76JU5o+YVd/?=
 =?us-ascii?Q?ReyDaQV4grYyej4pNcIghGTot/F7JMzDtHe3VHxWNFjZTbdNRQwojjqmCevB?=
 =?us-ascii?Q?Bqm//Z/ReIigkvTA7rzpqfrhgAcpBtl7TMAM1nYB4m4bluLrHsZf0NiCvMi9?=
 =?us-ascii?Q?euCLOtX2oTW2+P3ZuuIRr+hAPZP5/wvEyxfpjd70KrBU577HrRUJaTBcvtf6?=
 =?us-ascii?Q?7L043BZ/0EoeUUTOZAt9cTkhFCZkCYf8euUL1v9VHTjEMtPXB/IX3VQz3Oxd?=
 =?us-ascii?Q?z2YNl69XcZNYtq88Pcmm94hq6zhqSBVr83H0D07QMJc/FNdyIgH/K4CuzGlD?=
 =?us-ascii?Q?hclsbsTHjYwHG42yABHWgrsVDgB1B4m+W1aMZITTtMhKEVPOLOk+w2yl0IjQ?=
 =?us-ascii?Q?zv69CiyDnsv9oWibefVN1BQuM+XF7ANrsvJaYwgCm4iKRRcw9IgMxc5HfBSr?=
 =?us-ascii?Q?55xsEB95UDFFcWXqqRXiQJRorvRkopSvHd7omWPalyVQYn4AUqEbTO5vd4hl?=
 =?us-ascii?Q?a6SHjTspdWQJR2pMKbckB73I2iOEj9x2M5/s/nwrDfiFMm3kZNWqBwMC1g1o?=
 =?us-ascii?Q?rTIYh4CVpgY3t1nzDySc0d2HJyY3SzQrc609F7fSieDh0zzaGDMv2AuJNJXm?=
 =?us-ascii?Q?+CLofQImG+RxxJBa9w7F6c8QlStxJFUjOCGiQGCb9cVKbMczzZpo0o9nLyY6?=
 =?us-ascii?Q?ovBk7Mi9Deo+m+FNbcxcOceoTz74VPx1RZ9t/9S2qA5xBxZc72PuV4SeWX9m?=
 =?us-ascii?Q?OWfIVTwCkCnWfN+ZDfn1VR9AV0Sp/wO6OQsKBgbHUAP145817zyiIXnqSyrY?=
 =?us-ascii?Q?vIQWAm4KSKL2SXVL78ua0sElcXC+En/gLouJOs6yQt78KS1CVvTb1gCYDfWr?=
 =?us-ascii?Q?eSZNAVHFaItsiq6bEZs6uxF4avbUli0BqmI4cQQJ89RdkwMOdsNWpBPVZn4j?=
 =?us-ascii?Q?tjsayvxukkDwRW3iqW9YATuMXdZWUrqtBn9W4PWSPN/pTIUvs8tIQlraIqpl?=
 =?us-ascii?Q?FSge0F7Qjo9utgH4IPbU5ulJOvFFmACYeHZEhiZsURvP?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9b768b9a-dfec-4412-217b-08dad9a914b8
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB9009.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 05:49:04.8376
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YIGShJtPSw96m0sADzcZ+Rf0CQ/nr7PDwzFmbhUceGxxaSpL13YhpoCopx8G8BXqrdw6Zq3PBMnfRfxtTe60tQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7491
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Recently, a customer reported that from their container whose
net namespace is different to the host's init_net, they can't set
the container's net.sctp.rto_max to any value smaller than
init_net.sctp.rto_min.

For instance,
Host:
sudo sysctl net.sctp.rto_min
net.sctp.rto_min = 1000

Container:
echo 100 > /mnt/proc-net/sctp/rto_min
echo 400 > /mnt/proc-net/sctp/rto_max
echo: write error: Invalid argument

This is caused by the check made from this'commit 4f3fdf3bc59c
("sctp: add check rto_min and rto_max in sysctl")'
When validating the input value, it's always referring the boundary
value set for the init_net namespace.

Having container's rto_max smaller than host's init_net.sctp.rto_min
does make sense. Consider that the rto between two containers on the
same host is very likely smaller than it for two hosts.

So to fix this problem, as suggested by Marcelo, this patch makes the
extra pointers of rto_min, rto_max, pf_retrans, and ps_retrans point
to the corresponding variables from the newly created net namespace while
the new net namespace is being registered in sctp_sysctl_net_register.

Fixes: 4f3fdf3bc59c ("sctp: add check rto_min and rto_max in sysctl")
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: Firo Yang <firo.yang@suse.com>
---
 net/sctp/sysctl.c | 73 ++++++++++++++++++++++++++++-------------------
 1 file changed, 44 insertions(+), 29 deletions(-)

v2 -> v3: 
 * Explicitly specifying indexes in sctp_net_table[].

diff --git a/net/sctp/sysctl.c b/net/sctp/sysctl.c
index b46a416787ec..43ebf090029d 100644
--- a/net/sctp/sysctl.c
+++ b/net/sctp/sysctl.c
@@ -84,17 +84,18 @@ static struct ctl_table sctp_table[] = {
 	{ /* sentinel */ }
 };
 
+/* The following index defines are used in sctp_sysctl_net_register().
+ * If you add new items to the sctp_net_table, please ensure that
+ * the index values of these defines hold the same meaning indicated by
+ * their macro names when they appear in sctp_net_table.
+ */
+#define SCTP_RTO_MIN_IDX       0
+#define SCTP_RTO_MAX_IDX       1
+#define SCTP_PF_RETRANS_IDX    2
+#define SCTP_PS_RETRANS_IDX    3
+
 static struct ctl_table sctp_net_table[] = {
-	{
-		.procname	= "rto_initial",
-		.data		= &init_net.sctp.rto_initial,
-		.maxlen		= sizeof(unsigned int),
-		.mode		= 0644,
-		.proc_handler	= proc_dointvec_minmax,
-		.extra1         = SYSCTL_ONE,
-		.extra2         = &timer_max
-	},
-	{
+	[SCTP_RTO_MIN_IDX] = {
 		.procname	= "rto_min",
 		.data		= &init_net.sctp.rto_min,
 		.maxlen		= sizeof(unsigned int),
@@ -103,7 +104,7 @@ static struct ctl_table sctp_net_table[] = {
 		.extra1         = SYSCTL_ONE,
 		.extra2         = &init_net.sctp.rto_max
 	},
-	{
+	[SCTP_RTO_MAX_IDX] =  {
 		.procname	= "rto_max",
 		.data		= &init_net.sctp.rto_max,
 		.maxlen		= sizeof(unsigned int),
@@ -112,6 +113,33 @@ static struct ctl_table sctp_net_table[] = {
 		.extra1         = &init_net.sctp.rto_min,
 		.extra2         = &timer_max
 	},
+	[SCTP_PF_RETRANS_IDX] = {
+		.procname	= "pf_retrans",
+		.data		= &init_net.sctp.pf_retrans,
+		.maxlen		= sizeof(int),
+		.mode		= 0644,
+		.proc_handler	= proc_dointvec_minmax,
+		.extra1		= SYSCTL_ZERO,
+		.extra2		= &init_net.sctp.ps_retrans,
+	},
+	[SCTP_PS_RETRANS_IDX] = {
+		.procname	= "ps_retrans",
+		.data		= &init_net.sctp.ps_retrans,
+		.maxlen		= sizeof(int),
+		.mode		= 0644,
+		.proc_handler	= proc_dointvec_minmax,
+		.extra1		= &init_net.sctp.pf_retrans,
+		.extra2		= &ps_retrans_max,
+	},
+	{
+		.procname	= "rto_initial",
+		.data		= &init_net.sctp.rto_initial,
+		.maxlen		= sizeof(unsigned int),
+		.mode		= 0644,
+		.proc_handler	= proc_dointvec_minmax,
+		.extra1         = SYSCTL_ONE,
+		.extra2         = &timer_max
+	},
 	{
 		.procname	= "rto_alpha_exp_divisor",
 		.data		= &init_net.sctp.rto_alpha,
@@ -207,24 +235,6 @@ static struct ctl_table sctp_net_table[] = {
 		.extra1		= SYSCTL_ONE,
 		.extra2		= SYSCTL_INT_MAX,
 	},
-	{
-		.procname	= "pf_retrans",
-		.data		= &init_net.sctp.pf_retrans,
-		.maxlen		= sizeof(int),
-		.mode		= 0644,
-		.proc_handler	= proc_dointvec_minmax,
-		.extra1		= SYSCTL_ZERO,
-		.extra2		= &init_net.sctp.ps_retrans,
-	},
-	{
-		.procname	= "ps_retrans",
-		.data		= &init_net.sctp.ps_retrans,
-		.maxlen		= sizeof(int),
-		.mode		= 0644,
-		.proc_handler	= proc_dointvec_minmax,
-		.extra1		= &init_net.sctp.pf_retrans,
-		.extra2		= &ps_retrans_max,
-	},
 	{
 		.procname	= "sndbuf_policy",
 		.data		= &init_net.sctp.sndbuf_policy,
@@ -586,6 +596,11 @@ int sctp_sysctl_net_register(struct net *net)
 	for (i = 0; table[i].data; i++)
 		table[i].data += (char *)(&net->sctp) - (char *)&init_net.sctp;
 
+	table[SCTP_RTO_MIN_IDX].extra2 = &net->sctp.rto_max;
+	table[SCTP_RTO_MAX_IDX].extra1 = &net->sctp.rto_min;
+	table[SCTP_PF_RETRANS_IDX].extra2 = &net->sctp.ps_retrans;
+	table[SCTP_PS_RETRANS_IDX].extra1 = &net->sctp.pf_retrans;
+
 	net->sctp.sysctl_header = register_net_sysctl(net, "net/sctp", table);
 	if (net->sctp.sysctl_header == NULL) {
 		kfree(table);
-- 
2.26.2