Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8da7cbbc-0a03-32e5-cc92-56931365782a@amd.com>
Date:   Fri, 9 Dec 2022 12:13:45 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 2/4] Documentation: amd_pstate: Move amd_pstate param to
 alphabetical order
Content-Language: en-US
To:     Bagas Sanjaya <bagasdotme@gmail.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
        Perry.Yuan@amd.com
Cc:     Jonathan Corbet <corbet@lwn.net>, Huang Rui <ray.huang@amd.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Mario.Limonciello@amd.com, Ananth Narayan <ananth.narayan@amd.com>,
        gautham.shenoy@amd.com
References: <20221207154648.233759-1-wyes.karny@amd.com>
 <20221207154648.233759-3-wyes.karny@amd.com> <Y5FPBNawZgvk7GBe@debian.me>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <Y5FPBNawZgvk7GBe@debian.me>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RXdqaHVzaVEvMUlRWVhudFZvQnJob3lRRXp4a1BhRVYrMERyd294bmkvM3o5?=
 =?utf-8?B?WGViWUFpaFp1MHdvUFFob1dCVldKTnd0ODNUbWFYcUg1UEdDL2lNTWQra3lJ?=
 =?utf-8?B?Z3Uwek50SEIxZ2p5d1ZaSkVSb2lTQUxkNFB4c3R0QmczRlRUaktRRjRHRjhF?=
 =?utf-8?B?YWJlbWhoQXFwd25qZG1PRVZjYXplUlJWWVIxNHhtVDExRlhxNWRoZ1ZyZUN1?=
 =?utf-8?B?MGRwTjZSMjBwZ3MrVlFWNFpNQWxNWEtLOHNiejM0Lzh0Nk5tdGxlLzFrc1RL?=
 =?utf-8?B?VEJYU1ZjRGUrRHl2S1FYbk9hcTZkdDYvb3p6bm13SE9qMG5STldETEJiV1F4?=
 =?utf-8?B?M1RkZEFnNkxEZWJpd093MjFzdmRiUkQyRjJWN08vTHZrajFmTVNUbzRGUUdT?=
 =?utf-8?B?L3RZcTJKUWl5YW1wK0FvSlVlazBlZkJSdU1JUFd1UEpZTlcwNTRnTlkrZVlL?=
 =?utf-8?B?bHJQbHd6bmxObGN4WGQyR2w2eExKRU1XeWNvdE4zVHpLeEZNVU1yalNSRG50?=
 =?utf-8?B?djZNbnZnbUpBOFduWjJZd1l2YVBXSWQzRUVFWDNBNktVSWhJWFEyb2tJNW9G?=
 =?utf-8?B?eWljdlVGak10TTErd1lpZ29mdEVhNkg3Q01manVZclN3N3V3QVJWcytIL0FF?=
 =?utf-8?B?RW5scjBFTjF3ejB0QmUzbVlBR1ZLalI2Q05lWDY0aGxmY2RkWlk1TzRROXlT?=
 =?utf-8?B?UmZaMktad3FHd3ZWME9MSlVjTmlnbnlCSU9OWkhrbU5DVzdkb3Zhbk1GZzdy?=
 =?utf-8?B?S3c4dGFmK1dMQ0g5d1g1dW94UnBBTVBNU0RNbmNFQUJCM1lRWHdndTVPVW1M?=
 =?utf-8?B?cFBRcWphd3NSZEdqSm9scWI1SmhJbEMyaEFmeUpieHZXcXJUSmxDV0tFUVZR?=
 =?utf-8?B?YjBXbHpPYTU5T2NtSU8rZFRFcUh2ak1SU24vYU10ZzdZT2RHTFUvaWpSY3ps?=
 =?utf-8?B?WlFXK01ZbmtPbnBZTXRpaUt4dDQrZ3h2MUE0MWRwMG1OS1V0cHdjZHZqUm80?=
 =?utf-8?B?bjRtSS96Z0FIb3pZNnEzVXVwVWxrQ3hKUFRYQ21teHkzOEhTVTl2ZTNaWUdi?=
 =?utf-8?B?dzd6WExqVWEvKzUwZndaVW9MR1RBdFkyanlIbnAyQUx6TUxkNmJVMEJuNDM3?=
 =?utf-8?B?K0Z4SUMvYnJRUld5SWJlcUpIVW5ibDdEWnM5YTZDN3JySU9kUVZjYzY4MjVv?=
 =?utf-8?B?MHJRcDAxSzR5MVVlTElLK2NNTUduLzJjY3UyWkhGTDJScTh6VTd1azhJbU1l?=
 =?utf-8?B?Tjh5VFpHbnV2T2g5Rkd4Q2hobWlpMEZwcXByUVF0Z1ppemNZZmVXbUlxYUhm?=
 =?utf-8?B?WGxrTnNOUnpnWmoyRTB2b2Z4Z1RzN05lak9jVkZCUHYwY1phS2duWTZwS09j?=
 =?utf-8?B?TXNDL1NqcWh1SVRuNVlNRlNwVGdVTGVDSkZPdHdTRm9hYVJYMk5xb1oxTVVh?=
 =?utf-8?B?S0VjNG9Nb3kzYnpOZVphYS9VN1lWQm0vRGFzVzQ5aVhuK3VITSt0ZHhWWlp0?=
 =?utf-8?B?RDVSY05OMGZVK1ZoMFhOK1hNWTNNaEV0L0h6c2lucTBOMmpWOUU0ZlhaSGJD?=
 =?utf-8?B?dnJEZFVyaG96a3lOdEk1Y2Y3UENXSnp2YkdXblJqME5BNGFHRWZIMllOV216?=
 =?utf-8?B?djdadnQ4NzlIYmdxampORjVkQjNVRDhSRWcrZnBDcEMrTkxweWtOWWlXb2lT?=
 =?utf-8?B?SkJPRnh3M2FCeU9KKy9YY1RqTnphRktpV3ZrQnJIUEw1TkRoVzFqaWwvMmV1?=
 =?utf-8?B?cDJXOTFWeXVNOStEWG9CV2hXOHFNOUlnVU1UNDZ0cXVpcmYwRXdGdWQ0Mkww?=
 =?utf-8?B?VENZOWEzQUx4MmJsYWIxQmNPdXlvUlQwMksrMHEzdHk2aWJuQnpoOFlMSkFP?=
 =?utf-8?B?NUJ5dWpKL3ZWVGZUZysrdXpQOURxdDFFSG00VjRiYUlOd1pzaHdtYUt6RXNx?=
 =?utf-8?B?N1VhVnp1RTBMeitSV3ZuZzkrVmx5ekhnMTBzek4vODA2Q1hMZFRISWFMYXl6?=
 =?utf-8?B?bHdLT2tuNStscUZIdk5PKytKdDVhVG96UlptR0hRQ3Y5Z0tpSWdMY25QVEcv?=
 =?utf-8?B?cGNqVmJRdTd6Z1hXTWxpVmszVnlVejc4SE5KZVkwNW9rdXIraE05cEFNOEdS?=
 =?utf-8?Q?3+aor18Y2FpWBU3EakS2TAqkK?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4d02e53b-da62-4d3c-20a8-08dad9b0c31d
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 06:44:04.1190
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iOxQCmkhFwei+CRWCGD+BK+Bh2wTqVWHH9lIFhyqJSu6P76YUen7PjCkouKKOP9oyXqtXU+hxdzYRlzHn06TPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7039
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Bagas Sanjaya,

On 12/8/2022 8:12 AM, Bagas Sanjaya wrote:
> On Wed, Dec 07, 2022 at 03:46:46PM +0000, Wyes Karny wrote:
>> +	amd_pstate=	[X86]
>> +			disable
>> +			  Do not enable amd_pstate as the default
>> +			  scaling driver for the supported processors
>> +			passive
>> +			  Use amd_pstate as a scaling driver, driver requests a
>> +			  desired performance on this abstract scale and the power
>> +			  management firmware translates the requests into actual
>> +			  hardware states (core frequency, data fabric and memory
>> +			  clocks etc.)
> 
> Device drivers request certain performance level?

What about the below wording?

""

passive
	Use amd_pstate with passive mode as a scaling driver.
	In this mode autonomous selection is disabled.
	Driver requests a desired performance level and PMFW
	tires to match the same performance level (if it is
	satisfied by guaranteed performance level).

""

Perry, let me know if it looks fine to you?

> 
>> +			guided
>> +			  Activate guided autonomous mode. Driver requests minimum
>> +			  performance and maximum performance and the PMFW autonomously
>> +			  selects frequencies in this range.
> 
> Same here.

I'll rewrite this as:

guided
	Activate guided autonomous mode. Driver requests minimum and
	maximum performance level and the PMFW autonomously
	selects a performance level in this range and appropriate
	to the current workload.

> 
> Thanks. 
> 

-- 
Thanks & Regards,
Wyes