Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2327023rwb; Fri, 9 Dec 2022 00:13:01 -0800 (PST) X-Google-Smtp-Source: AA0mqf4EkwzlkRgRi9lOnKviFucToz+e6bADInYcPhnOUtksyMwMTrDojIYy+FiDyiNREZ9n/Sm9 X-Received: by 2002:a17:906:8d06:b0:7ae:e8f:d479 with SMTP id rv6-20020a1709068d0600b007ae0e8fd479mr3962621ejc.75.1670573581758; Fri, 09 Dec 2022 00:13:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670573581; cv=none; d=google.com; s=arc-20160816; b=BTbOWd8Jl+SIUEu46wJnOKFvXF+sY515jYdnm+j07lgXZYp8igPtIoys/YPKg92uQC 0ylRBnrn6ZPjSY2sEbB3RYDTCikzak4QN3jK7WdtSZj5YMVvIXKr8scjH9XiVriccnwL uMaJ9Fl+FCQFAOHx4P9ReclHIP48fjnRlOw2rEX5OJooJ9Wv6uoK9isXUahDfOpqdbCE 5l0aCoqemRlINTgTi8pot5QNIBFABb2ohIBous/7Gn3Pxatvtga/Ak+ZTBLRCpsNtH4m +tWu6iyaKUxMsh0c8DVly1aY6Md7W9M75LI9bMfotOrc6t8wXqfnnq1/8hFXatPGVvWn C9XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=FZ8hUe+wDVfcXZFasPofq++d5JzIKUkQA0LPKASkWts=; b=QATsD848JQ/1kkRG2F9y7BYersKE+Jjw9jS0+vBF4leAGYTjG9Ai7UQDmw4BsW02PV DED3yyYA5iotC3FosyrmPqk3H5Vnb8QiW/mmEuLOlKxltKQbT+DMfIQUuyIiSfM9mbd/ uHQuPEnH0I+05uyAriJDdNETgNQ4X/Wl7Ku3TbF9qJr7Vl6nZLSghn4TpcnggKqsERYY WumEfvLYfBrJqp/DudLv/5SzB5V5kB7KAwQ0FU+rA3z0NK3ty49zdiQfYj6HNsXV4vCq trq7a1nuEUr8LwPwyH3qNqm13H1CglBNGWQMVJSkoemOPjfBsI4cxlZc6+nEiAqF0YI/ kD5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UD4mCOnY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp23-20020a1709073e1700b0078df1c345dcsi890739ejc.535.2022.12.09.00.12.44; Fri, 09 Dec 2022 00:13:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UD4mCOnY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbiLIH7t (ORCPT + 73 others); Fri, 9 Dec 2022 02:59:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230023AbiLIH7o (ORCPT ); Fri, 9 Dec 2022 02:59:44 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBD1654773 for ; Thu, 8 Dec 2022 23:58:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670572720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FZ8hUe+wDVfcXZFasPofq++d5JzIKUkQA0LPKASkWts=; b=UD4mCOnYTsuIbWY0Sx/u0pBlvmoU0XerfU56k2xyNZz8fms1HkgyQ8PrRSr7r3axVRzIyP tHiGDqE75Qhfl2FABg8xAW8SP1zOLtSnDtfK5Qy09Vq0lHqw1fQOcld1EpmAU2Y54GECus 02HG8iJGOyLajUYmn6iXpA13lUSqiKw= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-509-4xw6paxzMZ-r-gFOxKDfEA-1; Fri, 09 Dec 2022 02:58:38 -0500 X-MC-Unique: 4xw6paxzMZ-r-gFOxKDfEA-1 Received: by mail-ej1-f70.google.com with SMTP id gn36-20020a1709070d2400b007ba3374574dso2598317ejc.23 for ; Thu, 08 Dec 2022 23:58:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FZ8hUe+wDVfcXZFasPofq++d5JzIKUkQA0LPKASkWts=; b=dG/4CS6raxzlWNQEzVzmHrF5iy0Mg1m7KqblDqvCiQ9K9Zs1zvPF5oIzWcqldsf32/ sISABKGXL6bcK3i2h26X6e63lnbgimtNBauC5VZABCeIPtKfOcoVcKo7C32SB+htQ8hO bRrobN+urcynZAujhjuY0s8T+IP/JJ+d3ozaW+ASmFdoMoAL7QPMxFvYPqbGf5xAG/hO lDFMIU7NnZ9hBgt/802R/kxjbHwI50cNFJ4D8SqsqBv2C+XZLoF+AqMVD75HMgRSg8SR mfCaD5Z9ve3eoN9C4mWvhzV8CnM0kHdSMxQ1NrX+pTWjhWmHXWj7v3Xyzh6JnLh1uhrt wG+Q== X-Gm-Message-State: ANoB5pmsprP7Vya2nSl2go0JFU/gTP5VCY11osRHS/NTym6o5A/3bF25 wQ0nvDjw9dgseHWE+rSNvXJlhYJfq4QZPvYd1X2+dxxm20ACpTo7CITAKUGM290PJ/qY/bVyfZp Unebq+3wletVBy23FdBp0QvYn X-Received: by 2002:a17:907:9a09:b0:78d:f456:1eb4 with SMTP id kr9-20020a1709079a0900b0078df4561eb4mr4267461ejc.5.1670572717484; Thu, 08 Dec 2022 23:58:37 -0800 (PST) X-Received: by 2002:a17:907:9a09:b0:78d:f456:1eb4 with SMTP id kr9-20020a1709079a0900b0078df4561eb4mr4267448ejc.5.1670572717233; Thu, 08 Dec 2022 23:58:37 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:e3ec:5559:7c5c:1928? ([2001:b07:6468:f312:e3ec:5559:7c5c:1928]) by smtp.googlemail.com with ESMTPSA id sg43-20020a170907a42b00b007be3aa82543sm270823ejc.35.2022.12.08.23.58.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Dec 2022 23:58:36 -0800 (PST) Message-ID: <372a8ea3-6a87-5eb4-0712-ce48e85ba58e@redhat.com> Date: Fri, 9 Dec 2022 08:58:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH] kvm: x86/mmu: Remove duplicated "be split" in spte.h Content-Language: en-US To: Lai Jiangshan , linux-kernel@vger.kernel.org Cc: Lai Jiangshan , Sean Christopherson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org References: <20221207120505.9175-1-jiangshanlai@gmail.com> From: Paolo Bonzini In-Reply-To: <20221207120505.9175-1-jiangshanlai@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/7/22 13:05, Lai Jiangshan wrote: > From: Lai Jiangshan > > "be split be split" -> "be split" > > Signed-off-by: Lai Jiangshan > --- > arch/x86/kvm/mmu/spte.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/mmu/spte.h b/arch/x86/kvm/mmu/spte.h > index 1f03701b943a..6f54dc9409c9 100644 > --- a/arch/x86/kvm/mmu/spte.h > +++ b/arch/x86/kvm/mmu/spte.h > @@ -363,7 +363,7 @@ static __always_inline bool is_rsvd_spte(struct rsvd_bits_validate *rsvd_check, > * A shadow-present leaf SPTE may be non-writable for 4 possible reasons: > * > * 1. To intercept writes for dirty logging. KVM write-protects huge pages > - * so that they can be split be split down into the dirty logging > + * so that they can be split down into the dirty logging > * granularity (4KiB) whenever the guest writes to them. KVM also > * write-protects 4KiB pages so that writes can be recorded in the dirty log > * (e.g. if not using PML). SPTEs are write-protected for dirty logging Queued, thanks. Paolo