Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c958aa5a-1bd2-7f81-0f20-fd3a42393528@redhat.com>
Date:   Fri, 9 Dec 2022 08:58:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH] kvm: Remove the unused macro KVM_MMU_READ_LOCK()
Content-Language: en-US
To:     Lai Jiangshan <jiangshanlai@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     Sean Christopherson <seanjc@google.com>,
        Lai Jiangshan <jiangshan.ljs@antgroup.com>, kvm@vger.kernel.org
References: <20221207120617.9409-1-jiangshanlai@gmail.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
In-Reply-To: <20221207120617.9409-1-jiangshanlai@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/7/22 13:06, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@antgroup.com>
> 
> No code is using KVM_MMU_READ_LOCK().

And KVM_MMU_READ_UNLOCK() is also unused.

Paolo

> Signed-off-by: Lai Jiangshan <jiangshan.ljs@antgroup.com>
> ---
>   virt/kvm/kvm_mm.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/virt/kvm/kvm_mm.h b/virt/kvm/kvm_mm.h
> index a1ab15006af3..e98e294080bf 100644
> --- a/virt/kvm/kvm_mm.h
> +++ b/virt/kvm/kvm_mm.h
> @@ -14,13 +14,11 @@
>   #define KVM_MMU_LOCK_INIT(kvm)		rwlock_init(&(kvm)->mmu_lock)
>   #define KVM_MMU_LOCK(kvm)		write_lock(&(kvm)->mmu_lock)
>   #define KVM_MMU_UNLOCK(kvm)		write_unlock(&(kvm)->mmu_lock)
> -#define KVM_MMU_READ_LOCK(kvm)		read_lock(&(kvm)->mmu_lock)
>   #define KVM_MMU_READ_UNLOCK(kvm)	read_unlock(&(kvm)->mmu_lock)
>   #else
>   #define KVM_MMU_LOCK_INIT(kvm)		spin_lock_init(&(kvm)->mmu_lock)
>   #define KVM_MMU_LOCK(kvm)		spin_lock(&(kvm)->mmu_lock)
>   #define KVM_MMU_UNLOCK(kvm)		spin_unlock(&(kvm)->mmu_lock)
> -#define KVM_MMU_READ_LOCK(kvm)		spin_lock(&(kvm)->mmu_lock)
>   #define KVM_MMU_READ_UNLOCK(kvm)	spin_unlock(&(kvm)->mmu_lock)
>   #endif /* KVM_HAVE_MMU_RWLOCK */
>