Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6209d614-b1f2-4501-6b8a-6d4095c309eb@redhat.com>
Date:   Fri, 9 Dec 2022 09:07:44 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.0
Subject: Re: [PATCH v1] mm/userfaultfd: enable writenotify while
 userfaultfd-wp is enabled for a VMA
To:     Peter Xu <peterx@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Ives van Hoorne <ives@codesandbox.io>,
        stable@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Hugh Dickins <hugh@veritas.com>,
        Alistair Popple <apopple@nvidia.com>,
        Mike Rapoport <rppt@linux.vnet.ibm.com>,
        Nadav Amit <nadav.amit@gmail.com>,
        Andrea Arcangeli <aarcange@redhat.com>
References: <20221208114137.35035-1-david@redhat.com> <Y5IQzJkBSYwPOtiP@x1n>
 <b9162f04-7d8e-1ada-f428-85fd84327d1c@redhat.com> <Y5JDrkBGEyZviXz9@x1n>
 <Y5JHY2zyK4k8aBtX@x1n>
Content-Language: en-US
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat
In-Reply-To: <Y5JHY2zyK4k8aBtX@x1n>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 08.12.22 21:21, Peter Xu wrote:
> On Thu, Dec 08, 2022 at 03:06:06PM -0500, Peter Xu wrote:
>> On Thu, Dec 08, 2022 at 05:44:35PM +0100, David Hildenbrand wrote:
>>> I'll wait for some more (+retest) before I resend tomorrow.
>>
>> One more thing just to double check:
>>
>> It's 6a56ccbcf6c6 ("mm/autonuma: use can_change_(pte|pmd)_writable() to
>> replace savedwrite", 2022-11-30) that just started to break uffd-wp on
>> numa, am I right?
>>
>> With the old code, pte_modify() will persist uffd-wp bit, afaict, and we
>> used to do savedwrite for numa hints.  That all look correct to me until
>> the savedwrite removal patchset with/without vm_page_prot changes.
>>
>> If that's the case, we'd better also mention that in the commit message and
>> has another Fixes: for that one to be clear.
> 
> Nah, never mind.  I think the savedwrite will not guarantee pte write
> protected just like the migration path.  The commit message is correct.

Right, the problem is not the uffd-wp bit getting lost, but the write 
bit getting set, which is independent of 6a56ccbcf6c6. Thanks for 
double-checking 6a56ccbcf6c6.

-- 
Thanks,

David / dhildenb