Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bf226a20-f22c-cf8f-4f19-eb21033ae1c8@amd.com>
Date:   Fri, 9 Dec 2022 14:31:56 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH 4/4] Documentation: amd_pstate: Add amd_pstate state sysfs
 file
Content-Language: en-US
To:     Bagas Sanjaya <bagasdotme@gmail.com>, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Cc:     Jonathan Corbet <corbet@lwn.net>, Huang Rui <ray.huang@amd.com>,
        "Rafael J . Wysocki" <rafael@kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Mario.Limonciello@amd.com, Perry.Yuan@amd.com,
        Ananth Narayan <ananth.narayan@amd.com>, gautham.shenoy@amd.com
References: <20221207154648.233759-1-wyes.karny@amd.com>
 <20221207154648.233759-5-wyes.karny@amd.com> <Y5FTHGsezkdzwvUa@debian.me>
From:   Wyes Karny <wyes.karny@amd.com>
In-Reply-To: <Y5FTHGsezkdzwvUa@debian.me>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUFBVDdvRTArRGdscWc5eWVLUXBjYUNrNER4WFA2WHJ3UHJ5M0doOW5yU09Q?=
 =?utf-8?B?K2E4b2RoTzMweDc5ekpwc1A0TzhrZ21mU3pYNHlvZ3FTTFFYV2Z4akxWNFpT?=
 =?utf-8?B?MS81SXhyY09rU0pjZEkrekJCZTFaenlHaDdaSnJ6eDhFTkphLy9tWEVMR21n?=
 =?utf-8?B?RmJUUGloMituTzN0Vk5yY21ZcjliYXB1SkJCY0ZWaFJuMUFQOW1CeVdkRFpu?=
 =?utf-8?B?OExGUEhRUmxZN1BRVUVlYlQyc2NMaWNnNFhQMlF1UFhtR0NSOVFKZ3lCQkE3?=
 =?utf-8?B?ZmgyZUZZVFRicmhVdU9MdktrakdsZ1lDSzROMnQrRFgvelhOSGJpdE5GbVJK?=
 =?utf-8?B?cUs5L09zV21BY29ndFNKS3JLWHlKVkF4YjhvNnQrZHp5S0R1S0dVU2hRU1Ew?=
 =?utf-8?B?RGIwUlp6d2tMRmE4Uk5aSDBIa2lsSDlseXlJMnVpYUpENFlWNjdzN1NwL05a?=
 =?utf-8?B?TE1SU2pFWEl0M29YYm5tTlpxYS9HRGVzVWJzVjZQTVZ3LzFGajJLQzArTHp2?=
 =?utf-8?B?Y1JSL200d3hUMTZsZ2JHNWZTa3lESGtGeUdmUXBCUzg1V01aeXlGMm5SYlFT?=
 =?utf-8?B?Y0FDNkZ0S1N6ZVZkd2pHSU9JeTNDV1orcWV0Nm1nTExhRkVVV2wzclFFMUZT?=
 =?utf-8?B?c2Y2YkxUdWREakMxV0w0MjdveUptWlNFVS9iblR1eDlPc0xiMmUvaG5kV1ZU?=
 =?utf-8?B?d3RtWnYvRG5mbEY4N1N0QWxjL1h2L2hDejAzTjg4NmRSM25sZTRpV09keXMw?=
 =?utf-8?B?dmZoNDFIOTJEZXZVb0tSTU1Cekx2WnZCcTJhNjBSTVc2WU5LRklZay9XTUhp?=
 =?utf-8?B?NmNFaDBkUWREbWplTWN2bFFEcGJJdk00dXp3VnU4RGxFMVJCY2k3ZjZQV2Fq?=
 =?utf-8?B?dmpSLzJUbGIvMmFUL0lpT1ZkeEhEbGRQOGd3Yk9QQVNwb3ZDR3U0WmlMcVFC?=
 =?utf-8?B?KzZWLzhWTHJWY0VqZnVXeUVxcitlSEtyTjRmNFhtdVc1bWxMUklrb3NjZmlG?=
 =?utf-8?B?cFlSWkhUWXBPM0o3WkFsRVRxdUsrV0w4Z0lUcE9PMENrdm4zWVUwVTNqR29l?=
 =?utf-8?B?K3lsTUx6NTgvNzlDb3M3c3BOcHlDdThXdExJSWdnNUpFSE5adlJGVmxEeHBU?=
 =?utf-8?B?T0lUaHdMOUxYVzVqaWFmb0xzQUlXZmJVOExIclpURGxySjQ5bU5EOVlwZDNn?=
 =?utf-8?B?c29jUXhXNXc1djhVSWtMaFdOOHMweGNuSE5FdCtSVVVHdXNGUytzcEl1WGVY?=
 =?utf-8?B?b2ZsWGpVUmxybkJtM0poNGlGSitEcDlyWU1OWFhqT0NrRDdpUUh5RnIrcEdL?=
 =?utf-8?B?ZnlTbzJSQW1XeHVIRFZuNkl5M0RrWkQ3d3ExRCtKZTJHL1VHWWdvMmZwcTBX?=
 =?utf-8?B?eENxdzZNL1Q4T29KK1JJVHA0bnQ1S1o0R0QwSGpDL0JjZ3R6a1BlbEFpWTUr?=
 =?utf-8?B?TG5xWHRiM1dybk05dmRLQ2xuWWZKWE5tQ0g5UHRyQ0J5MHVEWU1CVWJtMm5P?=
 =?utf-8?B?eDg3Q3UzZWhnQnVINXEvVnVKMGkwbEV2aVo1MXFLLzNTV29LM3gvRVp4RytD?=
 =?utf-8?B?R3J1N2k4Skp4VGdzY28vNlhQZW13VTVDZEF5SjVOUGk3ZXk1S05PQ29ETTQv?=
 =?utf-8?B?SW1hNDhpcnl0ZitFbFJqbHQ5b1VLOUNHb0FsenB6WEI1cklHZHg1SXdaMW9n?=
 =?utf-8?B?TkJpVExkT0VPNDBlY0VESkE5UDZvYzhMQzRpM2lLU2NFRGplMEs0T3kyTGIv?=
 =?utf-8?B?MnhSQ0FjdVVJVTlXZHlKWmc3QXZYTVoxckNhUWdQN1k2UDFRaUltVWRFbzJa?=
 =?utf-8?B?ejlqaTBnditzU3FwREpKTDB0YjFhQ1NGTEZNNWJ2bkd1UEdXS1I2aG93Wndu?=
 =?utf-8?B?WU0yZFc4NGZKdXFDVzV0ODg1dC80SUFkQnNHM3dzRVFCa0dXUkJzeXVOTTNm?=
 =?utf-8?B?YUJJRUJ2bGtSWjc3YWdLdDJXV2crQ0RjUVJCTk4zd1c1ajYxUTM2bEE4SzN3?=
 =?utf-8?B?MUxUQmphenlpcWxMUXU0aFNaaGtDdkxFZjVmeVl4VGlJZW5XalVQU0JNcU5J?=
 =?utf-8?B?TEhZUW8xMlRnUmhnaTNMbVFRTnpOQ0RqUWdqQlhnN3ErWTJ1VVZYTzl2VjIw?=
 =?utf-8?B?dVBxUWVDbVFkdGxXOFdQV2ZvUnFKNzFLMzdKYWs3dDFtUkZCMVZ2cU5NeCtO?=
 =?utf-8?Q?AosJD66YTeK043UphuGOSG+Ye6peOfCaWM+eQGR2yngS?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 88f8d25a-1cb2-4bee-816e-08dad9c40ccc
X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB3876.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Dec 2022 09:02:08.2111
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gyWydhTDj10HHITFDfUsHxrNUfg3qJlUrvAPJT8A7qHPPrS8+vzdcCwtjMPtSRx4AUxOoL11KIV16Jao+Q9Q0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7373
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/8/2022 8:29 AM, Bagas Sanjaya wrote:
> On Wed, Dec 07, 2022 at 03:46:48PM +0000, Wyes Karny wrote:
>> +``state``
>> +
>> +``amd_pstate`` also exposes a sysfs interface to view and control the driver state.
>> +The driver state can be one of the following:
>> +``disable``     : indicates driver is in unloaded state.
>> +``passive``     : indicates driver is loaded and currently in passive mode.
>> +``guided`` : indicates driver is loaded and currenlty in guided autonomous mode.
> 
> Use bullet lists for above:
> 
> ---- >8 ----
> 
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 4d3783516ddc2c..0d0e0affa3adb2 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -269,9 +269,12 @@ Other performance and frequency values can be read back from
>  
>  ``amd_pstate`` also exposes a sysfs interface to view and control the driver state.
>  The driver state can be one of the following:
> -``disable``     : indicates driver is in unloaded state.
> -``passive``     : indicates driver is loaded and currently in passive mode.
> -``guided`` : indicates driver is loaded and currenlty in guided autonomous mode.
> +
> +  - ``disable``     : indicates driver is in unloaded state.
> +  - ``passive``     : indicates driver is loaded and currently in passive mode.
> +  - ``guided``      : indicates driver is loaded and currenlty in guided
> +    autonomous mode.
> +
>  This file can be found here: ``/sys/devices/system/cpu/amd_pstate/state``.
>  
>  To switch to passive mode: ``echo passive > /sys/devices/system/cpu/amd_pstate/state``
> 
>> +This file can be found here: ``/sys/devices/system/cpu/amd_pstate/state``.
>> +
>> +To switch to passive mode: ``echo passive > /sys/devices/system/cpu/amd_pstate/state``
>> +To switch to guided mode: ``echo guided > /sys/devices/system/cpu/amd_pstate/state``
>>  
> 
> What about these wordings instead?
> 
> ---- >8 ----
>  
> diff --git a/Documentation/admin-guide/pm/amd-pstate.rst b/Documentation/admin-guide/pm/amd-pstate.rst
> index 4d3783516ddc2c..6465bd39b7dcbc 100644
> --- a/Documentation/admin-guide/pm/amd-pstate.rst
> +++ b/Documentation/admin-guide/pm/amd-pstate.rst
> @@ -267,15 +267,16 @@ Other performance and frequency values can be read back from
>  
>  ``state``
>  
> -``amd_pstate`` also exposes a sysfs interface to view and control the driver state.
> -The driver state can be one of the following:
> -``disable``     : indicates driver is in unloaded state.
> -``passive``     : indicates driver is loaded and currently in passive mode.
> -``guided`` : indicates driver is loaded and currenlty in guided autonomous mode.
> -This file can be found here: ``/sys/devices/system/cpu/amd_pstate/state``.
> +``amd_pstate`` also exposes a sysfs interface to view and control the driver
> +state, named ``/sys/devices/system/cpu/amd_pstate/state``. The driver state
> +can be one of the following:
>  
> -To switch to passive mode: ``echo passive > /sys/devices/system/cpu/amd_pstate/state``
> -To switch to guided mode: ``echo guided > /sys/devices/system/cpu/amd_pstate/state``
> +  - ``disable``     : the driver is disabled
> +  - ``passive``     : the driver is in passive mode.
> +  - ``guided``      : the driver is in guided autonomous mode.
> +
> +To switch between these modes above, write the appropriate value to the
> +aforementioned sysfs file.

LGTM. I'll reword. Thanks!

>  
>  ``amd-pstate`` vs ``acpi-cpufreq``
>  ======================================
> 
> Thanks.
> 

-- 
Thanks & Regards,
Wyes