Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp2430422rwb; Fri, 9 Dec 2022 01:54:17 -0800 (PST) X-Google-Smtp-Source: AA0mqf6LE+DkV/qwRsoMkitbsBqiq/fSY9JXzaW2X1pb6TevoasDT0W05R4d8cPKX0gX6/2M9B/V X-Received: by 2002:a17:902:cf03:b0:186:8568:be7e with SMTP id i3-20020a170902cf0300b001868568be7emr6495453plg.15.1670579657376; Fri, 09 Dec 2022 01:54:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670579657; cv=none; d=google.com; s=arc-20160816; b=PriGfEHXbiUOjTON/VdAlpz6mEk/CEgQYdnGXg/cEF2hd2Lelbu5imADaQ30BrD3LS ZTULLaOGjOvi5ckSV4iDqTNtcm1CDyzXEcFkW5fG8qpwuAeL9njHJ9fmAOUSZvFGbe2e 98yxk3KNJgU0keAlfTlwchNU6qFWykBwV2DJlipuOweCtS3ebEDRPfKIGv4DyYMXLLzj wzwX9+j5ijPe3gx4uHd6seHJCR6LmPa0RnCq6/KUIuPaNTJ4OYmvbfGqn3685pWIhULb 7gc2p809RCjb8sZOViqoZmGQy19+nUTkUNeQNPRB2o/OCQmI6At2lXyK7w2MX/zHOmrk T4nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=TBaG2t6y9Vvz1zj0bl0wpZaZRcvZHGDd3YjfoNFrqRg=; b=KJ3RAgnxTC377q6wuAe8WJE+zdtQ6BWuZTPorg7zhu8H/5oK53dpagvhPeRwQpYgOh CHSjl3rupXcivke2iQwgMI9We37yqr4NgGAHIuBxw2cTp49FsBZP0ZAbuyFAUt6JUOEy /SC5MvAeRkvyFnsADqv7n1qXMFSTimGzu5kTJ7LMMub11wS8KU5BDrI+THbJDymjBKRt VX/newKg5WNPUyXYzml9qWlIJOCPepxZParISgE/fNANbhoThZ8TBxhQCOwShNb1Fq8a LEPykXgn6Eb+aIC8cScNSa+TtCPv29T2Xv/078w/Li8ky8RfxTmnF/opnz1ic8oUzW/w hvww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=doMnr8Wt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s1-20020a170902c64100b00187204b35besi1077625pls.203.2022.12.09.01.54.04; Fri, 09 Dec 2022 01:54:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.com header.s=susede1 header.b=doMnr8Wt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=suse.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230003AbiLIJMv (ORCPT + 73 others); Fri, 9 Dec 2022 04:12:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230117AbiLIJM1 (ORCPT ); Fri, 9 Dec 2022 04:12:27 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C0326A743; Fri, 9 Dec 2022 01:12:09 -0800 (PST) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id CE83C1FDB3; Fri, 9 Dec 2022 09:12:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1670577127; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TBaG2t6y9Vvz1zj0bl0wpZaZRcvZHGDd3YjfoNFrqRg=; b=doMnr8Wtu4dbzgG730w/sKnsA3p2EwEclybKIQGl1IxXhx9ifEhx6w8CVUFnJdUfVybIKE Q+6HaBmf8K5hCUXk3xRtgsPtr32wpSdPlTDCy4OKx/CG9tNTj2Xv/eC5nGQZZ1D5OGkHaj 1kRalG2xC6VMHcM19rAFblF+Tj0tUVg= Received: from suse.cz (unknown [10.100.201.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id A73412C14F; Fri, 9 Dec 2022 09:12:07 +0000 (UTC) Date: Fri, 9 Dec 2022 10:12:07 +0100 From: Petr Mladek To: Zhen Lei Cc: Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Joe Lawrence , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Alexei Starovoitov , Jiri Olsa , Kees Cook , Andrew Morton , Luis Chamberlain , linux-modules@vger.kernel.org Subject: Re: [PATCH] livepatch: Call klp_match_callback() in klp_find_callback() to avoid code duplication Message-ID: References: <20221207032304.2017-1-thunder.leizhen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221207032304.2017-1-thunder.leizhen@huawei.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 2022-12-07 11:23:04, Zhen Lei wrote: > The implementation of function klp_match_callback() is identical to the > partial implementation of function klp_find_callback(). So call function > klp_match_callback() in function klp_find_callback() instead of the > duplicated code. > > Signed-off-by: Zhen Lei Thanks for cleaning this. Reviewed-by: Petr Mladek Best Regards, Petr