Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 9 Dec 2022 17:07:39 +0200
From:   Vladimir Oltean <olteanv@gmail.com>
To:     Arun Ramadoss <arun.ramadoss@microchip.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
        andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, linux@armlinux.org.uk,
        Tristram.Ha@microchip.com, richardcochran@gmail.com,
        ceggers@arri.de
Subject: Re: [Patch net-next v3 08/13] net: dsa: microchip: ptp: add packet
 transmission timestamping
Message-ID: <20221209150739.bddwnli5ddaxmws5@skbuf>
References: <20221209072437.18373-1-arun.ramadoss@microchip.com>
 <20221209072437.18373-1-arun.ramadoss@microchip.com>
 <20221209072437.18373-9-arun.ramadoss@microchip.com>
 <20221209072437.18373-9-arun.ramadoss@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221209072437.18373-9-arun.ramadoss@microchip.com>
 <20221209072437.18373-9-arun.ramadoss@microchip.com>
Precedence: bulk

On Fri, Dec 09, 2022 at 12:54:32PM +0530, Arun Ramadoss wrote:
> From: Christian Eggers <ceggers@arri.de>
> 
> This patch adds the routines for transmission of ptp packets. When the
> ptp pdelay_req packet to be transmitted, it uses the deferred xmit
> worker to schedule the packets.
> During irq_setup, interrupt for Sync, Pdelay_req and Pdelay_rsp are
> enabled. So interrupt is triggered for all three packets. But for
> p2p1step, we require only time stamp of Pdelay_req packet. Hence to
> avoid posting of the completion from ISR routine for Sync and
> Pdelay_resp packets, ts_en flag is introduced. This controls which
> packets need to processed for timestamp.
> After the packet is transmitted, ISR is triggered. The time at which
> packet transmitted is recorded to separate register.
> This value is reconstructed to absolute time and posted to the user
> application through socket error queue.
> 
> Signed-off-by: Christian Eggers <ceggers@arri.de>
> Co-developed-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> Signed-off-by: Arun Ramadoss <arun.ramadoss@microchip.com>
> ---

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>